Page MenuHomePhabricator

[web] cleanup thread notifications modal
ClosedPublic

Authored by ginsu on Dec 12 2023, 12:36 PM.
Tags
None
Referenced Files
F3300602: D10315.id37159.diff
Sun, Nov 17, 8:17 PM
F3300158: D10315.diff
Sun, Nov 17, 6:24 PM
Unknown Object (File)
Wed, Nov 13, 10:56 AM
Unknown Object (File)
Thu, Oct 31, 10:09 AM
Unknown Object (File)
Thu, Oct 31, 10:09 AM
Unknown Object (File)
Thu, Oct 31, 10:09 AM
Unknown Object (File)
Thu, Oct 31, 10:09 AM
Unknown Object (File)
Thu, Oct 31, 10:09 AM
Subscribers

Details

Summary

This diff cleans up the one off styles in the thread notification modal and replaces it with styles of the redesigned modal.

Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs

Depends on D10282

Test Plan

Please see screenshot below

channel:

Screenshot 2023-12-12 at 3.38.55 PM.png (1×3 px, 891 KB)

subchannel:

Screenshot 2023-12-12 at 3.39.05 PM.png (1×3 px, 938 KB)

parent channel is backgrounded:

Screenshot 2023-12-12 at 3.39.46 PM.png (1×3 px, 906 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 12 2023, 1:15 PM
Harbormaster failed remote builds in B24998: Diff 34539!
ginsu requested review of this revision.Dec 12 2023, 1:23 PM

will make sure ci passes before landing

This revision is now accepted and ready to land.Dec 13 2023, 10:38 PM
This revision was automatically updated to reflect the committed changes.