Page MenuHomePhabricator
Differential D11995

[keyserver/lib] introduce fetch_community_infos endpoint
ClosedPublic
Actions

Authored by ginsu on May 10 2024, 11:11 AM.
Tags
None
Referenced Files
F5373548: D11995.diff
Wed, Apr 9, 4:08 PM
Unknown Object (File)
Mon, Mar 17, 4:53 PM
Unknown Object (File)
Fri, Mar 14, 1:01 PM
Unknown Object (File)
Wed, Mar 12, 8:14 AM
Unknown Object (File)
Wed, Mar 12, 2:50 AM
Unknown Object (File)
Tue, Mar 11, 2:52 PM
Unknown Object (File)
Mar 10 2025, 5:57 AM
Unknown Object (File)
Mar 7 2025, 3:52 AM
View All Files
Subscribers
ashoat
inka
tomek

Details

Reviewers
tomek
kamil
Commits
rCOMMda773f537f42: [keyserver/lib] introduce fetch_community_infos endpoint
Summary

This diff introduces the fetch_community_infos endpoint. Similar to the fetch_primary_invite_links we will call this endpoint whenever we open the community drawer on native or when the window becomes active on web

Depends on D11978

Test Plan

Called this endpoint later in my stack and confirmed that I was getting all the correct community infos

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.May 10 2024, 11:11 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 10 2024, 11:11 AM
ginsu edited the summary of this revision. (Show Details)May 10 2024, 11:13 AM
ginsu added reviewers: tomek, kamil.
ginsu added a parent revision: D11978: [keyserver/lib] update deleteFarcasterChannelTag to use communites table.
ginsu added a child revision: D11996: [lib] introduce fetch community infos redux action.May 10 2024, 11:20 AM
Harbormaster returned this revision to the author for changes because remote builds failed.May 10 2024, 11:24 AM
Harbormaster failed remote builds in B28843: Diff 40083!
ginsu mentioned this in D11997: [web] introduce CommunitiesRefresher.May 10 2024, 11:55 AM
ginsu updated this revision to Diff 40087.May 10 2024, 1:47 PM

rebase

Harbormaster completed remote builds in B28846: Diff 40087.May 10 2024, 2:04 PM
ginsu requested review of this revision.May 10 2024, 2:04 PM
ashoat added a comment.May 10 2024, 2:07 PM

Similar to the fetch_primary_invite_links we will call this endpoint whenever we open the community drawer on native or when the window becomes active on web

Can you explain to your reviewers why we need to do this?

ashoat added a comment.May 11 2024, 10:53 AM

Looking at the project I think it's so that if the user goes the community settings cog and selects the Farcaster channel option, they will be able to see the Farcaster channel. Similar pattern to how we do it for invite links

tomek accepted this revision.May 13 2024, 3:13 AM
tomek added inline comments.
keyserver/src/responders/community-responders.js
14 ↗(On Diff #40087)

Wouldn't that make more sense to place this validator next to FetchCommunityInfosResponse type definition?

22 ↗(On Diff #40087)

Not sure how useful it is to put withHolder in the name - this can easily become outdated by a change in fetchCommunityInfos.

This revision is now accepted and ready to land.May 13 2024, 3:13 AM
ginsu mentioned this in D12023: [native] call fetchCommunityInfos from the community drawer.May 13 2024, 11:02 PM
ginsu added a subscriber: inka.May 22 2024, 7:30 AM
ginsu added inline comments.
keyserver/src/responders/community-responders.js
14 ↗(On Diff #40087)

It looks like we now put all our response validators in a separate location in lib/types/validators. Updating this diff to follow this new convention

cc @inka

ginsu updated this revision to Diff 40547.May 22 2024, 7:30 AM

address comments

Harbormaster completed remote builds in B29176: Diff 40547.May 22 2024, 7:57 AM
inka added inline comments.May 28 2024, 1:36 AM
keyserver/src/responders/community-responders.js
14 ↗(On Diff #40087)

Thank you!

ginsu updated this revision to Diff 41004.Jun 5 2024, 10:59 PM

rebase before landing

Harbormaster completed remote builds in B29469: Diff 41004.Jun 5 2024, 11:14 PM
Closed by commit rCOMMda773f537f42: [keyserver/lib] introduce fetch_community_infos endpoint (authored by ginsu). · Explain WhyJun 5 2024, 11:57 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMda773f537f42: [keyserver/lib] introduce fetch_community_infos endpoint.
ginsu mentioned this in rCOMM3d814e1c9414: [web] introduce CommunitiesRefresher.
ginsu mentioned this in rCOMM2192cb520ece: [native] call fetchCommunityInfos from the community drawer.

Revision Contents
Changeset List

PathSize
keyserver/
src/
6 lines
fetchers/
5 lines
responders/
21 lines
lib/
types/
19 lines
1 line
validators/
16 lines
2 lines

Diff 40547

View Options

keyserver/src/endpoints.js

  • This file was added.
// @flow
import uuid from 'uuid';
import type {
DMOperationSpec,
ProcessDMOperationUtilities,
} from './dm-op-spec.js';
import type { DMRemoveMembersOperation } from '../../types/dm-ops.js';
import { messageTypes } from '../../types/message-types-enum.js';
import type { ThickRawThreadInfo } from '../../types/minimally-encoded-thread-permissions-types.js';
import { updateTypes } from '../../types/update-types-enum.js';
import type { ClientUpdateInfo } from '../../types/update-types.js';
const removeMembersSpec: DMOperationSpec<DMRemoveMembersOperation> =
Object.freeze({
processDMOperation: async (
dmOperation: DMRemoveMembersOperation,
viewerID: string,
utilities: ProcessDMOperationUtilities,
) => {
const { editorID, time, messageID, threadID, removedUserIDs } =
dmOperation;
const threadInfoOptional = utilities.getThreadInfo(threadID);
if (!threadInfoOptional || !threadInfoOptional.thick) {
// We can't perform this operation now. It should be queued for later.
return {
rawMessageInfos: [],
updateInfos: [],
};
}
const threadInfo: ThickRawThreadInfo = threadInfoOptional;
const removeMembersMessage = {
type: messageTypes.REMOVE_MEMBERS,
id: messageID,
threadID,
time,
creatorID: editorID,
removedUserIDs: [...removedUserIDs],
};
const removedUserIDsSet = new Set(removedUserIDs);
const viewerIsRemoved = removedUserIDsSet.has(viewerID);
const updateInfos: Array<ClientUpdateInfo> = [];
if (viewerIsRemoved) {
updateInfos.push({
type: updateTypes.DELETE_THREAD,
id: uuid.v4(),
time,
threadID,
});
} else {
const updatedThreadInfo = {
...threadInfo,
members: threadInfo.members.filter(
member => !removedUserIDsSet.has(member.id),
),
};
updateInfos.push({
type: updateTypes.UPDATE_THREAD,
id: uuid.v4(),
time,
threadInfo: updatedThreadInfo,
});
}
return {
rawMessageInfos: [removeMembersMessage],
updateInfos,
};
},
});
export { removeMembersSpec };
View Options

keyserver/src/fetchers/community-fetchers.js

  • This file was added.
// @flow
import uuid from 'uuid';
import type {
DMOperationSpec,
ProcessDMOperationUtilities,
} from './dm-op-spec.js';
import type { DMRemoveMembersOperation } from '../../types/dm-ops.js';
import { messageTypes } from '../../types/message-types-enum.js';
import type { ThickRawThreadInfo } from '../../types/minimally-encoded-thread-permissions-types.js';
import { updateTypes } from '../../types/update-types-enum.js';
import type { ClientUpdateInfo } from '../../types/update-types.js';
const removeMembersSpec: DMOperationSpec<DMRemoveMembersOperation> =
Object.freeze({
processDMOperation: async (
dmOperation: DMRemoveMembersOperation,
viewerID: string,
utilities: ProcessDMOperationUtilities,
) => {
const { editorID, time, messageID, threadID, removedUserIDs } =
dmOperation;
const threadInfoOptional = utilities.getThreadInfo(threadID);
if (!threadInfoOptional || !threadInfoOptional.thick) {
// We can't perform this operation now. It should be queued for later.
return {
rawMessageInfos: [],
updateInfos: [],
};
}
const threadInfo: ThickRawThreadInfo = threadInfoOptional;
const removeMembersMessage = {
type: messageTypes.REMOVE_MEMBERS,
id: messageID,
threadID,
time,
creatorID: editorID,
removedUserIDs: [...removedUserIDs],
};
const removedUserIDsSet = new Set(removedUserIDs);
const viewerIsRemoved = removedUserIDsSet.has(viewerID);
const updateInfos: Array<ClientUpdateInfo> = [];
if (viewerIsRemoved) {
updateInfos.push({
type: updateTypes.DELETE_THREAD,
id: uuid.v4(),
time,
threadID,
});
} else {
const updatedThreadInfo = {
...threadInfo,
members: threadInfo.members.filter(
member => !removedUserIDsSet.has(member.id),
),
};
updateInfos.push({
type: updateTypes.UPDATE_THREAD,
id: uuid.v4(),
time,
threadInfo: updatedThreadInfo,
});
}
return {
rawMessageInfos: [removeMembersMessage],
updateInfos,
};
},
});
export { removeMembersSpec };
View Options

keyserver/src/responders/community-responders.js

  • This file was added.
// @flow
import uuid from 'uuid';
import type {
DMOperationSpec,
ProcessDMOperationUtilities,
} from './dm-op-spec.js';
import type { DMRemoveMembersOperation } from '../../types/dm-ops.js';
import { messageTypes } from '../../types/message-types-enum.js';
import type { ThickRawThreadInfo } from '../../types/minimally-encoded-thread-permissions-types.js';
import { updateTypes } from '../../types/update-types-enum.js';
import type { ClientUpdateInfo } from '../../types/update-types.js';
const removeMembersSpec: DMOperationSpec<DMRemoveMembersOperation> =
Object.freeze({
processDMOperation: async (
dmOperation: DMRemoveMembersOperation,
viewerID: string,
utilities: ProcessDMOperationUtilities,
) => {
const { editorID, time, messageID, threadID, removedUserIDs } =
dmOperation;
const threadInfoOptional = utilities.getThreadInfo(threadID);
if (!threadInfoOptional || !threadInfoOptional.thick) {
// We can't perform this operation now. It should be queued for later.
return {
rawMessageInfos: [],
updateInfos: [],
};
}
const threadInfo: ThickRawThreadInfo = threadInfoOptional;
const removeMembersMessage = {
type: messageTypes.REMOVE_MEMBERS,
id: messageID,
threadID,
time,
creatorID: editorID,
removedUserIDs: [...removedUserIDs],
};
const removedUserIDsSet = new Set(removedUserIDs);
const viewerIsRemoved = removedUserIDsSet.has(viewerID);
const updateInfos: Array<ClientUpdateInfo> = [];
if (viewerIsRemoved) {
updateInfos.push({
type: updateTypes.DELETE_THREAD,
id: uuid.v4(),
time,
threadID,
});
} else {
const updatedThreadInfo = {
...threadInfo,
members: threadInfo.members.filter(
member => !removedUserIDsSet.has(member.id),
),
};
updateInfos.push({
type: updateTypes.UPDATE_THREAD,
id: uuid.v4(),
time,
threadInfo: updatedThreadInfo,
});
}
return {
rawMessageInfos: [removeMembersMessage],
updateInfos,
};
},
});
export { removeMembersSpec };
View Options

lib/types/community-types.js

  • This file was added.
// @flow
import uuid from 'uuid';
import type {
DMOperationSpec,
ProcessDMOperationUtilities,
} from './dm-op-spec.js';
import type { DMRemoveMembersOperation } from '../../types/dm-ops.js';
import { messageTypes } from '../../types/message-types-enum.js';
import type { ThickRawThreadInfo } from '../../types/minimally-encoded-thread-permissions-types.js';
import { updateTypes } from '../../types/update-types-enum.js';
import type { ClientUpdateInfo } from '../../types/update-types.js';
const removeMembersSpec: DMOperationSpec<DMRemoveMembersOperation> =
Object.freeze({
processDMOperation: async (
dmOperation: DMRemoveMembersOperation,
viewerID: string,
utilities: ProcessDMOperationUtilities,
) => {
const { editorID, time, messageID, threadID, removedUserIDs } =
dmOperation;
const threadInfoOptional = utilities.getThreadInfo(threadID);
if (!threadInfoOptional || !threadInfoOptional.thick) {
// We can't perform this operation now. It should be queued for later.
return {
rawMessageInfos: [],
updateInfos: [],
};
}
const threadInfo: ThickRawThreadInfo = threadInfoOptional;
const removeMembersMessage = {
type: messageTypes.REMOVE_MEMBERS,
id: messageID,
threadID,
time,
creatorID: editorID,
removedUserIDs: [...removedUserIDs],
};
const removedUserIDsSet = new Set(removedUserIDs);
const viewerIsRemoved = removedUserIDsSet.has(viewerID);
const updateInfos: Array<ClientUpdateInfo> = [];
if (viewerIsRemoved) {
updateInfos.push({
type: updateTypes.DELETE_THREAD,
id: uuid.v4(),
time,
threadID,
});
} else {
const updatedThreadInfo = {
...threadInfo,
members: threadInfo.members.filter(
member => !removedUserIDsSet.has(member.id),
),
};
updateInfos.push({
type: updateTypes.UPDATE_THREAD,
id: uuid.v4(),
time,
threadInfo: updatedThreadInfo,
});
}
return {
rawMessageInfos: [removeMembersMessage],
updateInfos,
};
},
});
export { removeMembersSpec };
View Options

lib/types/endpoints.js

Loading...
View Options

lib/types/validators/community-validators.js

Loading...
View Options

lib/types/validators/endpoint-validators.js

Loading...