This diff introduces the fetch_community_infos endpoint. Similar to the fetch_primary_invite_links we will call this endpoint whenever we open the community drawer on native or when the window becomes active on web
Depends on D11978
Details
Details
Called this endpoint later in my stack and confirmed that I was getting all the correct community infos
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Similar to the fetch_primary_invite_links we will call this endpoint whenever we open the community drawer on native or when the window becomes active on web
Can you explain to your reviewers why we need to do this?
Comment Actions
Looking at the project I think it's so that if the user goes the community settings cog and selects the Farcaster channel option, they will be able to see the Farcaster channel. Similar pattern to how we do it for invite links
| keyserver/src/responders/community-responders.js | ||
|---|---|---|
| 14 ↗ | (On Diff #40087) | Wouldn't that make more sense to place this validator next to FetchCommunityInfosResponse type definition? |
| 22 ↗ | (On Diff #40087) | Not sure how useful it is to put withHolder in the name - this can easily become outdated by a change in fetchCommunityInfos. |
| keyserver/src/responders/community-responders.js | ||
|---|---|---|
| 14 ↗ | (On Diff #40087) | Thank you! |