Differential D12237

[web] Navigate to invite links instead of add members modal
ClosedPublic
Actions

Authored by inka on May 29 2024, 8:42 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 15, 7:04 AM

	Unknown Object (File)
	Fri, Nov 15, 6:06 AM

	Unknown Object (File)
	Thu, Nov 14, 12:39 PM

	Unknown Object (File)
	Thu, Nov 14, 2:47 AM

	Unknown Object (File)
	Tue, Nov 12, 9:38 AM

	Unknown Object (File)
	Mon, Nov 11, 3:56 AM

	Unknown Object (File)
	Mon, Nov 11, 3:07 AM

	Unknown Object (File)
	Mon, Nov 11, 12:19 AM

Subscribers

Details

Reviewers

tomek
kamil

Commits

rCOMM9b316b99b75a: [web] Navigate to invite links instead of add members modal

Summary

issue: ENG-7793
We don't want users to be able to add users to community roots - invite links should be used instead.

Test Plan

[for non-community-root] Tested that for chats the "Add members" button still navigates to "Add members" modal.
[for community root] Tested that if invite link exists, "Add members" button navigates to "Invite link" modal.
[for community root] Tested that if invite link doesn't exist, but user has permissions to create one, "Add members" button navigates to "Manage invite links" modal.
[for community root] Tested that if invite link doesn't exist and the user doesn't have premissions to creat it, the button is disabled.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.May 29 2024, 8:42 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMay 29 2024, 8:42 AM

inka edited the test plan for this revision. (Show Details)May 29 2024, 8:50 AM

Remove the button for community roots even if the permission is present

Harbormaster completed remote builds in B29284: Diff 40749.May 29 2024, 8:59 AM

Harbormaster completed remote builds in B29285: Diff 40750.May 29 2024, 9:07 AM

inka requested review of this revision.May 29 2024, 9:07 AM

Can you include a video of what this experience looks like?

Since we don't want the users to be able to add users to community roots, we probably want to

Seems like the summary is incomplete

web/modals/threads/members/members-modal.react.js
151–154 ↗	(On Diff #40750)	It is a little confusing to call a hook like this

This revision is now accepted and ready to land.Jun 3 2024, 1:52 AM

The invite link doesn't exist but user can create it
The invite link does exist
The invite link doesn't exist and the user cannot create it

inka attached a referenced file: F1939537: Screen Recording 2024-06-03 at 11.06.37.mov. (Show Details)Jun 3 2024, 2:09 AM

inka edited the summary of this revision. (Show Details)

inka edited the summary of this revision. (Show Details)

inka edited the test plan for this revision. (Show Details)

inka added a child revision: D12284: [native] Navigate to invite links instead of add members modal.Jun 3 2024, 6:56 AM

Address review

inka added a parent revision: D12236: [web] Stop navigating to Add Members modal from community creation.Jun 3 2024, 7:19 AM

Harbormaster completed remote builds in B29376: Diff 40865.Jun 3 2024, 7:34 AM

Thanks for the detailed video, @inka!

inka added a child revision: D12309: [lib][web] Extract logic checking add users permissions.Jun 4 2024, 2:03 AM

inka removed a child revision: D12284: [native] Navigate to invite links instead of add members modal.

Closed by commit rCOMM9b316b99b75a: [web] Navigate to invite links instead of add members modal (authored by inka). · Explain WhyJun 4 2024, 8:31 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM9b316b99b75a: [web] Navigate to invite links instead of add members modal.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

members/

members-modal.react.js

39 lines

Diff 40865

web/modals/threads/members/members-modal.react.js

Loading...