Page MenuHomePhabricator

[native] Stop navigating to Add Members from community creation
ClosedPublic

Authored by inka on Jun 3 2024, 8:01 AM.
Tags
None
Referenced Files
F3498127: D12285.id40924.diff
Thu, Dec 19, 8:52 PM
F3496797: D12285.diff
Thu, Dec 19, 3:07 PM
F3495848: D12285.id40966.diff
Thu, Dec 19, 10:13 AM
F3495847: D12285.id40924.diff
Thu, Dec 19, 10:13 AM
F3495846: D12285.id40871.diff
Thu, Dec 19, 10:13 AM
F3495831: D12285.id.diff
Thu, Dec 19, 10:13 AM
F3495822: D12285.diff
Thu, Dec 19, 10:12 AM
Unknown Object (File)
Tue, Dec 17, 2:25 PM
Subscribers

Diff Detail

Repository
rCOMM Comm
Branch
inka/userStore
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

native/community-creation/community-configuration.react.js
43

We cannot remove props because of react navigation. We do the same in other components, for example AppsDirectory

107

Before, we would navigate to CommunityCreationMembersRouteName, where upon pressing "Add" or "Cancel" (the only two buttons allowing us to leave the screen) navigateToThread would be called. We want to do this right away, since we don't want to allow adding users to community roots

inka requested review of this revision.Jun 3 2024, 8:18 AM
native/community-creation/community-configuration.react.js
30

Is this route used anywhere else, or should it be deleted?

tomek added inline comments.
native/community-creation/community-configuration.react.js
106–107

Is it possible that communityThreadInfo will still be null here? Should we navigate conditionally, only when the thread info is present?

This revision is now accepted and ready to land.Jun 4 2024, 1:09 AM
native/community-creation/community-configuration.react.js
30

We can remove it
D12306

Check if thread info is present