Page MenuHomePhabricator
Differential D12332

[lib] Stop processing user infos from secondary keyservers on keyserverAuthActionTypes
ClosedPublic
Actions

Authored by inka on Jun 6 2024, 6:43 AM.
Tags
None
Referenced Files
F3247951: D12332.id41047.diff
Fri, Nov 15, 7:53 AM
Unknown Object (File)
Thu, Nov 14, 10:51 AM
Unknown Object (File)
Mon, Nov 11, 4:23 AM
Unknown Object (File)
Mon, Nov 11, 3:56 AM
Unknown Object (File)
Sun, Nov 10, 10:01 PM
Unknown Object (File)
Sun, Nov 10, 7:30 PM
Unknown Object (File)
Sun, Nov 10, 5:47 PM
Unknown Object (File)
Sun, Nov 10, 12:34 PM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMM47f523bb4362: [lib] Stop processing user infos from secondary keyservers on…
Summary

issue: ENG-7832

Test Plan

Checked that user infos from auth keyserver are still being persisted on keyserverAuthActionTypes
EDIT: verified that when connecting to a secondary keyserver no errors appear.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Jun 6 2024, 6:43 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJun 6 2024, 6:43 AM
inka added a parent revision: D12331: [lib] Stop processing user infos from secondary keyservers on joinThreadActionTypes and newThreadActionTypes.Jun 6 2024, 6:43 AM
inka added a child revision: D12333: [lib] Stop processing user infos from secondary keyservers on updateUserAvatarActionTypes.Jun 6 2024, 6:49 AM
Harbormaster completed remote builds in B29487: Diff 41046.Jun 6 2024, 6:59 AM
inka requested review of this revision.Jun 6 2024, 6:59 AM
tomek requested changes to this revision.Jun 6 2024, 9:53 AM
tomek added inline comments.
lib/actions/user-actions.js
622–623 ↗(On Diff #41046)

I don't think it is guaranteed that there will always be a response from the authoritative keyserver, e.g. when adding a new keyserver. We probably should add a condition here and extend a test plan to verify a non-auth keyserver auth.

This revision now requires changes to proceed.Jun 6 2024, 9:53 AM
inka updated this revision to Diff 41102.Jun 7 2024, 5:29 AM

Check if response from auth keyserver exists

inka edited the test plan for this revision. (Show Details)Jun 7 2024, 5:29 AM
Harbormaster completed remote builds in B29529: Diff 41102.Jun 7 2024, 5:45 AM
tomek accepted this revision.Jun 7 2024, 6:49 AM
This revision is now accepted and ready to land.Jun 7 2024, 6:49 AM
inka added a child revision: D12352: [lib] Discard keyserver usernames for joinThreadActionTypes and newThreadActionTypes.Jun 20 2024, 3:01 AM
Closed by commit rCOMM47f523bb4362: [lib] Stop processing user infos from secondary keyservers on… (authored by inka). · Explain WhyJun 25 2024, 1:22 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM47f523bb4362: [lib] Stop processing user infos from secondary keyservers on….

Revision Contents
Changeset List

PathSize
lib/
actions/
19 lines
reducers/
5 lines

Diff 41102

View Options

lib/actions/user-actions.js

Loading...
View Options

lib/reducers/user-reducer.js

Loading...