issue: ENG-8365
We want the username to be fetched from identity. This is handled by UserInfosHandler, which checks if there are any user infos with null username
Details
Details
Joined a community, checked that user infos for new users had a null id, and for user the user already knew the username was unchanged.
Checked that after a while the usernames were fetched from identity
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/reducers/user-reducer.js | ||
|---|---|---|
| 204–220 ↗ | (On Diff #41109) | Does Flow not like this? |
Comment Actions
Don't remove commbot username. I didn't do it for all bots, because Object.entries(bots) is mixed, so there is no easy way to get the id. Also commbot is our only bot, so I don't think this is worth spending time on now
| lib/reducers/user-reducer.js | ||
|---|---|---|
| 234–250 ↗ | (On Diff #41686) | We should be able to simplify this to have a const result similar to my original comment by just determining username at the top Also I think the first spread of newUserInfos[id] doesn't need to happen – can't we just assign [id]: newUserInfos[id] directly? |
| 234–250 ↗ | (On Diff #41686) | It's probably not worth submitting a whole new diff for this though |