Paths

Table of Contentst

[lib] Avoid unnecessary state change in user reducer
ClosedPublic
Actions

Authored by inka on Jun 6 2024, 3:30 AM.

Tags

None

Referenced Files

	F3281925: D12328.id41682.diff
	Sat, Nov 16, 10:23 AM

	Unknown Object (File)
	Thu, Nov 14, 10:03 PM

	Unknown Object (File)
	Mon, Nov 11, 1:37 AM

	Unknown Object (File)
	Mon, Nov 11, 12:48 AM

	Unknown Object (File)
	Sun, Nov 10, 10:08 PM

	Unknown Object (File)
	Sun, Nov 10, 11:57 AM

	Unknown Object (File)
	Mon, Nov 4, 3:31 AM

	Unknown Object (File)
	Fri, Oct 25, 4:37 PM

View All 51 Files

Subscribers

ashoat

Details

Reviewers

tomek
kamil

Commits

rCOMMeb402d876283: [lib] Avoid unnecessary state change in user reducer

Summary

We don't want to introdue state change if it didn't really change. This will avoid unneccesaryy rerenders

Test Plan

Tested that if filteredUserIDs.length === 0 the returcer returns unchanged state

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Jun 6 2024, 3:30 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJun 6 2024, 3:30 AM

inka added a parent revision: D12319: [lib] Fetch user avatars for new user ids.Jun 6 2024, 3:30 AM

Harbormaster completed remote builds in B29481: Diff 41034.Jun 6 2024, 3:46 AM

inka requested review of this revision.Jun 6 2024, 3:46 AM

inka added a child revision: D12329: [lib] Dispatch processNewUserIDsActionType.Jun 6 2024, 3:49 AM

tomek accepted this revision.Jun 6 2024, 4:06 AM

This revision is now accepted and ready to land.Jun 6 2024, 4:06 AM

Closed by commit rCOMMeb402d876283: [lib] Avoid unnecessary state change in user reducer (authored by inka). · Explain WhyJun 25 2024, 1:21 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMeb402d876283: [lib] Avoid unnecessary state change in user reducer.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

user-reducer.js

22 lines

Diff 41682

View Options

lib/reducers/user-reducer.js

[lib] Avoid unnecessary state change in user reducerClosedPublicActions