Page MenuHomePhabricator
Feed Advanced Search

Jun 14 2024

kamil published D12438: [terraform] Deploy Identity `0.23-staging` to staging for review.
Jun 14 2024, 2:31 AM
kamil accepted D12418: [lib] Add validator support for 'Unauthenticated' Tunnelbroker message.
Jun 14 2024, 1:44 AM

Jun 13 2024

kamil published D12430: [lib] broadcast updates to all peers after Secondary Device registration success for review.
Jun 13 2024, 9:51 AM
kamil published D12431: [lib] remove initial peer list testing code for review.
Jun 13 2024, 9:51 AM
kamil abandoned D12383: [lib] refresh device lists after restore.

context in ENG-7246

Jun 13 2024, 9:16 AM
kamil added a comment to D12375: [lib] add `IdentityDeviceListUpdated` P2P message type.

Yes, if a device receives IdentityDeviceListUpdated, it must broadcast standardized DeviceListUpdated to all its peers because only the receiving device knows the peer list.

What happens if the devices are offline? Wondering if there will be an issues in the interim period, between when identity has updated the device list, and when the peers will receive the message to update their device lists for that user.

Jun 13 2024, 9:15 AM
kamil closed D12381: [lib] broadcast device list updates after secondary device logout.
Jun 13 2024, 9:08 AM
kamil closed D12380: [lib] broadcast updates when becoming aware of new device existence.
Jun 13 2024, 9:08 AM
kamil committed rCOMMc3d2084fa2df: [lib] broadcast device list updates after secondary device logout (authored by kamil).
[lib] broadcast device list updates after secondary device logout
Jun 13 2024, 9:08 AM
kamil closed D12379: [lib] handle `DEVICE_LIST_UPDATED` message.
Jun 13 2024, 9:08 AM
kamil committed rCOMM2166940eeed7: [lib] handle `DEVICE_LIST_UPDATED` message (authored by kamil).
[lib] handle `DEVICE_LIST_UPDATED` message
Jun 13 2024, 9:08 AM
kamil closed D12378: [Identity] send `IdentityDeviceListUpdated` after logout.
Jun 13 2024, 9:08 AM
kamil committed rCOMM5eb95eea7756: [lib] broadcast updates when becoming aware of new device existence (authored by kamil).
[lib] broadcast updates when becoming aware of new device existence
Jun 13 2024, 9:08 AM
kamil closed D12377: [Identity] implement sending `IdentityDeviceListUpdated` using Tunnelbroker client.
Jun 13 2024, 9:08 AM
kamil closed D12376: [lib] handle `IdentityDeviceListUpdated` P2P message.
Jun 13 2024, 9:08 AM
kamil closed D12375: [lib] add `IdentityDeviceListUpdated` P2P message type.
Jun 13 2024, 9:08 AM
kamil committed rCOMM6042b671aad3: [Identity] send `IdentityDeviceListUpdated` after logout (authored by kamil).
[Identity] send `IdentityDeviceListUpdated` after logout
Jun 13 2024, 9:08 AM
kamil committed rCOMM6488eee28c83: [lib] add `IdentityDeviceListUpdated` P2P message type (authored by kamil).
[lib] add `IdentityDeviceListUpdated` P2P message type
Jun 13 2024, 9:08 AM
kamil committed rCOMMa3d5a4e16790: [Identity] implement sending `IdentityDeviceListUpdated` using Tunnelbroker… (authored by kamil).
[Identity] implement sending `IdentityDeviceListUpdated` using Tunnelbroker…
Jun 13 2024, 9:08 AM
kamil committed rCOMMafda4a8565f3: [lib] handle `IdentityDeviceListUpdated` P2P message (authored by kamil).
[lib] handle `IdentityDeviceListUpdated` P2P message
Jun 13 2024, 9:08 AM
kamil closed D12373: [lib] factor out broadcasting device list updates to hook.
Jun 13 2024, 9:08 AM
kamil closed D12372: [lib] convert `peerToPeerMessageHandler` to a hook.
Jun 13 2024, 9:08 AM
kamil closed D12374: [lib] factor out getting and updating device list to hook.
Jun 13 2024, 9:08 AM
kamil committed rCOMMb1a04e641028: [lib] factor out broadcasting device list updates to hook (authored by kamil).
[lib] factor out broadcasting device list updates to hook
Jun 13 2024, 9:08 AM
kamil committed rCOMMbe2d7d3dfc7c: [lib] factor out getting and updating device list to hook (authored by kamil).
[lib] factor out getting and updating device list to hook
Jun 13 2024, 9:08 AM
kamil committed rCOMM82d5ff08dc09: [lib] convert `peerToPeerMessageHandler` to a hook (authored by kamil).
[lib] convert `peerToPeerMessageHandler` to a hook
Jun 13 2024, 9:08 AM
kamil closed D12371: [lib] move processing `MESSAGE_TO_DEVICE` to a component.
Jun 13 2024, 9:08 AM
kamil closed D12347: [lib] make `signedDeviceList` in `DEVICE_LIST_UPDATED` message optional.
Jun 13 2024, 9:08 AM
kamil committed rCOMM36192d5aac81: [lib] make `signedDeviceList` in `DEVICE_LIST_UPDATED` message optional (authored by kamil).
[lib] make `signedDeviceList` in `DEVICE_LIST_UPDATED` message optional
Jun 13 2024, 9:08 AM
kamil committed rCOMMc5dc4cd1873a: [lib] move processing `MESSAGE_TO_DEVICE` to a component (authored by kamil).
[lib] move processing `MESSAGE_TO_DEVICE` to a component
Jun 13 2024, 9:08 AM
kamil closed D12330: [lib] update device list when updating `UserStore`.
Jun 13 2024, 9:08 AM
kamil committed rCOMM2ccc924b7ea1: [lib] update device list when updating `UserStore` (authored by kamil).
[lib] update device list when updating `UserStore`
Jun 13 2024, 9:08 AM
kamil updated the diff for D12378: [Identity] send `IdentityDeviceListUpdated` after logout.

address review

Jun 13 2024, 8:40 AM
kamil added a comment to D12377: [Identity] implement sending `IdentityDeviceListUpdated` using Tunnelbroker client.

Might be worth refactoring this function to take array of device IDs &[&str] and send messages in a for loop, to avoid creating tunnelbroker_client for each device when called this in a loop

Jun 13 2024, 8:39 AM
kamil updated the diff for D12377: [Identity] implement sending `IdentityDeviceListUpdated` using Tunnelbroker client.

refactor to use array od device IDs

Jun 13 2024, 8:39 AM
kamil updated the diff for D12380: [lib] broadcast updates when becoming aware of new device existence.

ownDeviceID -> thisDeviceID

Jun 13 2024, 8:17 AM
kamil added inline comments to D12376: [lib] handle `IdentityDeviceListUpdated` P2P message.
Jun 13 2024, 8:03 AM
kamil updated the diff for D12376: [lib] handle `IdentityDeviceListUpdated` P2P message.
  • add comment
  • remove obsolete condition
Jun 13 2024, 8:02 AM
kamil added inline comments to D12373: [lib] factor out broadcasting device list updates to hook.
Jun 13 2024, 7:54 AM
kamil added inline comments to D12347: [lib] make `signedDeviceList` in `DEVICE_LIST_UPDATED` message optional.
Jun 13 2024, 7:47 AM
kamil updated the diff for D12372: [lib] convert `peerToPeerMessageHandler` to a hook.

rebase

Jun 13 2024, 7:46 AM
kamil updated the diff for D12371: [lib] move processing `MESSAGE_TO_DEVICE` to a component.

ifSocketExists -> doesSocketExist

Jun 13 2024, 7:43 AM
kamil closed D12419: [terraform] Deploy Tunnelbroker 0.8 to prod.
Jun 13 2024, 5:49 AM
kamil committed rCOMM67396db62eb7: [terraform] Deploy Tunnelbroker 0.8 to prod (authored by kamil).
[terraform] Deploy Tunnelbroker 0.8 to prod
Jun 13 2024, 5:48 AM
kamil updated the summary of D12419: [terraform] Deploy Tunnelbroker 0.8 to prod.
Jun 13 2024, 4:18 AM
kamil published D12419: [terraform] Deploy Tunnelbroker 0.8 to prod for review.
Jun 13 2024, 4:15 AM
kamil added inline comments to D12379: [lib] handle `DEVICE_LIST_UPDATED` message.
Jun 13 2024, 1:45 AM
kamil added a comment to D12375: [lib] add `IdentityDeviceListUpdated` P2P message type.

In this case we also want the receiving device to re-send this to all other peers.

Some questions:

  1. When you say re-send, do you mean that the receiving device will send the same message type (IdentityDeviceListUpdated) to peers? Or a different message type? (I assume different, since you indicated this message is always sent directly by Identity.)
Jun 13 2024, 1:38 AM

Jun 11 2024

kamil accepted D12387: [keyserver] Improve logging in checkInputValidator.
Jun 11 2024, 4:27 AM
kamil accepted D12389: [keyserver] Make sure to reset session when lastUpdate is 0.
Jun 11 2024, 4:16 AM
kamil accepted D12388: [lib] Set new session if received from fetch_pending_updates.
Jun 11 2024, 4:14 AM
kamil accepted D12386: [native] Deprecate socket crash loop recovery specialized to policy acknowledgment.
Jun 11 2024, 2:28 AM

Jun 10 2024

kamil accepted D12345: [commtest] Restructure code into olm_account module.
Jun 10 2024, 10:15 AM
kamil accepted D12344: [commtest] Rename SigningCapableAccount to MockOlmAccount.
Jun 10 2024, 10:14 AM
kamil accepted D12343: [commtest] Get rid of hardcoded ClientPublicKeys values.

Nice to see that 👏

Jun 10 2024, 10:14 AM
kamil accepted D12342: [commtest] Make ClientPublicKeys::device_id() return str slice.
Jun 10 2024, 10:13 AM
kamil accepted D12341: [commtest] Generate random client keys by default.
Jun 10 2024, 10:12 AM
kamil accepted D12340: [commtest] Add default impl for ClientPublicKeys.
Jun 10 2024, 10:11 AM
kamil accepted D12346: [commtest] Fix flaky identity-tunnelbroker test.
Jun 10 2024, 10:11 AM
kamil added inline comments to D12369: [lib][native][web] Recover from socket crash loop using fetchPendingUpdates.
Jun 10 2024, 10:05 AM
kamil accepted D12364: [keyserver][lib] Introduce fetch_pending_updates endpoint.
Jun 10 2024, 10:01 AM
kamil published D12383: [lib] refresh device lists after restore for review.
Jun 10 2024, 9:53 AM
kamil published D12381: [lib] broadcast device list updates after secondary device logout for review.
Jun 10 2024, 9:52 AM
kamil published D12380: [lib] broadcast updates when becoming aware of new device existence for review.
Jun 10 2024, 9:52 AM
kamil published D12379: [lib] handle `DEVICE_LIST_UPDATED` message for review.
Jun 10 2024, 9:52 AM
kamil published D12378: [Identity] send `IdentityDeviceListUpdated` after logout for review.
Jun 10 2024, 9:52 AM
kamil published D12377: [Identity] implement sending `IdentityDeviceListUpdated` using Tunnelbroker client for review.
Jun 10 2024, 9:51 AM
kamil published D12376: [lib] handle `IdentityDeviceListUpdated` P2P message for review.
Jun 10 2024, 9:51 AM
kamil published D12374: [lib] factor out getting and updating device list to hook for review.
Jun 10 2024, 9:51 AM
kamil published D12373: [lib] factor out broadcasting device list updates to hook for review.
Jun 10 2024, 9:50 AM
kamil published D12375: [lib] add `IdentityDeviceListUpdated` P2P message type for review.
Jun 10 2024, 9:50 AM
kamil published D12372: [lib] convert `peerToPeerMessageHandler` to a hook for review.
Jun 10 2024, 9:50 AM
kamil published D12371: [lib] move processing `MESSAGE_TO_DEVICE` to a component for review.
Jun 10 2024, 9:50 AM

Jun 7 2024

kamil published D12347: [lib] make `signedDeviceList` in `DEVICE_LIST_UPDATED` message optional for review.
Jun 7 2024, 2:39 AM
kamil added inline comments to D12330: [lib] update device list when updating `UserStore`.
Jun 7 2024, 2:13 AM
kamil updated the diff for D12330: [lib] update device list when updating `UserStore`.
  • rebase
  • shorthand
Jun 7 2024, 2:10 AM

Jun 6 2024

kamil published D12330: [lib] update device list when updating `UserStore` for review.
Jun 6 2024, 4:27 AM
kamil accepted D12224: [lib] Send logout message to primary device in useSecondaryDeviceLogOut.
Jun 6 2024, 1:26 AM
kamil accepted D12307: Add identity platform details to aux user store.
Jun 6 2024, 1:23 AM
kamil accepted D12267: [identity] Remove device data on device list update.
Jun 6 2024, 1:01 AM
kamil accepted D12225: [lib][p2p] Update device list upon receiving logout message.
Jun 6 2024, 12:55 AM
kamil added inline comments to D12224: [lib] Send logout message to primary device in useSecondaryDeviceLogOut.
Jun 6 2024, 12:55 AM
kamil accepted D12223: [web] Add dev-only button to log out secondary device.
Jun 6 2024, 12:35 AM
kamil accepted D12222: [native] Add dev-only button to log out secondary device.
Jun 6 2024, 12:30 AM

Jun 3 2024

kamil closed D12132: [lib] introduce context to process Outbound P2P Messages.
Jun 3 2024, 6:16 AM
kamil committed rCOMM9bddabfeadd5: [lib] introduce context to process Outbound P2P Messages (authored by kamil).
[lib] introduce context to process Outbound P2P Messages
Jun 3 2024, 6:16 AM
kamil added inline comments to D12132: [lib] introduce context to process Outbound P2P Messages.
Jun 3 2024, 5:53 AM
kamil updated the diff for D12132: [lib] introduce context to process Outbound P2P Messages.
  • address review
  • rebase before landing
Jun 3 2024, 5:53 AM
kamil accepted D12240: [lib] Add unit tests for functions modifying device list.

nice 👏

Jun 3 2024, 4:51 AM
kamil accepted D12239: [lib] Add function to remove device from device list.
Jun 3 2024, 4:40 AM
kamil accepted D12238: [lib][native] Move device list ops to lib.
Jun 3 2024, 4:35 AM
kamil closed D12203: [web] update `olm` API to allow creating session without OTKs.
Jun 3 2024, 3:23 AM
kamil closed D12204: [lib] update types to allow missing OTK when creating session.
Jun 3 2024, 3:23 AM
kamil closed D12202: [native] update `olm` API to allow creating session without OTKs.
Jun 3 2024, 3:23 AM
kamil committed rCOMM4fa54458b461: [web] update `olm` API to allow creating session without OTKs (authored by kamil).
[web] update `olm` API to allow creating session without OTKs
Jun 3 2024, 3:23 AM
kamil committed rCOMM9b33c8f7a408: [lib] update types to allow missing OTK when creating session (authored by kamil).
[lib] update types to allow missing OTK when creating session
Jun 3 2024, 3:23 AM
kamil committed rCOMM84ed5f6bbfd4: [native] update `olm` API to allow creating session without OTKs (authored by kamil).
[native] update `olm` API to allow creating session without OTKs
Jun 3 2024, 3:23 AM
kamil closed D12201: [keyserver] add tests to creating `olm` session without OTKs.
Jun 3 2024, 3:23 AM
kamil committed rCOMM214a421a762c: [keyserver] add tests to creating `olm` session without OTKs (authored by kamil).
[keyserver] add tests to creating `olm` session without OTKs
Jun 3 2024, 3:23 AM
kamil closed D12200: [olm] bump `@commapp/olm` version.
Jun 3 2024, 3:23 AM