Requesting changes for a migration that takes no params and just recalculates all thread permissions from "first principles" based on role-creator.js that is extracted to lib

(Talked through that offline with @atul and we agreed the "dangling" stuff would be fine)

proto comment change looks fine; no context on the Rust

High-level feedback here is that all numbers that contribute to the height of the component should be hard-coded as constants, and then the functions for determining the height of the component should simply sum those very same constants. This includes margin, padding, etc.

Keep LoggedOutStaffInfo margins the same as before

Fix types

Can you add genesis to the reserved list? Context here

The Android build was consistently failing here… any cause for concern?

Can we replace the ALERT_TITLES with "Alert title", to make them more human-readable?

Okay, good points – that makes sense

Wouldn't it be more simple / readable to handle this at the callsite for selectFromGalleryAndUpdateUserAvatar? Eg. like this:

@rohan, can you provide some clarification as to why you've been iterating on this stack for so long without resolving the unit test issue? Is it particularly challenging?

Just one serious issue

Thanks for the explanation in the diff description

Please address inline comments before landing! If you're unable to switch back to $ReadOnlyArray, please re-request review and I'll take a look

Looks like a clean "factor out", so not reviewing super closely

This looks good, but I want to make sure the types are okay before you land, so requesting changes so I can have a final pass-through before you land

Please address inline comment before landing

We should source this height from the same place that we source it for message height calculations. Eg. see how timestampHeight is used. Please replace this with a variable that is also used somehow in messageItemHeight

Assuming this is a clean refactor so only skimmed it

Clean up, fix styles, remove KeyboardAvoidingView.

Realized we need a separate StackNavigator for registration

Add React keys

New libraries look good!! Resigning so that somebody else on the team looks at the Rust code

Use INNER JOIN instead of LEFT JOIN. I tested the query again to make sure it still works

1. You forgot to annotate the parent of this diff. This has come up before... please always try to annotate your diff dependencies. It would probably be easier for you if you keep a 1-to-1 correspondence between branches and diff stacks, but if you want to do things differently, it's fine as long as you are able to remember to annotate your diff dependencies going forward.
2. Accepting due to the state of this work, but normally I would request changes here. Please read through all of the comments carefully and address them before landing
   • If you disagree with the comment about returning a Promise and awaiting it, please re-request review

Is this ready for review given it's failing CI?

Looks good, just have some concerns about naming and comments

I really, really do not like that this function is getting introduced without a callsite.