Page MenuHomePhabricator

[web] introduce subheader prop to modal component
ClosedPublic

Authored by ginsu on Dec 7 2023, 11:49 AM.
Tags
None
Referenced Files
F3498133: D10234.diff
Thu, Dec 19, 8:55 PM
Unknown Object (File)
Thu, Dec 12, 1:59 PM
Unknown Object (File)
Wed, Dec 11, 12:32 PM
Unknown Object (File)
Tue, Dec 10, 6:10 PM
Unknown Object (File)
Mon, Dec 9, 6:24 PM
Unknown Object (File)
Mon, Dec 9, 10:48 AM
Unknown Object (File)
Thu, Nov 21, 5:03 AM
Unknown Object (File)
Nov 12 2024, 3:53 PM
Subscribers

Details

Summary

This diff introduces a subheader prop to the modal component. Sometimes we want to render an element in between the header and the modal children content, but we want this element to not follow the spacing rules for the modal children. These elements can be things like banners, tabs, etc. For example:

Screenshot 2023-12-07 at 2.47.47 PM.png (1×3 px, 802 KB)

The subheader prop will extend the entire width of the modal, perfect for elements like banners + tabs.

Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs

Depends on D10232

Test Plan

Here is an example of using the subheader prop with the community creation modal

Screenshot 2023-12-07 at 2.53.26 PM.png (1×3 px, 802 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 7 2023, 1:04 PM
Harbormaster failed remote builds in B24866: Diff 34390!
ginsu requested review of this revision.Dec 7 2023, 2:03 PM

will make sure that ci passes before landing

This revision is now accepted and ready to land.Dec 8 2023, 9:43 AM
This revision was landed with ongoing or failed builds.Feb 15 2024, 12:10 AM
This revision was automatically updated to reflect the committed changes.