Page MenuHomePhorge
Feed Search

May 29 2023

kamil closed D7921: [lib] refactor types to allow returning report store operations.
May 29 2023, 11:18 AM
kamil committed rCOMM281a00b7b442: [lib] add report store ops on JS side.
May 29 2023, 11:18 AM
kamil committed rCOMM409049567986: [lib] refactor types to allow returning report store operations.
May 29 2023, 11:18 AM
kamil closed D7919: [lib] add tests for report reducer.
May 29 2023, 11:18 AM
kamil committed rCOMMdf9755520d23: [lib] add tests for report reducer.
May 29 2023, 11:18 AM
kamil added inline comments to D7933: [lib] refactor handling new inconsistencies in report store reducer for using operations.
May 29 2023, 10:50 AM
kamil updated the diff for D7933: [lib] refactor handling new inconsistencies in report store reducer for using operations.

rebase

May 29 2023, 10:50 AM
kamil updated the diff for D7932: [lib] refactor adding reports action for using operations.

rebase

May 29 2023, 10:49 AM
kamil added inline comments to D7931: [lib] refactor sending reports actions for using operations.
May 29 2023, 10:48 AM
kamil updated the diff for D7931: [lib] refactor sending reports actions for using operations.

rebase

May 29 2023, 10:48 AM
kamil updated the diff for D7923: [lib] refactor updating enabled reports for using operations.

rebase

May 29 2023, 10:46 AM
kamil added inline comments to D7922: [lib] add operation for removing all reports on login/logout.
May 29 2023, 10:44 AM
kamil updated the diff for D7922: [lib] add operation for removing all reports on login/logout.

rebase

May 29 2023, 10:44 AM
kamil updated the diff for D7921: [lib] refactor types to allow returning report store operations.

rebase

May 29 2023, 10:43 AM
kamil added inline comments to D7920: [lib] add report store ops on JS side.
May 29 2023, 10:42 AM
kamil updated the diff for D7920: [lib] add report store ops on JS side.

make field read-only

May 29 2023, 10:42 AM
kamil updated the diff for D7919: [lib] add tests for report reducer.

rebase

May 29 2023, 10:41 AM
kamil closed D7916: [lib] make report id mandatory.
May 29 2023, 10:07 AM
kamil closed D7913: [lib] assign local id to report while creating.
May 29 2023, 10:07 AM
kamil committed rCOMMf3294e9053c4: [lib] assign local id to report while creating.
May 29 2023, 10:07 AM
kamil committed rCOMMc26472a54487: [lib] make report id mandatory.
May 29 2023, 10:07 AM
kamil closed D7912: [lib] add local id field to existing reports.
May 29 2023, 10:07 AM
kamil closed D7910: [lib] extract local id field before sending report.
May 29 2023, 10:07 AM
kamil committed rCOMM2a202a6053d1: [lib] extract local id field before sending report.
May 29 2023, 10:07 AM
kamil committed rCOMM714c8bfce7c0: [lib] add local id field to existing reports.
May 29 2023, 10:07 AM
kamil closed D7909: [lib] add local is field to reports.
May 29 2023, 10:07 AM
kamil committed rCOMM1fd195c04737: [lib] add local is field to reports.
May 29 2023, 10:07 AM
kamil updated the diff for D7916: [lib] make report id mandatory.

rebase

May 29 2023, 9:42 AM
kamil updated the diff for D7913: [lib] assign local id to report while creating.

add intermediate function

May 29 2023, 9:41 AM
kamil added inline comments to D7912: [lib] add local id field to existing reports.
May 29 2023, 9:40 AM
kamil updated the diff for D7912: [lib] add local id field to existing reports.

move code directly to migration

May 29 2023, 9:39 AM
kamil updated the diff for D7910: [lib] extract local id field before sending report.

fix committed code

May 29 2023, 9:15 AM
kamil updated the diff for D7910: [lib] extract local id field before sending report.

move code directly to migration

May 29 2023, 8:54 AM
kamil added inline comments to D7910: [lib] extract local id field before sending report.
May 29 2023, 8:46 AM
kamil updated the diff for D7910: [lib] extract local id field before sending report.

rename variable

May 29 2023, 8:46 AM
kamil added inline comments to D7909: [lib] add local is field to reports.
May 29 2023, 8:46 AM
kamil updated the diff for D7909: [lib] add local is field to reports.

rebase

May 29 2023, 8:40 AM

May 25 2023

kamil published D7986: [web-db] dispatch reports from SQLite to store for review.
May 25 2023, 8:49 PM
kamil published D7985: [web-db] start processing report store operations for review.
May 25 2023, 8:48 PM
kamil published D7984: [web-db] add report table on web for review.
May 25 2023, 8:47 PM
kamil published D7983: [web-db] implement SQL queries for report store for review.
May 25 2023, 8:46 PM
kamil published D7982: [web-db] add migration logic to SQLite on web for review.
May 25 2023, 8:45 PM
kamil published D7977: [native] migrate reports to SQLite for review.
May 25 2023, 3:26 PM
kamil published D7975: [CommCoreModule] implement synchronous report store operations for review.
May 25 2023, 3:00 PM
kamil added inline comments to D7948: [keyserver] Handle web invite links on keyserver.
May 25 2023, 12:07 PM
kamil accepted D7948: [keyserver] Handle web invite links on keyserver.
May 25 2023, 12:05 PM
kamil accepted D7908: [native] Introduce disable link button.
May 25 2023, 11:33 AM
kamil requested review of D7931: [lib] refactor sending reports actions for using operations.
May 25 2023, 10:03 AM
kamil requested review of D7753: [lib] introduce function to find deep difference between two objects.

Looking for:

  1. Longer description of Flow's issues here
May 25 2023, 9:20 AM

May 23 2023

kamil published D7939: [native] stop persisting reports for review.
May 23 2023, 11:56 PM
kamil published D7938: [native] fetch reports from SQLite and dispatch to store for review.
May 23 2023, 11:55 PM
kamil published D7937: [native] start processing report store operations on database for review.
May 23 2023, 11:55 PM
kamil published D7936: [CommCoreModule] implement getting report store from database for review.
May 23 2023, 11:55 PM
kamil updated the diff for D7934: [CommCoreModule] implement report store operations.

fix import

May 23 2023, 11:30 PM
kamil published D7934: [CommCoreModule] implement report store operations for review.
May 23 2023, 11:24 PM
kamil published D7918: [CommCoreModule] add table and methods for report store for review.
May 23 2023, 11:22 PM
kamil accepted D7906: [keyserver] Create an endpoint that allows disabling links.
May 23 2023, 11:21 PM
kamil accepted D7878: [keyserver] Create an endpoint that can be used to create or update a public link.
May 23 2023, 11:14 PM
kamil accepted D7877: [lib] Create a store in redux for the invite links.
May 23 2023, 11:08 PM
kamil accepted D7730: [native] Create a modal where invite links are displayed.

Looks good, but would love to see an opinion from someone more experienced in @react-navigation (cc. @inka)

May 23 2023, 12:23 PM
kamil published D7933: [lib] refactor handling new inconsistencies in report store reducer for using operations for review.
May 23 2023, 8:58 AM
kamil published D7932: [lib] refactor adding reports action for using operations for review.
May 23 2023, 8:58 AM
kamil published D7931: [lib] refactor sending reports actions for using operations for review.
May 23 2023, 8:56 AM
kamil published D7923: [lib] refactor updating enabled reports for using operations for review.
May 23 2023, 8:54 AM
kamil published D7922: [lib] add operation for removing all reports on login/logout for review.
May 23 2023, 8:52 AM
kamil published D7921: [lib] refactor types to allow returning report store operations for review.
May 23 2023, 8:51 AM
kamil published D7920: [lib] add report store ops on JS side for review.
May 23 2023, 8:49 AM
kamil published D7919: [lib] add tests for report reducer for review.
May 23 2023, 8:46 AM
kamil published D7916: [lib] make report id mandatory for review.
May 23 2023, 8:41 AM
kamil published D7913: [lib] assign local id to report while creating for review.
May 23 2023, 8:40 AM
kamil published D7912: [lib] add local id field to existing reports for review.
May 23 2023, 8:37 AM
kamil published D7910: [lib] extract local id field before sending report for review.
May 23 2023, 8:36 AM
kamil published D7909: [lib] add local is field to reports for review.
May 23 2023, 8:35 AM

May 22 2023

kamil accepted D7907: [lib] Allow calling link-disabling endpoint.

I think the differential name is not complete and confusing a bit

May 22 2023, 5:44 PM
kamil requested changes to D7906: [keyserver] Create an endpoint that allows disabling links.
May 22 2023, 5:24 PM
kamil accepted D7885: [native] Add a link to manage public link screen.

Can you share a screenshot of how this looks like?

May 22 2023, 4:52 PM
kamil accepted D7884: [native] Introduce simple error handling.
May 22 2023, 4:42 PM
kamil accepted D7883: [native] Call create / update endpoint.
May 22 2023, 4:25 PM
kamil accepted D7881: [native] Show actions conditionally.
May 22 2023, 3:32 PM
kamil accepted D7880: [native] Implement the UI of manage invite links screen.
May 22 2023, 3:13 PM
kamil accepted D7733: [native] Display a button and navigate to invite links if they are present.
May 22 2023, 2:54 PM
kamil accepted D7879: [lib] Add client side boilerplate and reducer for an endpoint that allows creating or updating public links.
May 22 2023, 9:42 AM
kamil requested changes to D7878: [keyserver] Create an endpoint that can be used to create or update a public link.
May 22 2023, 9:36 AM
kamil requested changes to D7877: [lib] Create a store in redux for the invite links.
May 22 2023, 8:34 AM
kamil accepted D7876: [lib] Update invite link type.
May 22 2023, 7:56 AM

May 17 2023

kamil accepted D7772: [natvie] Add SearchFooter component.
May 17 2023, 10:49 AM
kamil accepted D7777: [native] Add search button to chat header.
May 17 2023, 10:43 AM
kamil accepted D7733: [native] Display a button and navigate to invite links if they are present.
May 17 2023, 10:35 AM

May 16 2023

kamil closed D7842: [lib] fix pinned content for non-media messages.
May 16 2023, 7:48 PM
kamil committed rCOMM7b3dc8969c6d: [lib] fix pinned content for non-media messages.
May 16 2023, 7:48 PM
kamil added inline comments to D7842: [lib] fix pinned content for non-media messages.
May 16 2023, 7:47 PM
kamil published D7842: [lib] fix pinned content for non-media messages for review.
May 16 2023, 3:08 PM

May 15 2023

kamil accepted D7762: [lib] Introduce a new permission for managing invite links.
May 15 2023, 9:31 AM
kamil accepted D7760: [native] Add base64 decode to CommUtilsModule.

Could you make sure in Test Plan that you tested decoding strings with each length of padding at the end (none, =, and ==)?

May 15 2023, 9:21 AM
kamil accepted D7758: [native] Add C++ function to decode base64.

Looks good, I am a bit afraid there are too many similarities between this and source code from the article, but you said it's based on the article so assuming it was only an inspiration.

May 15 2023, 9:13 AM

May 11 2023

kamil closed D7668: [web-db] migrate entire redux-persist storage to SQLite.
May 11 2023, 11:03 AM
kamil closed D7667: [web-db] choose storage engine depending on whether database is supported or not.
May 11 2023, 11:03 AM
kamil committed rCOMM62792ee53c56: [web-db] migrate entire redux-persist storage to SQLite.
May 11 2023, 11:03 AM
kamil committed rCOMMfd0203f1c83a: [web-db] choose storage engine depending on whether database is supported or not.
May 11 2023, 11:03 AM
kamil closed D7666: [web-db] stop persisting drafts in redux-persist.
May 11 2023, 11:03 AM