Page MenuHomePhabricator
Feed All Stories

May 24 2023

michal accepted D7837: [web] Added FocusTrap for modals.
May 24 2023, 2:47 AM
tomek accepted D7923: [lib] refactor updating enabled reports for using operations.
May 24 2023, 2:40 AM
kuba added 1 blocking reviewer(s) for D7837: [web] Added FocusTrap for modals: michal.
May 24 2023, 2:39 AM
marcin updated the diff for D7872: Implement function to encrypt android notification.
  1. Make AndroidNotification type read-only
  2. Change order of assignments to increase readability
May 24 2023, 2:37 AM
marcin added inline comments to D7872: Implement function to encrypt android notification.
May 24 2023, 2:34 AM
kuba updated the diff for D7930: [web] Changed edit modal overlay opacity.

Shorthand

May 24 2023, 2:32 AM
tomek added inline comments to D7873: Implement notification decryption in CommNotificationsHandler.
May 24 2023, 2:13 AM
InkaSokolowska closed D7935: Remove ListLoadingIndicator background color.
May 24 2023, 2:13 AM
InkaSokolowska closed D7942: [native] Fix reply not working in search results.
May 24 2023, 2:13 AM
InkaSokolowska committed rCOMM17429961fb94: [native] Fix reply not working in search results (authored by InkaSokolowska).
[native] Fix reply not working in search results
May 24 2023, 2:12 AM
InkaSokolowska committed rCOMM8f290452db45: Remove ListLoadingIndicator background color (authored by InkaSokolowska).
Remove ListLoadingIndicator background color
May 24 2023, 2:12 AM
InkaSokolowska closed D7777: [native] Add search button to chat header.
May 24 2023, 2:12 AM
InkaSokolowska closed D7774: [native] Add MessageSearchContent.
May 24 2023, 2:12 AM
InkaSokolowska committed rCOMMa347177eb2b5: [native] Add search button to chat header (authored by InkaSokolowska).
[native] Add search button to chat header
May 24 2023, 2:12 AM
InkaSokolowska closed D7773: [native] Add message search screen.
May 24 2023, 2:12 AM
InkaSokolowska committed rCOMM4b9285c9f6a5: [native] Add MessageSearchContent (authored by InkaSokolowska).
[native] Add MessageSearchContent
May 24 2023, 2:12 AM
InkaSokolowska committed rCOMM291efc1dd80f: [native] Add message search screen (authored by InkaSokolowska).
[native] Add message search screen
May 24 2023, 2:12 AM
InkaSokolowska closed D7772: [natvie] Add SearchFooter component.
May 24 2023, 2:12 AM
InkaSokolowska closed D7771: [lib] Add useSearchMessages.
May 24 2023, 2:12 AM
InkaSokolowska closed D7770: [native] Extract function for modyfing items to be displayed in MessageResult.
May 24 2023, 2:12 AM
InkaSokolowska committed rCOMM99ecfe2b6ea5: [natvie] Add SearchFooter component (authored by InkaSokolowska).
[natvie] Add SearchFooter component
May 24 2023, 2:12 AM
InkaSokolowska committed rCOMMe7c05100d749: [lib] Add useSearchMessages (authored by InkaSokolowska).
[lib] Add useSearchMessages
May 24 2023, 2:12 AM
InkaSokolowska committed rCOMM2edefa3ae2f6: [native] Extract function for modyfing items to be displayed in MessageResult (authored by InkaSokolowska).
[native] Extract function for modyfing items to be displayed in MessageResult
May 24 2023, 2:12 AM
InkaSokolowska closed D7739: [native] Add message search context.
May 24 2023, 2:12 AM
InkaSokolowska closed D7740: [native] Add a header componnent with a search bar.
May 24 2023, 2:12 AM
InkaSokolowska committed rCOMM1d14e082facb: [native] Add message search context (authored by InkaSokolowska).
[native] Add message search context
May 24 2023, 2:12 AM
InkaSokolowska committed rCOMM51ce1fc711c8: [native] Add a header componnent with a search bar (authored by InkaSokolowska).
[native] Add a header componnent with a search bar
May 24 2023, 2:12 AM
InkaSokolowska closed D7652: [lib] Allow calling message search from client.
May 24 2023, 2:12 AM
InkaSokolowska closed D7651: [keyserver, lib] Add message search endpoint.
May 24 2023, 2:12 AM
InkaSokolowska committed rCOMMed08ed3c47d3: [lib] Allow calling message search from client (authored by InkaSokolowska).
[lib] Allow calling message search from client
May 24 2023, 2:12 AM
InkaSokolowska committed rCOMM7e7050dee8ae: [keyserver, lib] Add message search endpoint (authored by InkaSokolowska).
[keyserver, lib] Add message search endpoint
May 24 2023, 2:12 AM
InkaSokolowska closed D7585: [keyserver] Add function for fetching messages matching search query.
May 24 2023, 2:12 AM
InkaSokolowska committed rCOMM5834356687a4: [keyserver] Add function for fetching messages matching search query (authored by InkaSokolowska).
[keyserver] Add function for fetching messages matching search query
May 24 2023, 2:12 AM
tomek accepted D7922: [lib] add operation for removing all reports on login/logout.
May 24 2023, 2:10 AM
marcin requested review of D7873: Implement notification decryption in CommNotificationsHandler.
May 24 2023, 2:10 AM
tomek accepted D7921: [lib] refactor types to allow returning report store operations.
May 24 2023, 2:09 AM
tomek accepted D7920: [lib] add report store ops on JS side.
May 24 2023, 2:06 AM
tomek accepted D7919: [lib] add tests for report reducer.
May 24 2023, 2:03 AM
tomek accepted D7936: [CommCoreModule] implement getting report store from database.
May 24 2023, 2:01 AM
tomek accepted D7934: [CommCoreModule] implement report store operations.
May 24 2023, 1:54 AM
tomek accepted D7918: [CommCoreModule] add table and methods for report store.
May 24 2023, 1:49 AM
tomek requested changes to D7873: Implement notification decryption in CommNotificationsHandler.
May 24 2023, 1:46 AM
inka updated the diff for D7773: [native] Add message search screen.

Rebase

May 24 2023, 1:42 AM
inka updated the diff for D7772: [natvie] Add SearchFooter component.

Make props read only

May 24 2023, 1:41 AM
inka updated the diff for D7652: [lib] Allow calling message search from client.

Rebase

May 24 2023, 1:39 AM
inka updated the diff for D7942: [native] Fix reply not working in search results.

Address review

May 24 2023, 1:30 AM
bartek added a comment to D7799: [Tunnelbroker] Initial message persistence.

Looks good to me but I'd also let @varun take a look

May 24 2023, 1:14 AM
tomek added inline comments to D7877: [lib] Create a store in redux for the invite links.
May 24 2023, 1:07 AM
tomek added a comment to D7730: [native] Create a modal where invite links are displayed.

As @ted is off for now, I don't think it makes sense to block this diff on this change.

Can you create a DES task and assign it to Ted, to make sure we follow up after he is back?

May 24 2023, 12:57 AM
bartek added inline comments to D7900: [web] Add thumbhash to encrypted media, fix spinner.
May 24 2023, 12:37 AM
bartek added inline comments to D7900: [web] Add thumbhash to encrypted media, fix spinner.
May 24 2023, 12:37 AM
bartek added inline comments to D7947: [web] Support thumbhash in modals.
May 24 2023, 12:37 AM
bartek updated the diff for D7900: [web] Add thumbhash to encrypted media, fix spinner.

Reworked the diff to the new approach. Now encrypted media also use LoadableVideo to display thumbhash and thumbnail for the video.

May 24 2023, 12:34 AM
bartek updated the diff for D7947: [web] Support thumbhash in modals.

Reworked the diff to the new approach. The only significant change here is that one usage of the state defined in this diff is moved to D7900.

May 24 2023, 12:33 AM
bartek updated the diff for D7902: [web] Display thumbhash in chat.

Reworked the video approach to display actual thumbnails as soon as possible. I admit this looks well, but needed to throttle network to "Slow 3G" to be able to see the effect in some cases. I'm not sure if this is a good idea, but I think it's better than nothing. I also added a placeholder for the thumbnail in case the video is not loaded yet.
Now it works especially as requested: The thumbnail is displayed as soon as it is downloaded/decrypted and replaces the thumbhash. Code for this is in D7946

May 24 2023, 12:30 AM
bartek updated the diff for D7946: [web] Add loadable video component.
  • Changed logic to display actual video thumbnail as soon as possible
  • Added support for encrypted video thumbnails
  • Added a forwardRef to the video element which will be needed for encrypted media
May 24 2023, 12:25 AM
bartek added a comment to D7902: [web] Display thumbhash in chat.

Whereas my view is that the thumbhash is just meant to make the transition of loading the content more "seamless", but otherwise the behavior should be to aim to present the highest fidelity version of the content we can display at any given moment.

In terms of concrete benefits, presenting the highest fidelity version of the content allows the user to "see" things as quickly as possible, which I think improves the user experience.

May 24 2023, 12:11 AM
bartek retitled D7900: [web] Add thumbhash to encrypted media, fix spinner from [web] Add placeholder prop to encrypted media, fix spinner to [web] Add thumbhash to encrypted media, fix spinner.
May 24 2023, 12:06 AM
bartek updated the summary of D7902: [web] Display thumbhash in chat.
May 24 2023, 12:03 AM
bartek updated the summary of D7900: [web] Add thumbhash to encrypted media, fix spinner.
May 24 2023, 12:01 AM
bartek updated the summary of D7947: [web] Support thumbhash in modals.
May 24 2023, 12:00 AM

May 23 2023

bartek updated the summary of D7946: [web] Add loadable video component.
May 23 2023, 11:59 PM
ashoat added inline comments to D7939: [native] stop persisting reports.
May 23 2023, 5:59 PM
kamil published D7939: [native] stop persisting reports for review.
May 23 2023, 4:56 PM
kamil published D7938: [native] fetch reports from SQLite and dispatch to store for review.
May 23 2023, 4:55 PM
kamil published D7937: [native] start processing report store operations on database for review.
May 23 2023, 4:55 PM
kamil published D7936: [CommCoreModule] implement getting report store from database for review.
May 23 2023, 4:55 PM
kamil updated the diff for D7934: [CommCoreModule] implement report store operations.

fix import

May 23 2023, 4:30 PM
kamil published D7934: [CommCoreModule] implement report store operations for review.
May 23 2023, 4:24 PM
kamil published D7918: [CommCoreModule] add table and methods for report store for review.
May 23 2023, 4:22 PM
kamil accepted D7906: [keyserver] Create an endpoint that allows disabling links.
May 23 2023, 4:21 PM
kamil accepted D7878: [keyserver] Create an endpoint that can be used to create or update a public link.
May 23 2023, 4:14 PM
kamil accepted D7877: [lib] Create a store in redux for the invite links.
May 23 2023, 4:08 PM
ashoat accepted D7953: [native] Add `communityNameNotice` to `CommunityConfiguration`.
May 23 2023, 2:26 PM
ashoat requested changes to D7952: [native] Add community name `TextInput` to `CommunityConfiguration`.

The placeholder color you're using is super bright. Can you link to designs? Feels like it might be best to stick with what RegistrationTextInput does for consistency

May 23 2023, 2:26 PM
ashoat accepted D7951: [native] Add keyserver label to `CommunityConfiguration`.
May 23 2023, 2:18 PM
ashoat requested changes to D7950: [native] Introduce `CommunityCreationNavigator`.

High-level approach is great, but some comments below

May 23 2023, 2:16 PM
ashoat requested changes to D7902: [web] Display thumbhash in chat.

Passing back to your queue, but feel free to-request review again if there's something that I'm missing. Also please let me know if this would be a difficult change to make... my impression is that changes in D7946 should hopefully be easy, but I'm not sure about the whole scope of changes that would be required.

May 23 2023, 2:06 PM
bartek requested review of D7902: [web] Display thumbhash in chat.
May 23 2023, 1:43 PM
atul requested review of D7953: [native] Add `communityNameNotice` to `CommunityConfiguration`.
May 23 2023, 1:41 PM
atul requested review of D7952: [native] Add community name `TextInput` to `CommunityConfiguration`.
May 23 2023, 1:40 PM
atul requested review of D7951: [native] Add keyserver label to `CommunityConfiguration`.
May 23 2023, 1:40 PM
atul requested review of D7950: [native] Introduce `CommunityCreationNavigator`.
May 23 2023, 1:40 PM
ashoat accepted D7947: [web] Support thumbhash in modals.
May 23 2023, 1:15 PM
ashoat requested changes to D7946: [web] Add loadable video component.
May 23 2023, 1:08 PM
ashoat requested changes to D7900: [web] Add thumbhash to encrypted media, fix spinner.
May 23 2023, 1:03 PM
ashoat requested changes to D7902: [web] Display thumbhash in chat.

I think either there's a disconnect about when to display the thumbhash vs. the thumbnail, or perhaps I am misunderstanding the feasibility of my suggestion. Please let me know if I'm missing something!

May 23 2023, 1:00 PM
ashoat accepted D7942: [native] Fix reply not working in search results.

Thanks for explaining everything!

May 23 2023, 11:58 AM
ashoat added a comment to D7870: [landing] fix mobile nav still being shown when window resizes.

The last comment was pretty concerning...

May 23 2023, 11:48 AM
ashoat added inline comments to D7930: [web] Changed edit modal overlay opacity.
May 23 2023, 11:36 AM
ashoat accepted D7899: [web] Refactor Mutlimedia to function component.
May 23 2023, 11:34 AM
ashoat accepted D7814: Implement method in NSE to decrypt notification.
May 23 2023, 11:33 AM
ashoat accepted D7813: Implement function to encrypt relevant parts of iOS notification.
May 23 2023, 11:31 AM
ashoat added inline comments to D7837: [web] Added FocusTrap for modals.
May 23 2023, 11:29 AM
ashoat added a comment to D7730: [native] Create a modal where invite links are displayed.

As @ted is off for now, I don't think it makes sense to block this diff on this change.

May 23 2023, 11:26 AM
ashoat accepted D7944: [keyserver] Use mixed as an input type in inviteLinkVerificationResponder.
May 23 2023, 11:24 AM
ginsu added a comment to D7904: [landing] introduce signal competitor data.

Assuming @ashoat has signed off on copy + we're fine with having lines extend past 80 characters since this is a "data" file vs. "code" file?

May 23 2023, 9:51 AM
ginsu updated the diff for D7904: [landing] introduce signal competitor data.

address comments and remove logoImageURL field (since we are using svgs now)

May 23 2023, 9:46 AM
ginsu updated the diff for D7870: [landing] fix mobile nav still being shown when window resizes.

address comments

May 23 2023, 9:37 AM
ginsu added inline comments to D7870: [landing] fix mobile nav still being shown when window resizes.
May 23 2023, 9:36 AM