Thanks!
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jun 21 2024
Jun 21 2024
kamil published D12536: [lib][web][native] set local Tunnelbroker device token on client for review.
bump version
Jun 20 2024
Jun 20 2024
kamil published D12525: [proto][Tunnelbroker] add RPC to delete device data from Tunnelbroker for review.
kamil committed rCOMM49a75b90db1a: [lib][web][native] improve naming in `QRAuthProvider` (authored by kamil).
[lib][web][native] improve naming in `QRAuthProvider`
Jun 19 2024
Jun 19 2024
Probably you know it better so up to you but for me recipientID seems better than cryptoID
kamil requested changes to D12397: Move notification creaction and encryption to lib except for APNs noifs..
Looks good but want to see responses to the inline comments before accepting.
I would consider registering config for keyserver to be able to use encryptedNotifUtilsAPI directly - passing it as a param trough all these functions makes it messy. In the future, we'll also want sqliteAPI to be implemented on keyserver, but this is something we can discuss in the Linear follow-up task because right now Config type is designed specifically for web & native.
kamil committed rCOMMc0d08c904b92: [lib] broadcast updates to all peers after Secondary Device registration success (authored by kamil).
[lib] broadcast updates to all peers after Secondary Device registration success
kamil committed rCOMMe5cb65cf5e8a: [lib] avoid listening to Tunnelbroker messages in `QRAuthProvider` when QR auth… (authored by kamil).
[lib] avoid listening to Tunnelbroker messages in `QRAuthProvider` when QR auth…
kamil committed rCOMM6545f05756a8: [lib] broadcast device list updates after Tunnelbroker socket connection is… (authored by kamil).
[lib] broadcast device list updates after Tunnelbroker socket connection is…
[native] remove `useQRAuth` hook
kamil committed rCOMM831b3f2a9d91: [native] update QR login flow to use `QRAuthContext` (authored by kamil).
[native] update QR login flow to use `QRAuthContext`
kamil committed rCOMM69332152efe6: [web] update QR login flow to use `QRAuthContext` (authored by kamil).
[web] update QR login flow to use `QRAuthContext`
[lib] implement `QRAuthContext`
kamil committed rCOMMc3e4fb49a47a: [web][native] extract QR code login functions to separate files (authored by kamil).
[web][native] extract QR code login functions to separate files
kamil committed rCOMM3b4e4d7317ed: [lib] improve handling Tunnelbroker socket state (authored by kamil).
[lib] improve handling Tunnelbroker socket state
kamil requested changes to D12395: Enable encrypted notifications to have keyservevrID or senderDeviceID.
Back to your queue to address inline comments
kamil updated the diff for D12430: [lib] broadcast updates to all peers after Secondary Device registration success.
rebase before landing
kamil updated the diff for D12454: [lib] avoid listening to Tunnelbroker messages in `QRAuthProvider` when QR auth is finished.
remove effect
rebase
rebase
address review
Error -> mixed
Jun 18 2024
Jun 18 2024
kamil added a comment to D12454: [lib] avoid listening to Tunnelbroker messages in `QRAuthProvider` when QR auth is finished.
In D12454#353497, @ashoat wrote:What happens if the user logs in via QR code, then logs out, and then tries again? It seems like qrAuthFinished is never set to false after being set to true, which makes me suspect that things will be broken in this case.
kamil updated the diff for D12454: [lib] avoid listening to Tunnelbroker messages in `QRAuthProvider` when QR auth is finished.
set qrAuthFinished to false when calling generateQRCode
kamil added inline comments to D12380: [lib] broadcast updates when becoming aware of new device existence.
Jun 17 2024
Jun 17 2024
Jun 14 2024
Jun 14 2024
[lib] remove initial peer list testing code
kamil committed rCOMM47f0ef750274: [terraform] Deploy Identity `0.23-staging` to staging (authored by kamil).
[terraform] Deploy Identity `0.23-staging` to staging