Paths

Table of Contentst

Differential D3630

[services] Backup - Add find backup item to database manager
ClosedPublic
Actions

Authored by • karol on Apr 6 2022, 7:35 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Oct 13, 3:42 PM

	Unknown Object (File)
	Sun, Oct 13, 3:42 PM

	Unknown Object (File)
	Sun, Oct 13, 3:42 PM

	Unknown Object (File)
	Sun, Oct 13, 3:41 PM

	Unknown Object (File)
	Sun, Oct 13, 3:39 PM

	Unknown Object (File)
	Sun, Oct 6, 9:29 AM

	Unknown Object (File)
	Sep 15 2024, 4:58 AM

	Unknown Object (File)
	Sep 15 2024, 4:58 AM

Subscribers

Details

Reviewers

tomek
• max

Commits

rCOMM7b2140c8acb4: [services] Backup - Add find backup item to database manager

Summary

Depends on D3629

We need a method in the database manager for finding a backup item by the backup id and user id.

Test Plan

The same as in D3535

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Apr 6 2022, 7:35 AM

Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 6 2022, 7:35 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 6 2022, 7:46 AM

Harbormaster failed remote builds in B7922: Diff 11104!

• karol edited the summary of this revision. (Show Details)Apr 6 2022, 7:53 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max.

• karol added a parent revision: D3629: [services] Backup - Add blob get client reactor.

• karol added a child revision: D3632: [services] Backup - Implement get method in service blob client.Apr 6 2022, 7:55 AM

retrigger ci

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 7 2022, 4:01 AM

Harbormaster failed remote builds in B7961: Diff 11165!

• karol requested review of this revision.Apr 7 2022, 4:23 AM

tomek accepted this revision.Apr 8 2022, 2:43 AM

This revision is now accepted and ready to land.Apr 8 2022, 2:43 AM

This revision was landed with ongoing or failed builds.Apr 13 2022, 5:13 AM

Closed by commit rCOMM7b2140c8acb4: [services] Backup - Add find backup item to database manager (authored by • karol). · Explain Why

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM7b2140c8acb4: [services] Backup - Add find backup item to database manager.

ashoat added inline comments.Apr 18 2022, 11:29 AM

services/backup/docker-server/contents/server/src/DatabaseManager.cpp
90	@atul is this an example of an `std::move` we should avoid? Maybe you could add a note to Notion so we could have something to link whenever this comes up?

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

DatabaseManager.h

2 lines

DatabaseManager.cpp

13 lines

Diff 11407

services/backup/docker-server/contents/server/src/DatabaseManager.h

Loading...

services/backup/docker-server/contents/server/src/DatabaseManager.cpp

Loading...