Paths

Table of Contentst

Differential D3585

[services] Backup - mind empty attachment holders
ClosedPublic
Actions

Authored by • karol on Mar 31 2022, 6:32 AM.

Tags

None

Referenced Files

	F3348162: D3585.diff
	Fri, Nov 22, 1:59 PM

	Unknown Object (File)
	Tue, Nov 5, 5:55 PM

	Unknown Object (File)
	Oct 20 2024, 8:31 PM

	Unknown Object (File)
	Oct 20 2024, 6:41 PM

	Unknown Object (File)
	Oct 16 2024, 4:33 PM

	Unknown Object (File)
	Oct 13 2024, 4:17 PM

	Unknown Object (File)
	Oct 13 2024, 4:17 PM

	Unknown Object (File)
	Oct 13 2024, 4:17 PM

Subscribers

Details

Reviewers

tomek
• max
• jim
varun

Commits

rCOMMc59027f71a32: [services] Backup - mind empty attachment holders

Summary

Depends on D3583

Use assignItemFromDatabaseUserIDCreatedIndex method introduced in the previous diff in the DatabaseManager.

Test Plan

cd services
yarn run-backup-service

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Mar 31 2022, 6:32 AM

Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptMar 31 2022, 6:32 AM

• karol edited the summary of this revision. (Show Details)Mar 31 2022, 6:43 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max, • jim, varun.

• karol added a parent revision: D3584: [services] Backup - consider index for BackupItem.

• karol added a child revision: D3586: [services] Backup - Send log - add store in database.

Harbormaster completed remote builds in B7765: Diff 10881.Mar 31 2022, 6:58 AM

• karol requested review of this revision.Mar 31 2022, 6:58 AM

tomek accepted this revision.Apr 6 2022, 11:56 PM

tomek added inline comments.

services/backup/docker-server/contents/server/src/DatabaseManager.cpp
106–109 ↗	(On Diff #10881)	If `assignItemFromDatabaseUserIDCreatedIndex` is really needed, then it makes sense. But we should clarify in D3584 if that's the case
132–136 ↗	(On Diff #10881)	This change seem to be unrelated - it makes sense but shouldn't be a part of the diff where we `use index in DatabaseManager`

This revision is now accepted and ready to land.Apr 6 2022, 11:56 PM

• karol edited the summary of this revision. (Show Details)Apr 7 2022, 5:37 AM

• karol added a parent revision: D3583: [services] Backup - fix handling reading done in client reactors.

remove index

• karol requested review of this revision.Apr 7 2022, 5:40 AM

• karol retitled this revision from [services] Backup - use index in DatabaseManager to [services] Backup - mind empty attachment holders.

Harbormaster completed remote builds in B7964: Diff 11168.Apr 7 2022, 8:20 AM

tomek accepted this revision.Apr 8 2022, 1:04 AM

This revision is now accepted and ready to land.Apr 8 2022, 1:04 AM

update

Harbormaster completed remote builds in B8145: Diff 11382.Apr 13 2022, 1:12 AM

Closed by commit rCOMMc59027f71a32: [services] Backup - mind empty attachment holders (authored by • karol). · Explain WhyApr 13 2022, 4:04 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMMc59027f71a32: [services] Backup - mind empty attachment holders.

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

DatabaseManager.cpp

8 lines

Diff 11390

services/backup/docker-server/contents/server/src/DatabaseManager.cpp

Loading...