Page MenuHomePhabricator

[services] Backup - Add server reactor base classes - read reactor
ClosedPublic

Authored by karol on Mar 24 2022, 1:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 27, 4:14 AM
Unknown Object (File)
Sun, Oct 20, 11:04 AM
Unknown Object (File)
Sun, Oct 13, 7:34 PM
Unknown Object (File)
Sun, Oct 13, 7:34 PM
Unknown Object (File)
Sun, Oct 13, 7:34 PM
Unknown Object (File)
Sun, Oct 13, 7:34 PM
Unknown Object (File)
Sun, Oct 13, 7:33 PM
Unknown Object (File)
Sun, Oct 13, 7:33 PM

Details

Summary

Depends on D3464

This class is moved and renamed for a better folder structure.
As we need to add client reactors in order to be able to connect to the blob service, we need to distinguish server reactors from client reactors.

Test Plan
cd services
yarn run-backup-service

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

karol edited the summary of this revision. (Show Details)
karol edited the test plan for this revision. (Show Details)
karol added reviewers: tomek, max, varun, jim.
karol edited the summary of this revision. (Show Details)

update

karol retitled this revision from [services] Backup - Add server reactor base classes - read reactor to [draft] [services] Backup - Add server reactor base classes - read reactor.Mar 24 2022, 2:47 AM
karol edited the summary of this revision. (Show Details)
tomek added inline comments.
services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerReadReactorBase.h
21 ↗(On Diff #10662)

Do we need to make this atomic?

This revision is now accepted and ready to land.Mar 24 2022, 5:27 AM
services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerReadReactorBase.h
30 ↗(On Diff #10662)

It's strange that clang-format omits the space between () and {} here, but includes it when it is multiline. Are you sure scripts/get_clang_paths.js is covering this directory?

About the threading problem: Let's wait for an answer on the SO. If there's none, we may want to research it on our own. I created a task for this https://linear.app/comm/issue/ENG-914/take-care-of-the-threading-problem-in-the-grpc-async-api

services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerReadReactorBase.h
21 ↗(On Diff #10662)

I'm not sure about how to approach changing the reactors' state. In the grpc examples, they do not synchronize the state manually. On the other hand, there may be a problem that you pointed out about not flushing the updated state to the main memory.

I saw multiple similar comments from you about this. As this is a bit confusing, I took some time and prepared a question on StackOverflow about this. I hope we get a response from the grpc authors.

30 ↗(On Diff #10662)

Yes, clang takes care of this directory.

BTW, there are some problems in the scripts/get_clang_paths.js. I'm going to fix this.

It is accepted as a draft so I removed the draft label and I'm requesting changes once again to keep the appropriate order of events.

services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerReadReactorBase.h
30 ↗(On Diff #10662)
karol retitled this revision from [draft] [services] Backup - Add server reactor base classes - read reactor to [services] Backup - Add server reactor base classes - read reactor.Mar 25 2022, 2:39 AM
This revision is now accepted and ready to land.Mar 28 2022, 9:30 AM