Paths

Table of Contentst

-
services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/
-
backup/
-
docker-server/
-
contents/
-
server/
-
src/
-
Reactors/
-
client/
-
base-reactors/
-
ClientReadReactorBase.h

[services] Backup - Add client reactor base classes - read reactor
ClosedPublic
Actions

Authored by • karol on Mar 24 2022, 1:51 AM.

Details

Reviewers

tomek
• max
varun
• jim

Commits

rCOMM886ec256ac88: [services] Backup - Add client reactor base classes - read reactor

Summary

Depends on D3465

Adding client base classes for reactors - read reactor

Test Plan

cd services
yarn run-backup-service

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Mar 24 2022, 1:51 AM

Herald added subscribers: • benschac, atul, • adrian and 2 others. · View Herald TranscriptMar 24 2022, 1:51 AM

Harbormaster completed remote builds in B7570: Diff 10641.Mar 24 2022, 2:01 AM

• karol requested review of this revision.Mar 24 2022, 2:01 AM

• karol edited the summary of this revision. (Show Details)Mar 24 2022, 2:14 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max, varun, • jim.

• karol added a parent revision: D3465: [services] Backup - Add client reactor base classes - bidi reactor.

• karol added a child revision: D3515: [services] Backup - Add client reactor base classes - write reactor.

• karol retitled this revision from [services] Backup - Add client reactor base classes - read reactor to [draft] [services] Backup - Add client reactor base classes - read reactor.Mar 24 2022, 2:47 AM

tomek accepted this revision.Mar 24 2022, 6:15 AM

tomek added inline comments.

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientReadReactorBase.h
3 ↗	(On Diff #10641)	Do we need this?

This revision is now accepted and ready to land.Mar 24 2022, 6:15 AM

• karol added inline comments.Mar 25 2022, 7:10 AM

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientReadReactorBase.h
3 ↗	(On Diff #10641)	No

remove functional header

It is accepted as a draft so I removed the draft label and I'm requesting changes once again to keep the appropriate order of events.

Harbormaster completed remote builds in B7607: Diff 10682.Mar 25 2022, 7:49 AM

tomek accepted this revision.Mar 28 2022, 9:45 AM

tomek added inline comments.

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientReadReactorBase.h
37–38 ↗	(On Diff #10682)	We should include some info about the context, e.g. which reactor logged it

This revision is now accepted and ready to land.Mar 28 2022, 9:45 AM

tomek added inline comments.Mar 28 2022, 9:47 AM

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientReadReactorBase.h
46 ↗	(On Diff #10682)	Do we need to make sure that this is called exactly once?

• karol added inline comments.Mar 29 2022, 12:27 AM

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientReadReactorBase.h
37–38 ↗	(On Diff #10682)	logs like this will be removed. If we need to log at the end of the connection, we can always override `doneCallback`.
46 ↗	(On Diff #10682)	I think so... I didn't find anything in the code that would lead to such reasoning but I intentionally called it twice and received a crash. Thanks!

start call only once, removed log

Harbormaster completed remote builds in B7653: Diff 10748.Mar 29 2022, 12:57 AM

Closed by commit rCOMM886ec256ac88: [services] Backup - Add client reactor base classes - read reactor (authored by • karol). · Explain WhyMar 31 2022, 7:20 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM886ec256ac88: [services] Backup - Add client reactor base classes - read reactor.

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

Reactors/

client/

base-reactors/

ClientReadReactorBase.h

78 lines

Diff 10891

View Options

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientReadReactorBase.h

This file was added.

				#pragma once

				#include <grpcpp/grpcpp.h>

				#include <iostream>
				#include <memory>
				#include <string>

				namespace comm {
				namespace network {
				namespace reactor {

				struct ServerBidiReactorStatus {
				grpc::Status status = grpc::Status::OK;
				bool sendLastResponse = false;
				ServerBidiReactorStatus(
				grpc::Status status = grpc::Status::OK,
				bool sendLastResponse = false)
				: status(status), sendLastResponse(sendLastResponse) {
				}
				};

				template <class Request, class Response>
				class ServerBidiReactorBase
				: public grpc::ServerBidiReactor<Request, Response> {
				Request request;
				Response response;

				protected:
				ServerBidiReactorStatus status;
				bool readingAborted = false;

				public:
				ServerBidiReactorBase();

				void OnDone() override;
				void OnReadDone(bool ok) override;
				void OnWriteDone(bool ok) override;

				void terminate(ServerBidiReactorStatus status);

				virtual std::unique_ptr<ServerBidiReactorStatus>
				handleRequest(Request request, Response *response) = 0;
				virtual void initialize(){};
				virtual void doneCallback(){};
				};

				template <class Request, class Response>
				ServerBidiReactorBase<Request, Response>::ServerBidiReactorBase() {
				this->initialize();
				this->StartRead(&this->request);
				}

				template <class Request, class Response>
				void ServerBidiReactorBase<Request, Response>::OnDone() {
				this->doneCallback();
				delete this;
				}

				template <class Request, class Response>
				void ServerBidiReactorBase<Request, Response>::terminate(
				ServerBidiReactorStatus status) {
				this->status = status;
				if (this->status.sendLastResponse) {
				this->StartWriteAndFinish(
				&this->response, grpc::WriteOptions(), this->status.status);
				} else {
				this->Finish(this->status.status);
				}
				}

				template <class Request, class Response>
				void ServerBidiReactorBase<Request, Response>::OnReadDone(bool ok) {
				if (!ok) {
				this->readingAborted = true;
				this->terminate(ServerBidiReactorStatus(
				grpc::Status(grpc::StatusCode::ABORTED, "no more reads")));
				return;
				}
				try {
				this->response = Response();
				std::unique_ptr<ServerBidiReactorStatus> status =
				this->handleRequest(this->request, &this->response);
				if (status != nullptr) {
				this->terminate(*status);
				return;
				}
				this->StartWrite(&this->response);
				} catch (std::runtime_error &e) {
				this->terminate(ServerBidiReactorStatus(
				grpc::Status(grpc::StatusCode::INTERNAL, e.what())));
				}
				}

				template <class Request, class Response>
				void ServerBidiReactorBase<Request, Response>::OnWriteDone(bool ok) {
				if (!ok) {
				this->terminate(ServerBidiReactorStatus(
				grpc::Status(grpc::StatusCode::ABORTED, "write failed")));
				return;
				}
				this->StartRead(&this->request);
				}

				} // namespace reactor
				} // namespace network
				} // namespace comm

[services] Backup - Add client reactor base classes - read reactorClosedPublicActions