Depends on D3465
Adding client base classes for reactors - read reactor
Details
Details
cd services yarn run-backup-service
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientReadReactorBase.h | ||
|---|---|---|
| 3 ↗ | (On Diff #10641) | Do we need this? |
| services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientReadReactorBase.h | ||
|---|---|---|
| 3 ↗ | (On Diff #10641) | No |
Comment Actions
It is accepted as a draft so I removed the draft label and I'm requesting changes once again to keep the appropriate order of events.
| services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientReadReactorBase.h | ||
|---|---|---|
| 37–38 ↗ | (On Diff #10682) | We should include some info about the context, e.g. which reactor logged it |
| services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientReadReactorBase.h | ||
|---|---|---|
| 46 ↗ | (On Diff #10682) | Do we need to make sure that this is called exactly once? |
| services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientReadReactorBase.h | ||
|---|---|---|
| 37–38 ↗ | (On Diff #10682) | logs like this will be removed. If we need to log at the end of the connection, we can always override doneCallback. |
| 46 ↗ | (On Diff #10682) | I think so... I didn't find anything in the code that would lead to such reasoning but I intentionally called it twice and received a crash. Thanks! |