Page MenuHomePhabricator
Differential D3728

[services] Backup/Blob - Hide nextWrite, expose start
ClosedPublic
Actions

Authored by • karol on Apr 14 2022, 3:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 11, 9:24 AM
Unknown Object (File)
Tue, Apr 8, 5:37 PM
Unknown Object (File)
Tue, Apr 8, 3:24 PM
Unknown Object (File)
Tue, Apr 8, 8:16 AM
Unknown Object (File)
Sun, Apr 6, 11:23 AM
Unknown Object (File)
Sun, Apr 6, 11:22 AM
Unknown Object (File)
Sun, Apr 6, 11:21 AM
Unknown Object (File)
Sun, Apr 6, 11:20 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
Commits
rCOMMfb4294397173: [services] Backup/Blob - Hide nextWrite, expose start
Summary

Depends on D3727

https://linear.app/comm/issue/ENG-1002/replace-nextwrite-with-start-in-reactors

Test Plan

The same as D3535 - services should work the same

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Apr 14 2022, 3:22 AM
Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 14 2022, 3:22 AM
• karol edited the summary of this revision. (Show Details)Apr 14 2022, 3:25 AM
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D3727: [services] Backup/Blob - Add comments to delete this.
• karol added a child revision: D3729: [services] Backup - Check if log item isn't too big to be stored in the database.
Harbormaster completed remote builds in B8199: Diff 11470.Apr 14 2022, 3:30 AM
• karol requested review of this revision.Apr 14 2022, 3:30 AM
tomek accepted this revision.Apr 21 2022, 1:19 AM
tomek added inline comments.
services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h
64–68 ↗(On Diff #11470)

Maybe mention start instead?

This revision is now accepted and ready to land.Apr 21 2022, 1:19 AM
• karol added inline comments.Apr 22 2022, 12:49 AM
services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h
64–68 ↗(On Diff #11470)

Yes, right, thanks!

• karol updated this revision to Diff 11764.Apr 22 2022, 12:53 AM

fix comments

Harbormaster completed remote builds in B8431: Diff 11764.Apr 22 2022, 12:57 AM
Closed by commit rCOMMfb4294397173: [services] Backup/Blob - Hide nextWrite, expose start (authored by • karol). · Explain WhyApr 22 2022, 1:08 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMfb4294397173: [services] Backup/Blob - Hide nextWrite, expose start.

Revision Contents
Changeset List

PathSize
services/
backup/
docker-server/
contents/
server/
src/
2 lines
Reactors/
client/
base-reactors/
9 lines
8 lines
server/
base-reactors/
16 lines
grpc-client/
2 lines
blob/
src/
2 lines
Reactors/
server/
base-reactors/
16 lines

Diff 11769

View Options

services/backup/docker-server/contents/server/src/BackupServiceImpl.cpp

  • This file was copied from services/backup/src/Reactors/client/blob/BlobGetClientReactor.h.
#pragma once
#include "ClientReadReactorBase.h" #include "BlobGetClientReactor.h"
#include "../_generated/blob.grpc.pb.h"
#include "../_generated/blob.pb.h"
#include <folly/MPMCQueue.h>
#include <grpcpp/grpcpp.h>
#include <memory>
#include <string>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
class BlobGetClientReactor
: public ClientReadReactorBase<blob::GetRequest, blob::GetResponse> {
std::string holder;
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks;
public:
BlobGetClientReactor(
const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks);
std::unique_ptr<grpc::Status>
readResponse(blob::GetResponse &response) override;
void doneCallback() override;
grpc::Status getStatus() const;
};
BlobGetClientReactor::BlobGetClientReactor( BlobGetClientReactor::BlobGetClientReactor(
const std::string &holder, const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks) std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks)
: holder(holder), dataChunks(dataChunks) { : holder(holder), dataChunks(dataChunks) {
} }
std::unique_ptr<grpc::Status> std::unique_ptr<grpc::Status>
BlobGetClientReactor::readResponse(blob::GetResponse &response) { BlobGetClientReactor::readResponse(blob::GetResponse &response) {
Show All 17 Lines
View Options

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientBidiReactorBase.h

  • This file was copied from services/backup/src/Reactors/client/blob/BlobGetClientReactor.h.
#pragma once
#include "ClientReadReactorBase.h" #include "BlobGetClientReactor.h"
#include "../_generated/blob.grpc.pb.h"
#include "../_generated/blob.pb.h"
#include <folly/MPMCQueue.h>
#include <grpcpp/grpcpp.h>
#include <memory>
#include <string>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
class BlobGetClientReactor
: public ClientReadReactorBase<blob::GetRequest, blob::GetResponse> {
std::string holder;
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks;
public:
BlobGetClientReactor(
const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks);
std::unique_ptr<grpc::Status>
readResponse(blob::GetResponse &response) override;
void doneCallback() override;
grpc::Status getStatus() const;
};
BlobGetClientReactor::BlobGetClientReactor( BlobGetClientReactor::BlobGetClientReactor(
const std::string &holder, const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks) std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks)
: holder(holder), dataChunks(dataChunks) { : holder(holder), dataChunks(dataChunks) {
} }
std::unique_ptr<grpc::Status> std::unique_ptr<grpc::Status>
BlobGetClientReactor::readResponse(blob::GetResponse &response) { BlobGetClientReactor::readResponse(blob::GetResponse &response) {
Show All 17 Lines
View Options

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientWriteReactorBase.h

  • This file was copied from services/backup/src/Reactors/client/blob/BlobGetClientReactor.h.
#pragma once
#include "ClientReadReactorBase.h" #include "BlobGetClientReactor.h"
#include "../_generated/blob.grpc.pb.h"
#include "../_generated/blob.pb.h"
#include <folly/MPMCQueue.h>
#include <grpcpp/grpcpp.h>
#include <memory>
#include <string>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
class BlobGetClientReactor
: public ClientReadReactorBase<blob::GetRequest, blob::GetResponse> {
std::string holder;
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks;
public:
BlobGetClientReactor(
const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks);
std::unique_ptr<grpc::Status>
readResponse(blob::GetResponse &response) override;
void doneCallback() override;
grpc::Status getStatus() const;
};
BlobGetClientReactor::BlobGetClientReactor( BlobGetClientReactor::BlobGetClientReactor(
const std::string &holder, const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks) std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks)
: holder(holder), dataChunks(dataChunks) { : holder(holder), dataChunks(dataChunks) {
} }
std::unique_ptr<grpc::Status> std::unique_ptr<grpc::Status>
BlobGetClientReactor::readResponse(blob::GetResponse &response) { BlobGetClientReactor::readResponse(blob::GetResponse &response) {
Show All 17 Lines
View Options

services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

  • This file was copied from services/backup/src/Reactors/client/blob/BlobGetClientReactor.h.
#pragma once
#include "ClientReadReactorBase.h" #include "BlobGetClientReactor.h"
#include "../_generated/blob.grpc.pb.h"
#include "../_generated/blob.pb.h"
#include <folly/MPMCQueue.h>
#include <grpcpp/grpcpp.h>
#include <memory>
#include <string>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
class BlobGetClientReactor
: public ClientReadReactorBase<blob::GetRequest, blob::GetResponse> {
std::string holder;
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks;
public:
BlobGetClientReactor(
const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks);
std::unique_ptr<grpc::Status>
readResponse(blob::GetResponse &response) override;
void doneCallback() override;
grpc::Status getStatus() const;
};
BlobGetClientReactor::BlobGetClientReactor( BlobGetClientReactor::BlobGetClientReactor(
const std::string &holder, const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks) std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks)
: holder(holder), dataChunks(dataChunks) { : holder(holder), dataChunks(dataChunks) {
} }
std::unique_ptr<grpc::Status> std::unique_ptr<grpc::Status>
BlobGetClientReactor::readResponse(blob::GetResponse &response) { BlobGetClientReactor::readResponse(blob::GetResponse &response) {
Show All 17 Lines
View Options

services/backup/docker-server/contents/server/src/grpc-client/ServiceBlobClient.h

Loading...
View Options

services/blob/src/BlobServiceImpl.cpp

Loading...
View Options

services/blob/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

Loading...