Page MenuHomePhabricator

[services] Backup - Improve code style in send log reactor
ClosedPublic

Authored by karol on Apr 19 2022, 1:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 30, 10:03 AM
Unknown Object (File)
Sun, Jun 30, 10:03 AM
Unknown Object (File)
Sun, Jun 30, 10:03 AM
Unknown Object (File)
Sun, Jun 30, 10:03 AM
Unknown Object (File)
Sun, Jun 30, 10:02 AM
Unknown Object (File)
Sun, Jun 30, 9:59 AM
Unknown Object (File)
Fri, Jun 28, 5:04 AM
Unknown Object (File)
Fri, Jun 28, 5:04 AM

Details

Summary

Depends on D3777

Add append holder logic to the add log reactor. In a case, the data already exists when adding a new log, we're just going to add a holder to the existing blob.

https://linear.app/comm/issue/ENG-672/create-addreferencetohashbyholder-in-the-blob-service

Test Plan

compile the service

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat requested changes to this revision.Apr 19 2022, 11:01 AM
ashoat added inline comments.
services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h
222–233 ↗(On Diff #11596)

Please find a way to reduce indentation here, and please start submitting diffs with this considered beforehand so the feedback doesn't need to be repeated to you

This revision now requires changes to proceed.Apr 19 2022, 11:01 AM
tomek requested changes to this revision.Apr 21 2022, 9:11 AM
tomek added inline comments.
services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h
206–233 ↗(On Diff #11716)

This code doesn't compile

This revision now requires changes to proceed.Apr 21 2022, 9:11 AM
karol retitled this revision from [services] Backup - Add append holder logic to send log reactor to [services] Backup - Improve code style in send log reactor.Apr 22 2022, 3:38 AM
karol edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Apr 25 2022, 6:43 AM