Depends on D3467
Add implementation for the send log reactor
Details
Details
cd services yarn run-backup-service
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h | ||
|---|---|---|
| 29–39 ↗ | (On Diff #10643) | Why do we have these definitions in header file? |
| services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h | ||
|---|---|---|
| 29–39 ↗ | (On Diff #10643) | I was having compile errors, here's a task for this https://linear.app/comm/issue/ENG-917/try-to-move-reactors-implementations-to-cpp-files |
| services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h | ||
|---|---|---|
| 29–39 ↗ | (On Diff #10643) | Thanks for creating the task! But this is strange to have a compilation error as SendLogReactor isn't a template, just an ordinary class |
| services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h | ||
|---|---|---|
| 29–39 ↗ | (On Diff #10643) | Right, I might've been wrong in this particular case, or maybe not. Let's follow up in the task. |
Comment Actions
It is accepted as a draft so I removed the draft label and I'm requesting changes once again to keep the appropriate order of events.