Page MenuHomePhabricator

[services] Backup - Add server reactor implementations - send log reactor
ClosedPublic

Authored by karol on Mar 24 2022, 1:52 AM.
Tags
None
Referenced Files
F3351522: D3516.id10643.diff
Sat, Nov 23, 2:13 AM
Unknown Object (File)
Mon, Nov 11, 3:52 PM
Unknown Object (File)
Sun, Nov 10, 12:17 PM
Unknown Object (File)
Tue, Nov 5, 7:02 PM
Unknown Object (File)
Thu, Oct 31, 8:40 PM
Unknown Object (File)
Thu, Oct 31, 8:35 PM
Unknown Object (File)
Thu, Oct 31, 6:19 PM
Unknown Object (File)
Thu, Oct 31, 7:38 AM

Details

Summary

Depends on D3467

Add implementation for the send log reactor

Test Plan
cd services
yarn run-backup-service

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

karol retitled this revision from [services] Backup - Add server reactor implementations - send log reactor to [draft] [services] Backup - Add server reactor implementations - send log reactor.Mar 24 2022, 2:47 AM
tomek requested changes to this revision.Mar 24 2022, 8:13 AM
tomek added inline comments.
services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h
29–39 ↗(On Diff #10643)

Why do we have these definitions in header file?

This revision now requires changes to proceed.Mar 24 2022, 8:13 AM
karol added inline comments.
services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h
29–39 ↗(On Diff #10643)
tomek added inline comments.
services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h
29–39 ↗(On Diff #10643)

Thanks for creating the task! But this is strange to have a compilation error as SendLogReactor isn't a template, just an ordinary class

This revision is now accepted and ready to land.Mar 25 2022, 8:42 AM
services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h
29–39 ↗(On Diff #10643)

Right, I might've been wrong in this particular case, or maybe not. Let's follow up in the task.

It is accepted as a draft so I removed the draft label and I'm requesting changes once again to keep the appropriate order of events.

karol retitled this revision from [draft] [services] Backup - Add server reactor implementations - send log reactor to [services] Backup - Add server reactor implementations - send log reactor.Mar 28 2022, 3:48 AM

todo remove logs

I decided to leave logs but I added TODOs

This revision is now accepted and ready to land.Mar 28 2022, 9:53 AM