Page MenuHomePhabricator
Differential D3463

[services] Backup - Add random string to tools
ClosedPublic
Actions

Authored by • karol on Mar 21 2022, 2:38 AM.
Tags
None
Referenced Files
F5913680: D3463.id10539.diff
Thu, Apr 17, 8:12 PM
F5906455: D3463.id10710.diff
Thu, Apr 17, 2:14 PM
F5894031: D3463.id.diff
Thu, Apr 17, 9:59 AM
Unknown Object (File)
Tue, Apr 15, 9:00 PM
Unknown Object (File)
Tue, Apr 8, 6:30 PM
Unknown Object (File)
Tue, Apr 8, 4:39 PM
Unknown Object (File)
Tue, Apr 8, 9:05 AM
Unknown Object (File)
Tue, Apr 8, 7:03 AM
View All Files
Subscribers
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
• jim
• max
varun
Commits
rCOMM7028fb79cf4a: [services] Backup - Add random string to tools
Summary

Depends on D3462

I needed a random string generator for testing the backup service. Once we're done mocking things in this service, this can be removed.

Test Plan
cd services
yarn run-backup-service

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Mar 21 2022, 2:38 AM
Herald added subscribers: • benschac, atul, • adrian and 2 others. · View Herald TranscriptMar 21 2022, 2:38 AM
Harbormaster completed remote builds in B7484: Diff 10539.Mar 21 2022, 2:50 AM
• karol requested review of this revision.Mar 21 2022, 2:50 AM
• karol edited the summary of this revision. (Show Details)Mar 21 2022, 2:55 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, • jim, • max, varun.
• karol added a parent revision: D3462: [services] Backup - Prepare for communication with Blob.
• karol added a child revision: D3464: [services] Backup - Add server reactor base classes - bidi reactor.Mar 21 2022, 3:07 AM
• karol retitled this revision from [services] Backup - Add random string to tools to [draft] [services] Backup - Add random string to tools.Mar 21 2022, 3:09 AM
tomek accepted this revision.Mar 22 2022, 4:55 AM
This revision is now accepted and ready to land.Mar 22 2022, 4:55 AM
• karol requested review of this revision.Mar 25 2022, 1:04 AM

It is accepted as a draft so I removed the draft label and I'm requesting changes once again to keep the appropriate order of events.

• karol retitled this revision from [draft] [services] Backup - Add random string to tools to [services] Backup - Add random string to tools.Mar 25 2022, 1:04 AM
tomek accepted this revision.Mar 25 2022, 8:46 AM
This revision is now accepted and ready to land.Mar 25 2022, 8:46 AM
Closed by commit rCOMM7028fb79cf4a: [services] Backup - Add random string to tools (authored by • karol). · Explain WhyMar 28 2022, 12:58 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM7028fb79cf4a: [services] Backup - Add random string to tools.

Revision Contents
Changeset List

PathSize
services/
backup/
docker-server/
contents/
server/
src/
2 lines
13 lines

Diff 10710

View Options

services/backup/docker-server/contents/server/src/Tools.h

#include <grpcpp/grpcpp.h> #include <grpcpp/grpcpp.h>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
template <class Request, class Response> template <class Request, class Response>
class ClientWriteReactorBase : public grpc::ClientWriteReactor<Request> { class ClientWriteReactorBase : public grpc::ClientWriteReactor<Request> {
grpc::Status status; grpc::Status status = grpc::Status::OK;
bool done = false; bool done = false;
bool initialized = 0; bool initialized = 0;
Request request; Request request;
public: public:
Response response; Response response;
grpc::ClientContext context; grpc::ClientContext context;
void nextWrite(); void nextWrite();
void OnWriteDone(bool ok) override; void OnWriteDone(bool ok) override;
void terminate(const grpc::Status &status); void terminate(const grpc::Status &status);
bool isDone(); bool isDone();
void OnDone(const grpc::Status &status) override; void OnDone(const grpc::Status &status) override;
virtual std::unique_ptr<grpc::Status> prepareRequest(Request &request) = 0; virtual std::unique_ptr<grpc::Status> prepareRequest(Request &request) = 0;
virtual void validate(){};
virtual void doneCallback(){}; virtual void doneCallback(){};
virtual void terminateCallback(){}; virtual void terminateCallback(){};
}; };
template <class Request, class Response> template <class Request, class Response>
void ClientWriteReactorBase<Request, Response>::nextWrite() { void ClientWriteReactorBase<Request, Response>::nextWrite() {
this->request = Request(); this->request = Request();
std::unique_ptr<grpc::Status> status = this->prepareRequest(this->request); std::unique_ptr<grpc::Status> status = this->prepareRequest(this->request);
Show All 15 Lines if (!ok) {
return; return;
} }
this->nextWrite(); this->nextWrite();
} }
template <class Request, class Response> template <class Request, class Response>
void ClientWriteReactorBase<Request, Response>::terminate( void ClientWriteReactorBase<Request, Response>::terminate(
const grpc::Status &status) { const grpc::Status &status) {
this->terminateCallback(); if (this->status.ok()) {
if (this->done) { this->status = status;
return;
} }
if (!this->status.ok()) { if (!this->status.ok()) {
std::cout << "error: " << this->status.error_message() << std::endl; std::cout << "error: " << this->status.error_message() << std::endl;
} }
this->status = status; if (this->done) {
return;
}
this->terminateCallback();
try {
this->validate();
} catch (std::runtime_error &e) {
this->status = grpc::Status(grpc::StatusCode::INTERNAL, e.what());
}
this->done = true; this->done = true;
this->StartWritesDone(); this->StartWritesDone();
} }
template <class Request, class Response> template <class Request, class Response>
bool ClientWriteReactorBase<Request, Response>::isDone() { bool ClientWriteReactorBase<Request, Response>::isDone() {
return this->done; return this->done;
} }
Show All 11 Lines
View Options

services/backup/docker-server/contents/server/src/Tools.cpp

#include <grpcpp/grpcpp.h> #include <grpcpp/grpcpp.h>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
template <class Request, class Response> template <class Request, class Response>
class ClientWriteReactorBase : public grpc::ClientWriteReactor<Request> { class ClientWriteReactorBase : public grpc::ClientWriteReactor<Request> {
grpc::Status status; grpc::Status status = grpc::Status::OK;
bool done = false; bool done = false;
bool initialized = 0; bool initialized = 0;
Request request; Request request;
public: public:
Response response; Response response;
grpc::ClientContext context; grpc::ClientContext context;
void nextWrite(); void nextWrite();
void OnWriteDone(bool ok) override; void OnWriteDone(bool ok) override;
void terminate(const grpc::Status &status); void terminate(const grpc::Status &status);
bool isDone(); bool isDone();
void OnDone(const grpc::Status &status) override; void OnDone(const grpc::Status &status) override;
virtual std::unique_ptr<grpc::Status> prepareRequest(Request &request) = 0; virtual std::unique_ptr<grpc::Status> prepareRequest(Request &request) = 0;
virtual void validate(){};
virtual void doneCallback(){}; virtual void doneCallback(){};
virtual void terminateCallback(){}; virtual void terminateCallback(){};
}; };
template <class Request, class Response> template <class Request, class Response>
void ClientWriteReactorBase<Request, Response>::nextWrite() { void ClientWriteReactorBase<Request, Response>::nextWrite() {
this->request = Request(); this->request = Request();
std::unique_ptr<grpc::Status> status = this->prepareRequest(this->request); std::unique_ptr<grpc::Status> status = this->prepareRequest(this->request);
Show All 15 Lines if (!ok) {
return; return;
} }
this->nextWrite(); this->nextWrite();
} }
template <class Request, class Response> template <class Request, class Response>
void ClientWriteReactorBase<Request, Response>::terminate( void ClientWriteReactorBase<Request, Response>::terminate(
const grpc::Status &status) { const grpc::Status &status) {
this->terminateCallback(); if (this->status.ok()) {
if (this->done) { this->status = status;
return;
} }
if (!this->status.ok()) { if (!this->status.ok()) {
std::cout << "error: " << this->status.error_message() << std::endl; std::cout << "error: " << this->status.error_message() << std::endl;
} }
this->status = status; if (this->done) {
return;
}
this->terminateCallback();
try {
this->validate();
} catch (std::runtime_error &e) {
this->status = grpc::Status(grpc::StatusCode::INTERNAL, e.what());
}
this->done = true; this->done = true;
this->StartWritesDone(); this->StartWritesDone();
} }
template <class Request, class Response> template <class Request, class Response>
bool ClientWriteReactorBase<Request, Response>::isDone() { bool ClientWriteReactorBase<Request, Response>::isDone() {
return this->done; return this->done;
} }
Show All 11 Lines