Depends on D3773
Adding BlobAppendHolderClientReactor to the backup service
https://linear.app/comm/issue/ENG-672/create-addreferencetohashbyholder-in-the-blob-service
Differential D3774
[services] Backup - Add append holder reactor • karol on Apr 19 2022, 1:56 AM. Authored by Tags None Referenced Files
Details Depends on D3773 Adding BlobAppendHolderClientReactor to the backup service https://linear.app/comm/issue/ENG-672/create-addreferencetohashbyholder-in-the-blob-service cd services yarn run-backup-service
Diff Detail
Event TimelineComment Actions I suspect it probably would've been best to hold off on putting these diffs up... it feels like you just made three commits and diffed them immediately, but I suspect we will see a lot more commits you make to these files and subsequently a lot more diffs... A good way to think about it: make sure you have a way to test something before you put up a diff up. In this case, looking at your test plans it seems like you don't have anything other than simply compiling the service. Comment Actions Ok, that makes sense. I find it useful to sometimes write new code just for the testing purpose - that might help. This code is usually really ugly, so it's costly to transform it into proper tests, but it lets me verify the correctness quickly. Comment Actions This is a part of mistakenly added code, more details in https://phabricator.ashoat.com/D3772#105661. Abandoning. Sorry for the inconvenience, thank you for the review. |