I suspect it probably would've been best to hold off on putting these diffs up... it feels like you just made three commits and diffed them immediately, but I suspect we will see a lot more commits you make to these files and subsequently a lot more diffs...

A good way to think about it: make sure you have a way to test something before you put up a diff up. In this case, looking at your test plans it seems like you don't have anything other than simply compiling the service.

Is there a way to create a test plan that verifies the logic?

This revision now requires changes to proceed.Apr 21 2022, 2:12 AM

Kind of hard to come up with a different test plan than a successful compilation in a case when this code's not used anywhere. This is used in D3777 where the test plan points to D3535 and covers the client-server communication.

In D3774#105264, @karol-bisztyga wrote:

Kind of hard to come up with a different test plan than a successful compilation in a case when this code's not used anywhere. This is used in D3777 where the test plan points to D3535 and covers the client-server communication.

Ok, that makes sense. I find it useful to sometimes write new code just for the testing purpose - that might help. This code is usually really ugly, so it's costly to transform it into proper tests, but it lets me verify the correctness quickly.

This revision is now accepted and ready to land.Apr 21 2022, 8:37 AM

See feedback in D3772

This revision now requires changes to proceed.Apr 21 2022, 3:16 PM

This is a part of mistakenly added code, more details in https://phabricator.ashoat.com/D3772#105661.

Abandoning. Sorry for the inconvenience, thank you for the review.

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

Reactors/

client/

blob/

BlobAppendHolderClientReactor.h

51 lines

Diff 11592

View Options

services/backup/docker-server/contents/server/src/Reactors/client/blob/BlobAppendHolderClientReactor.h

Show First 20 Lines • Show All 85 Lines • ▼ Show 20 Lines	output: {
filename: 'app.build.cjs',		filename: 'app.build.cjs',
library: 'app',		library: 'app',
libraryTarget: 'commonjs2',		libraryTarget: 'commonjs2',
path: path.join(__dirname, 'dist'),		path: path.join(__dirname, 'dist'),
},		},
};		};

const baseWebWorkersConfig = {		const baseWebWorkersConfig = {
plugins: [
new CopyPlugin({
patterns: [
{
from: 'node_modules/sql.js/dist/sql-wasm.wasm',
to: path.join(__dirname, 'dist'),
},
],
}),
],
entry: {		entry: {
pushNotif: './push-notif/service-worker.js',		pushNotif: './push-notif/service-worker.js',
database: './database/worker/db-worker.js',		database: './database/worker/db-worker.js',
},		},
output: {		output: {
filename: '[name].build.js',		filename: '[name].build.js',
path: path.join(__dirname, 'dist', 'webworkers'),		path: path.join(__dirname, 'dist', 'webworkers'),
},		},
resolve: {		resolve: {
fallback: {		fallback: {
crypto: false,		crypto: false,
fs: false,		fs: false,
path: false,		path: false,
},		},
},		},
};		};

		const devWebWorkersPlugins = [
		new CopyPlugin({
		patterns: [
		{
		from: 'node_modules/sql.js/dist/sql-wasm.wasm',
		to: path.join(__dirname, 'dist', 'webworkers'),
		},
		],
		}),
		];

		const prodWebWorkersPlugins = [
		new CopyPlugin({
		patterns: [
		{
		from: 'node_modules/sql.js/dist/sql-wasm.wasm',
		to: path.join(
		__dirname,
		'dist',
		'webworkers',
		'sql-wasm.[contenthash:12].wasm',
		),
		},
		],
		}),
		new WebpackManifestPlugin({
		publicPath: '',
		}),
		];

module.exports = function (env) {		module.exports = function (env) {
const browserConfig = env.prod		const browserConfig = env.prod
? createProdBrowserConfig(baseProdBrowserConfig, babelConfig)		? createProdBrowserConfig(baseProdBrowserConfig, babelConfig)
: createDevBrowserConfig(baseDevBrowserConfig, babelConfig);		: createDevBrowserConfig(baseDevBrowserConfig, babelConfig);
const nodeConfig = createNodeServerRenderingConfig(		const nodeConfig = createNodeServerRenderingConfig(
baseNodeServerRenderingConfig,		baseNodeServerRenderingConfig,
babelConfig,		babelConfig,
);		);
const nodeServerRenderingConfig = {		const nodeServerRenderingConfig = {
...nodeConfig,		...nodeConfig,
mode: env.prod ? 'production' : 'development',		mode: env.prod ? 'production' : 'development',
};		};

		const workersConfig = {
		...baseWebWorkersConfig,
		plugins: env.prod ? prodWebWorkersPlugins : devWebWorkersPlugins,
		};
const webWorkersConfig = createWebWorkersConfig(		const webWorkersConfig = createWebWorkersConfig(
env,		env,
baseWebWorkersConfig,		workersConfig,
babelConfig,		babelConfig,
);		);
return [browserConfig, nodeServerRenderingConfig, webWorkersConfig];		return [browserConfig, nodeServerRenderingConfig, webWorkersConfig];
};		};

[services] Backup - Add append holder reactorAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 11592

services/backup/docker-server/contents/server/src/Reactors/client/blob/BlobAppendHolderClientReactor.h

[services] Backup - Add append holder reactor
AbandonedPublic
Actions

Revision Contents
Changeset List