Page MenuHomePhabricator

[services] Backup - Add data exists flag to put client reactor
AbandonedPublic

Authored by karol on Apr 19 2022, 1:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 26, 7:43 AM
Unknown Object (File)
Sun, Oct 13, 3:06 PM
Unknown Object (File)
Sun, Oct 13, 3:06 PM
Unknown Object (File)
Sun, Oct 13, 3:06 PM
Unknown Object (File)
Sun, Oct 13, 2:58 PM
Unknown Object (File)
Sun, Oct 6, 10:39 AM
Unknown Object (File)
Sep 13 2024, 3:32 AM
Unknown Object (File)
Sep 3 2024, 10:47 AM

Details

Reviewers
tomek
Summary

Depends on D3774

We need to keep track of whether the data already exists on the cloud or not. We need this, because, in a case, it is already there, we want to just add a new holder to it without uploading the same bytes.

https://linear.app/comm/issue/ENG-672/create-addreferencetohashbyholder-in-the-blob-service

Test Plan
cd services
yarn run-backup-service

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

It would be great if you could find a test plan that does something more than checking if the code compiles

This revision is now accepted and ready to land.Apr 21 2022, 2:14 AM

This diff really needs a better test plan. By pushing @karol-bisztyga for a better test plan, we should be able to move away from the "make commit as if it is a personal project and diff whatever I come up with". Instead, each diff will need to be tested thoroughly, and @karol-bisztyga will be forced to have to wait until he is able to test a diff before putting it up. That will mean fewer "fix" diffs that only show up because the original diff was not properly tested.

I won't insist here, but in the future @palys-swm please request changes if the test plan for something new is just "make sure it compiles"

karol edited the summary of this revision. (Show Details)

update

This comment was removed by karol.