Page MenuHomePhabricator
Differential D3776

[services] Backup - Add append holder method to blob client
AbandonedPublic
Actions

Authored by • karol on Apr 19 2022, 1:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 1:50 AM
Unknown Object (File)
Wed, Apr 16, 11:35 PM
Unknown Object (File)
Wed, Apr 16, 6:45 AM
Unknown Object (File)
Tue, Apr 8, 5:17 PM
Unknown Object (File)
Sun, Apr 6, 2:30 PM
Unknown Object (File)
Sun, Apr 6, 2:26 PM
Unknown Object (File)
Sun, Apr 6, 2:23 PM
Unknown Object (File)
Sun, Mar 30, 9:18 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
Summary

Depends on D3775

Adding appendHolder to the blob client.

https://linear.app/comm/issue/ENG-672/create-addreferencetohashbyholder-in-the-blob-service

Test Plan
cd services
yarn run-backup-service

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Apr 19 2022, 1:57 AM
Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 19 2022, 1:57 AM
• karol edited the summary of this revision. (Show Details)Apr 19 2022, 2:20 AM
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D3775: [services] Backup - Add data exists flag to put client reactor.
• karol added a child revision: D3777: [services] Backup - Improve code style in create new backup reactor.
Harbormaster completed remote builds in B8298: Diff 11594.Apr 19 2022, 2:35 AM
• karol requested review of this revision.Apr 19 2022, 2:35 AM
tomek accepted this revision.Apr 21 2022, 2:18 AM
tomek added inline comments.
services/backup/docker-server/contents/server/src/grpc-client/ServiceBlobClient.h
58

Can we introduce start method to the reactor?

This revision is now accepted and ready to land.Apr 21 2022, 2:18 AM
• karol abandoned this revision.Apr 22 2022, 3:30 AM

This is a part of mistakenly added code, more details in https://phabricator.ashoat.com/D3772#105661.

Abandoning. Sorry for the inconvenience, thank you for the review.

Revision Contents
Changeset List

PathSize
services/
backup/
docker-server/
contents/
server/
src/
grpc-client/
11 lines

Diff 11594

View Options

services/backup/docker-server/contents/server/src/grpc-client/ServiceBlobClient.h

Loading...