[services] Backup - Apply reading user id in the reactors
ClosedPublic
Actions

Authored by • karol on Mar 29 2022, 11:38 AM.

Details

Reviewers

tomek
• max
varun
• jim

Commits

rCOMMe60ac3c8655c: [services] Backup - Apply reading user id in the reactors

Summary

Depends on D3530

In the previous diff, I added a user id for every request where it was missing. Now, we want to read it when creating a new backup and sending a log.

Test Plan

cd services
yarn run-backup-service

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Mar 29 2022, 11:38 AM

Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptMar 29 2022, 11:38 AM

• karol edited the summary of this revision. (Show Details)Mar 29 2022, 11:48 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max, varun, • jim.

• karol edited the summary of this revision. (Show Details)

• karol added a parent revision: D3530: [services] Backup - Fix requests in proto file.

• karol added a child revision: D3532: [services] Backup - Move Service Blob Client.

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 29 2022, 11:53 AM

Harbormaster failed remote builds in B7668: Diff 10764!

• karol requested review of this revision.Mar 29 2022, 11:55 AM

tomek requested changes to this revision.Mar 31 2022, 4:46 PM

tomek added inline comments.

services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h
38 ↗	(On Diff #10764)	This can be removed
48–54 ↗	(On Diff #10764)	This code should be introduced before this diff. Is it a mistake due to rebasing?

This revision now requires changes to proceed.Mar 31 2022, 4:46 PM

strip added code(adding it in the next diff), remove comment

• karol added inline comments.Apr 4 2022, 3:08 PM

services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h
38 ↗	(On Diff #10764)	right
48–54 ↗	(On Diff #10764)	Uhm, maybe... Added in D3612

• karol added a child revision: D3612: [services] Backup - Apply reading log chunk in send log reactor.Apr 4 2022, 3:09 PM

Harbormaster completed remote builds in B7839: Diff 11007.Apr 4 2022, 7:28 PM

tomek accepted this revision.Apr 5 2022, 4:20 PM

This revision is now accepted and ready to land.Apr 5 2022, 4:20 PM

Closed by commit rCOMMe60ac3c8655c: [services] Backup - Apply reading user id in the reactors. · Explain WhyApr 7 2022, 9:38 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMMe60ac3c8655c: [services] Backup - Apply reading user id in the reactors.

ashoat added inline comments.Apr 8 2022, 2:56 AM

services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h
67	I still find it weird that we have a separate trip for each field. I know we have a task out for this but would be great to prioritize it

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

Reactors/

server/

CreateNewBackupReactor.h

18 lines

SendLogReactor.h

22 lines

Diff 11147

View Options

services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h