Paths

Table of Contentst

-
services/backup/docker-server/contents/server/src/Reactors/
-
backup/
-
docker-server/
-
contents/
-
server/
-
src/
-
Reactors/
-
WriteReactorBase.h
-
server/base-reactors/
-
base-reactors/
-
ServerWriteReactorBase.h

[services] Backup - Add server reactor base classes - write reactor
ClosedPublic
Actions

Authored by • karol on Mar 24 2022, 1:50 AM.

Details

Reviewers

• max
• jim
varun
tomek

Commits

rCOMM07677675b257: [services] Backup - Add server reactor base classes - write reactor

Summary

Depends on D3512

This class is moved and renamed for a better folder structure.
As we need to add client reactors in order to be able to connect to the blob service, we need to distinguish server reactors from client reactors.

Test Plan

cd services
yarn run-backup-service

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Mar 24 2022, 1:50 AM

Herald added subscribers: • benschac, atul, • adrian and 2 others. · View Herald TranscriptMar 24 2022, 1:50 AM

Harbormaster completed remote builds in B7569: Diff 10640.Mar 24 2022, 1:58 AM

• karol requested review of this revision.Mar 24 2022, 1:58 AM

• karol planned changes to this revision.Mar 24 2022, 2:10 AM

• karol edited the summary of this revision. (Show Details)

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: • max, • jim, varun, tomek.

update

• karol added a child revision: D3465: [services] Backup - Add client reactor base classes - bidi reactor.Mar 24 2022, 2:13 AM

• karol edited the summary of this revision. (Show Details)Mar 24 2022, 2:29 AM

• karol added a parent revision: D3512: [services] Backup - Add server reactor base classes - read reactor.

Harbormaster completed remote builds in B7581: Diff 10652.Mar 24 2022, 2:40 AM

• karol retitled this revision from [services] Backup - Add server reactor base classes - write reactor to [draft] [services] Backup - Add server reactor base classes - write reactor.Mar 24 2022, 2:47 AM

• karol edited the summary of this revision. (Show Details)Mar 24 2022, 2:50 AM

tomek accepted this revision.Mar 24 2022, 5:32 AM

tomek added inline comments.

services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h
61 ↗	(On Diff #10652)	Why do we call directly `Finish` here while in `Read` reactor we have `terminate` method that sets the `status`. Why `status` is not needed in this reactor, or why it is needed in that reactor?

This revision is now accepted and ready to land.Mar 24 2022, 5:32 AM

• karol added inline comments.Mar 25 2022, 6:56 AM

services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h
61 ↗	(On Diff #10652)	you're right, I'm going to add `terminate` here for the consistency

add terminate

It is accepted as a draft so I removed the draft label and I'm requesting changes once again to keep the appropriate order of events.

• karol retitled this revision from [draft] [services] Backup - Add server reactor base classes - write reactor to [services] Backup - Add server reactor base classes - write reactor.Mar 25 2022, 6:59 AM

Harbormaster completed remote builds in B7602: Diff 10677.Mar 25 2022, 7:10 AM

tomek accepted this revision.Mar 28 2022, 9:39 AM

tomek added inline comments.

services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h
61–66 ↗	(On Diff #10677)	Could you explain what is the difference and purpose of `writeResponse` and `StartWrite`?
85–89 ↗	(On Diff #10677)	Do we need to wrap it with try-catch when `NextWrite` also uses try-catch internally?

This revision is now accepted and ready to land.Mar 28 2022, 9:39 AM

• karol added inline comments.Mar 29 2022, 12:08 AM

services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h
61–66 ↗	(On Diff #10677)	`StartWrite` is a method provided by the grpc in the `grpc::ServerWriteReactor` class. It tells the grpc to start writing a response to the client. `writeResponse` is a method introduced by me. Its purpose is to be implemented in derived classes so we can generate sequential responses that will be sent to the client in derived classes.
85–89 ↗	(On Diff #10677)	You're right, this is redundant

remove redundant try catch

Harbormaster completed remote builds in B7651: Diff 10746.Mar 29 2022, 12:49 AM

add status member

Harbormaster completed remote builds in B7662: Diff 10757.Mar 29 2022, 2:04 AM

Closed by commit rCOMM07677675b257: [services] Backup - Add server reactor base classes - write reactor (authored by • karol). · Explain WhyMar 31 2022, 7:19 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM07677675b257: [services] Backup - Add server reactor base classes - write reactor.

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

Reactors/

WriteReactorBase.h

server/

base-reactors/

ServerWriteReactorBase.h

91 lines

Diff 10889

View Options

services/backup/docker-server/contents/server/src/Reactors/WriteReactorBase.h

package app.comm.android;		package app.comm.android;

import android.app.NotificationManager;		import android.app.NotificationManager;
import android.content.Context;		import android.content.Context;
import android.service.notification.StatusBarNotification;		import android.service.notification.StatusBarNotification;
import android.util.Log;		import android.util.Log;
		import app.comm.android.fbjni.CommSecureStore;
import app.comm.android.fbjni.NetworkModule;		import app.comm.android.fbjni.NetworkModule;
		import app.comm.android.fbjni.ThreadOperations;
import com.google.firebase.messaging.RemoteMessage;		import com.google.firebase.messaging.RemoteMessage;
		import expo.modules.securestore.SecureStoreModule;
import io.invertase.firebase.messaging.RNFirebaseMessagingService;		import io.invertase.firebase.messaging.RNFirebaseMessagingService;
		import java.io.File;
import me.leolin.shortcutbadger.ShortcutBadger;		import me.leolin.shortcutbadger.ShortcutBadger;

/**		/**
* We're extending RNFirebaseMessagingService here instead of		* We're extending RNFirebaseMessagingService here instead of
* FirebaseMessagingService which is not ideal but let's us work around an		* FirebaseMessagingService which is not ideal but let's us work around an
* Android limitation. If there are a couple of FirebaseMessagingServices		* Android limitation. If there are a couple of FirebaseMessagingServices
* declared in manifest, only the first one would get all the notifications.		* declared in manifest, only the first one would get all the notifications.
* So we need to find a way to have only one service that implements this.		* So we need to find a way to have only one service that implements this.
Show All 17 Lines
* the easiest in terms of making it safe.		* the easiest in terms of making it safe.
*/		*/
public class CommNotificationsHandler extends RNFirebaseMessagingService {		public class CommNotificationsHandler extends RNFirebaseMessagingService {
private static final String RESCIND_KEY = "rescind";		private static final String RESCIND_KEY = "rescind";
private static final String RESCIND_ID_KEY = "rescindID";		private static final String RESCIND_ID_KEY = "rescindID";
private static final String BADGE_KEY = "badge";		private static final String BADGE_KEY = "badge";
private static final String BADGE_ONLY_KEY = "badgeOnly";		private static final String BADGE_ONLY_KEY = "badgeOnly";
private static final String BACKGROUND_NOTIF_TYPE_KEY = "backgroundNotifType";		private static final String BACKGROUND_NOTIF_TYPE_KEY = "backgroundNotifType";
		private static final String THREAD_ID_KEY = "threadID";
		private static final String SET_UNREAD_STATUS_KEY = "setUnreadStatus";
private NotificationManager notificationManager;		private NotificationManager notificationManager;

@Override		@Override
public void onCreate() {		public void onCreate() {
super.onCreate();		super.onCreate();
		CommSecureStore.getInstance().initialize(
		() -> new SecureStoreModule(this.getApplicationContext()));
notificationManager = (NotificationManager)this.getSystemService(		notificationManager = (NotificationManager)this.getSystemService(
Context.NOTIFICATION_SERVICE);		Context.NOTIFICATION_SERVICE);
}		}

@Override		@Override
public void onMessageReceived(RemoteMessage message) {		public void onMessageReceived(RemoteMessage message) {
String rescind = message.getData().get(RESCIND_KEY);		String rescind = message.getData().get(RESCIND_KEY);
String rescindID = message.getData().get(RESCIND_ID_KEY);
if ("true".equals(rescind) &&		if ("true".equals(rescind) &&
android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.M) {		android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.M) {
for (StatusBarNotification notification :		handleNotificationRescind(message);
notificationManager.getActiveNotifications()) {
if (notification.getTag().equals(rescindID)) {
notificationManager.cancel(
notification.getTag(), notification.getId());
}
}
}		}

String badge = message.getData().get(BADGE_KEY);		String badge = message.getData().get(BADGE_KEY);
if (badge != null) {		if (badge != null) {
try {		try {
int badgeCount = Integer.parseInt(badge);		int badgeCount = Integer.parseInt(badge);
if (badgeCount > 0) {		if (badgeCount > 0) {
ShortcutBadger.applyCount(this, badgeCount);		ShortcutBadger.applyCount(this, badgeCount);
Show All 14 Lines	String backgroundNotifType =
message.getData().get(BACKGROUND_NOTIF_TYPE_KEY);		message.getData().get(BACKGROUND_NOTIF_TYPE_KEY);
if ("PING".equals(backgroundNotifType)) {		if ("PING".equals(backgroundNotifType)) {
NetworkModule.sendPong();		NetworkModule.sendPong();
return;		return;
}		}

super.onMessageReceived(message);		super.onMessageReceived(message);
}		}

		private void handleNotificationRescind(RemoteMessage message) {
		String setUnreadStatus = message.getData().get(SET_UNREAD_STATUS_KEY);
		if ("true".equals(setUnreadStatus)) {
		File sqliteFile =
		this.getApplicationContext().getDatabasePath("comm.sqlite");
		if (sqliteFile.exists()) {
		String threadID = message.getData().get(THREAD_ID_KEY);
		ThreadOperations.updateSQLiteUnreadStatus(
		sqliteFile.getPath(), threadID, false);
		} else {
		Log.w(
		"COMM",
		"Database not existing yet. Skipping thread status update.");
		}
		}
		String rescindID = message.getData().get(RESCIND_ID_KEY);
		for (StatusBarNotification notification :
		notificationManager.getActiveNotifications()) {
		if (notification.getTag().equals(rescindID)) {
		notificationManager.cancel(notification.getTag(), notification.getId());
		}
		}
		}
}		}