Page MenuHomePhabricator
Differential D3779

[services] Backup - Fix: add missing pragma once to headers
ClosedPublic
Actions

Authored by • karol on Apr 19 2022, 5:11 AM.
Tags
None
Referenced Files
F5906341: D3779.id.diff
Thu, Apr 17, 2:13 PM
F5897438: D3779.id11784.diff
Thu, Apr 17, 11:25 AM
F5886464: D3779.id11600.diff
Thu, Apr 17, 4:10 AM
Unknown Object (File)
Wed, Apr 16, 6:59 PM
Unknown Object (File)
Tue, Apr 15, 10:06 PM
Unknown Object (File)
Tue, Apr 8, 6:22 PM
Unknown Object (File)
Tue, Apr 8, 5:34 PM
Unknown Object (File)
Tue, Apr 8, 7:24 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
ashoat
Commits
rCOMM47ffd8e524ed: [services] Backup - Fix: add missing pragma once to headers
Summary

Depends on D3485

This is more like a best practice, but it's pretty important and may lead to unpleasant errors

Test Plan
cd services
yarn run-backup-service

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Apr 19 2022, 5:11 AM
Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 19 2022, 5:11 AM
• karol edited the summary of this revision. (Show Details)Apr 19 2022, 5:12 AM
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D3485: [services] Backup - Remove backup base Docker image.
• karol added a child revision: D3780: [services] Backup - Move reactors' implementations to source files.
Harbormaster completed remote builds in B8304: Diff 11600.Apr 19 2022, 5:18 AM
• karol requested review of this revision.Apr 19 2022, 5:18 AM
ashoat accepted this revision.Apr 19 2022, 11:48 AM
This revision is now accepted and ready to land.Apr 19 2022, 11:48 AM
tomek accepted this revision.Apr 21 2022, 9:16 AM

It would be great if we had a tool that would force us to start every header file with this directive

• karol updated this revision to Diff 11784.Apr 22 2022, 3:44 AM

rebase

• karol added a comment.Apr 22 2022, 3:45 AM

Yes, kind of a shame we all missed that.

Harbormaster completed remote builds in B8445: Diff 11784.Apr 22 2022, 4:01 AM
Closed by commit rCOMM47ffd8e524ed: [services] Backup - Fix: add missing pragma once to headers (authored by • karol). · Explain WhyApr 27 2022, 2:38 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM47ffd8e524ed: [services] Backup - Fix: add missing pragma once to headers.

Revision Contents
Changeset List

PathSize
services/
backup/
src/
Reactors/
client/
base-reactors/
2 lines
2 lines
2 lines

Diff 11973

View Options

services/backup/src/Reactors/client/base-reactors/ClientBidiReactorBase.h

#include <grpcpp/grpcpp.h> #include <grpcpp/grpcpp.h>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
template <class Request, class Response> template <class Request, class Response>
class ClientWriteReactorBase : public grpc::ClientWriteReactor<Request> { class ClientWriteReactorBase : public grpc::ClientWriteReactor<Request> {
grpc::Status status; grpc::Status status = grpc::Status::OK;
bool done = false; bool done = false;
bool initialized = 0; bool initialized = 0;
Request request; Request request;
public: public:
Response response; Response response;
grpc::ClientContext context; grpc::ClientContext context;
void nextWrite(); void nextWrite();
void OnWriteDone(bool ok) override; void OnWriteDone(bool ok) override;
void terminate(const grpc::Status &status); void terminate(const grpc::Status &status);
bool isDone(); bool isDone();
void OnDone(const grpc::Status &status) override; void OnDone(const grpc::Status &status) override;
virtual std::unique_ptr<grpc::Status> prepareRequest(Request &request) = 0; virtual std::unique_ptr<grpc::Status> prepareRequest(Request &request) = 0;
virtual void validate(){};
virtual void doneCallback(){}; virtual void doneCallback(){};
virtual void terminateCallback(){}; virtual void terminateCallback(){};
}; };
template <class Request, class Response> template <class Request, class Response>
void ClientWriteReactorBase<Request, Response>::nextWrite() { void ClientWriteReactorBase<Request, Response>::nextWrite() {
this->request = Request(); this->request = Request();
std::unique_ptr<grpc::Status> status = this->prepareRequest(this->request); std::unique_ptr<grpc::Status> status = this->prepareRequest(this->request);
Show All 15 Lines if (!ok) {
return; return;
} }
this->nextWrite(); this->nextWrite();
} }
template <class Request, class Response> template <class Request, class Response>
void ClientWriteReactorBase<Request, Response>::terminate( void ClientWriteReactorBase<Request, Response>::terminate(
const grpc::Status &status) { const grpc::Status &status) {
this->terminateCallback(); if (this->status.ok()) {
if (this->done) { this->status = status;
return;
} }
if (!this->status.ok()) { if (!this->status.ok()) {
std::cout << "error: " << this->status.error_message() << std::endl; std::cout << "error: " << this->status.error_message() << std::endl;
} }
this->status = status; if (this->done) {
return;
}
this->terminateCallback();
try {
this->validate();
} catch (std::runtime_error &e) {
this->status = grpc::Status(grpc::StatusCode::INTERNAL, e.what());
}
this->done = true; this->done = true;
this->StartWritesDone(); this->StartWritesDone();
} }
template <class Request, class Response> template <class Request, class Response>
bool ClientWriteReactorBase<Request, Response>::isDone() { bool ClientWriteReactorBase<Request, Response>::isDone() {
return this->done; return this->done;
} }
Show All 11 Lines
View Options

services/backup/src/Reactors/client/base-reactors/ClientReadReactorBase.h

#include <grpcpp/grpcpp.h> #include <grpcpp/grpcpp.h>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
template <class Request, class Response> template <class Request, class Response>
class ClientWriteReactorBase : public grpc::ClientWriteReactor<Request> { class ClientWriteReactorBase : public grpc::ClientWriteReactor<Request> {
grpc::Status status; grpc::Status status = grpc::Status::OK;
bool done = false; bool done = false;
bool initialized = 0; bool initialized = 0;
Request request; Request request;
public: public:
Response response; Response response;
grpc::ClientContext context; grpc::ClientContext context;
void nextWrite(); void nextWrite();
void OnWriteDone(bool ok) override; void OnWriteDone(bool ok) override;
void terminate(const grpc::Status &status); void terminate(const grpc::Status &status);
bool isDone(); bool isDone();
void OnDone(const grpc::Status &status) override; void OnDone(const grpc::Status &status) override;
virtual std::unique_ptr<grpc::Status> prepareRequest(Request &request) = 0; virtual std::unique_ptr<grpc::Status> prepareRequest(Request &request) = 0;
virtual void validate(){};
virtual void doneCallback(){}; virtual void doneCallback(){};
virtual void terminateCallback(){}; virtual void terminateCallback(){};
}; };
template <class Request, class Response> template <class Request, class Response>
void ClientWriteReactorBase<Request, Response>::nextWrite() { void ClientWriteReactorBase<Request, Response>::nextWrite() {
this->request = Request(); this->request = Request();
std::unique_ptr<grpc::Status> status = this->prepareRequest(this->request); std::unique_ptr<grpc::Status> status = this->prepareRequest(this->request);
Show All 15 Lines if (!ok) {
return; return;
} }
this->nextWrite(); this->nextWrite();
} }
template <class Request, class Response> template <class Request, class Response>
void ClientWriteReactorBase<Request, Response>::terminate( void ClientWriteReactorBase<Request, Response>::terminate(
const grpc::Status &status) { const grpc::Status &status) {
this->terminateCallback(); if (this->status.ok()) {
if (this->done) { this->status = status;
return;
} }
if (!this->status.ok()) { if (!this->status.ok()) {
std::cout << "error: " << this->status.error_message() << std::endl; std::cout << "error: " << this->status.error_message() << std::endl;
} }
this->status = status; if (this->done) {
return;
}
this->terminateCallback();
try {
this->validate();
} catch (std::runtime_error &e) {
this->status = grpc::Status(grpc::StatusCode::INTERNAL, e.what());
}
this->done = true; this->done = true;
this->StartWritesDone(); this->StartWritesDone();
} }
template <class Request, class Response> template <class Request, class Response>
bool ClientWriteReactorBase<Request, Response>::isDone() { bool ClientWriteReactorBase<Request, Response>::isDone() {
return this->done; return this->done;
} }
Show All 11 Lines
View Options

services/backup/src/Reactors/client/base-reactors/ClientWriteReactorBase.h

#include <grpcpp/grpcpp.h> #include <grpcpp/grpcpp.h>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
template <class Request, class Response> template <class Request, class Response>
class ClientWriteReactorBase : public grpc::ClientWriteReactor<Request> { class ClientWriteReactorBase : public grpc::ClientWriteReactor<Request> {
grpc::Status status; grpc::Status status = grpc::Status::OK;
bool done = false; bool done = false;
bool initialized = 0; bool initialized = 0;
Request request; Request request;
public: public:
Response response; Response response;
grpc::ClientContext context; grpc::ClientContext context;
void nextWrite(); void nextWrite();
void OnWriteDone(bool ok) override; void OnWriteDone(bool ok) override;
void terminate(const grpc::Status &status); void terminate(const grpc::Status &status);
bool isDone(); bool isDone();
void OnDone(const grpc::Status &status) override; void OnDone(const grpc::Status &status) override;
virtual std::unique_ptr<grpc::Status> prepareRequest(Request &request) = 0; virtual std::unique_ptr<grpc::Status> prepareRequest(Request &request) = 0;
virtual void validate(){};
virtual void doneCallback(){}; virtual void doneCallback(){};
virtual void terminateCallback(){}; virtual void terminateCallback(){};
}; };
template <class Request, class Response> template <class Request, class Response>
void ClientWriteReactorBase<Request, Response>::nextWrite() { void ClientWriteReactorBase<Request, Response>::nextWrite() {
this->request = Request(); this->request = Request();
std::unique_ptr<grpc::Status> status = this->prepareRequest(this->request); std::unique_ptr<grpc::Status> status = this->prepareRequest(this->request);
Show All 15 Lines if (!ok) {
return; return;
} }
this->nextWrite(); this->nextWrite();
} }
template <class Request, class Response> template <class Request, class Response>
void ClientWriteReactorBase<Request, Response>::terminate( void ClientWriteReactorBase<Request, Response>::terminate(
const grpc::Status &status) { const grpc::Status &status) {
this->terminateCallback(); if (this->status.ok()) {
if (this->done) { this->status = status;
return;
} }
if (!this->status.ok()) { if (!this->status.ok()) {
std::cout << "error: " << this->status.error_message() << std::endl; std::cout << "error: " << this->status.error_message() << std::endl;
} }
this->status = status; if (this->done) {
return;
}
this->terminateCallback();
try {
this->validate();
} catch (std::runtime_error &e) {
this->status = grpc::Status(grpc::StatusCode::INTERNAL, e.what());
}
this->done = true; this->done = true;
this->StartWritesDone(); this->StartWritesDone();
} }
template <class Request, class Response> template <class Request, class Response>
bool ClientWriteReactorBase<Request, Response>::isDone() { bool ClientWriteReactorBase<Request, Response>::isDone() {
return this->done; return this->done;
} }
Show All 11 Lines