Page MenuHomePhabricator
Differential D3802

[services] Fix clang paths
AbandonedPublic
Actions

Authored by • karol on Apr 21 2022, 12:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 8, 4:32 PM
Unknown Object (File)
Sun, Apr 6, 8:20 PM
Unknown Object (File)
Sun, Apr 6, 8:16 PM
Unknown Object (File)
Sun, Apr 6, 8:13 PM
Unknown Object (File)
Sun, Apr 6, 8:09 PM
Unknown Object (File)
Sun, Apr 6, 8:06 PM
Unknown Object (File)
Mon, Mar 31, 1:11 PM
Unknown Object (File)
Thu, Mar 20, 4:39 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
ashoat
Summary

https://linear.app/comm/issue/ENG-915/services-fix-clang-paths

Fixing clang paths that are broken because of the directory refactoring

Test Plan
yarn clang-format-all

Diff Detail

Repository
rCOMM Comm
Branch
new-backup-blob
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Apr 21 2022, 12:16 AM
Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 21 2022, 12:16 AM
• karol edited the summary of this revision. (Show Details)Apr 21 2022, 12:18 AM
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D3801: [services] Blob - synchronize status access in reactors.
Harbormaster completed remote builds in B8384: Diff 11696.Apr 21 2022, 12:22 AM
• karol requested review of this revision.Apr 21 2022, 12:22 AM
• karol mentioned this in D3738: [services] Backup/Blob - Pull backup logic fixes.Apr 21 2022, 12:22 AM
ashoat accepted this revision.Apr 21 2022, 10:21 AM
This revision is now accepted and ready to land.Apr 21 2022, 10:21 AM
• karol mentioned this in D3485: [services] Backup - Remove backup base Docker image.Apr 22 2022, 3:43 AM
• karol updated this revision to Diff 11794.Apr 22 2022, 5:22 AM

rebase

• karol added a child revision: D3814: [services] Blob - Add holder to the blob DB if data exists.Apr 22 2022, 5:27 AM
Harbormaster completed remote builds in B8455: Diff 11794.Apr 22 2022, 5:30 AM
• karol updated this revision to Diff 12034.Apr 28 2022, 6:16 AM

making this diff standalone

• karol edited the summary of this revision. (Show Details)Apr 28 2022, 6:17 AM
• karol abandoned this revision.Apr 28 2022, 6:19 AM

I want to land this as a standalone change that doesn't depend on anything else.

• karol added a comment.Apr 28 2022, 6:20 AM

New diff D3873

Harbormaster completed remote builds in B8643: Diff 12034.Apr 28 2022, 6:21 AM

Revision Contents
Changeset List

PathSize
native/
android/
app/
src/
main/
java/
app/
comm/
android/
fbjni/
4 lines
scripts/
12 lines
services/
blob/
src/
Reactors/
server/
base-reactors/
2 lines
2 lines
tunnelbroker/
src/
3 lines
test/
3 lines

Diff 12034

View Options

native/android/app/src/main/java/app/comm/android/fbjni/NetworkModule.java

  • This file was copied from services/backup/src/Reactors/client/blob/BlobGetClientReactor.h.
#pragma once
#include "ClientReadReactorBase.h" #include "BlobGetClientReactor.h"
#include "../_generated/blob.grpc.pb.h"
#include "../_generated/blob.pb.h"
#include <folly/MPMCQueue.h>
#include <grpcpp/grpcpp.h>
#include <memory>
#include <string>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
class BlobGetClientReactor
: public ClientReadReactorBase<blob::GetRequest, blob::GetResponse> {
std::string holder;
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks;
public:
BlobGetClientReactor(
const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks);
std::unique_ptr<grpc::Status>
readResponse(blob::GetResponse &response) override;
void doneCallback() override;
grpc::Status getStatus() const;
};
BlobGetClientReactor::BlobGetClientReactor( BlobGetClientReactor::BlobGetClientReactor(
const std::string &holder, const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks) std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks)
: holder(holder), dataChunks(dataChunks) { : holder(holder), dataChunks(dataChunks) {
} }
std::unique_ptr<grpc::Status> std::unique_ptr<grpc::Status>
BlobGetClientReactor::readResponse(blob::GetResponse &response) { BlobGetClientReactor::readResponse(blob::GetResponse &response) {
Show All 17 Lines
View Options

scripts/get_clang_paths.js

  • This file was copied from services/backup/src/Reactors/client/blob/BlobGetClientReactor.h.
#pragma once
#include "ClientReadReactorBase.h" #include "BlobGetClientReactor.h"
#include "../_generated/blob.grpc.pb.h"
#include "../_generated/blob.pb.h"
#include <folly/MPMCQueue.h>
#include <grpcpp/grpcpp.h>
#include <memory>
#include <string>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
class BlobGetClientReactor
: public ClientReadReactorBase<blob::GetRequest, blob::GetResponse> {
std::string holder;
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks;
public:
BlobGetClientReactor(
const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks);
std::unique_ptr<grpc::Status>
readResponse(blob::GetResponse &response) override;
void doneCallback() override;
grpc::Status getStatus() const;
};
BlobGetClientReactor::BlobGetClientReactor( BlobGetClientReactor::BlobGetClientReactor(
const std::string &holder, const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks) std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks)
: holder(holder), dataChunks(dataChunks) { : holder(holder), dataChunks(dataChunks) {
} }
std::unique_ptr<grpc::Status> std::unique_ptr<grpc::Status>
BlobGetClientReactor::readResponse(blob::GetResponse &response) { BlobGetClientReactor::readResponse(blob::GetResponse &response) {
Show All 17 Lines
View Options

services/blob/src/Reactors/server/base-reactors/ServerBidiReactorBase.h

  • This file was copied from services/backup/src/Reactors/client/blob/BlobGetClientReactor.h.
#pragma once
#include "ClientReadReactorBase.h" #include "BlobGetClientReactor.h"
#include "../_generated/blob.grpc.pb.h"
#include "../_generated/blob.pb.h"
#include <folly/MPMCQueue.h>
#include <grpcpp/grpcpp.h>
#include <memory>
#include <string>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
class BlobGetClientReactor
: public ClientReadReactorBase<blob::GetRequest, blob::GetResponse> {
std::string holder;
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks;
public:
BlobGetClientReactor(
const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks);
std::unique_ptr<grpc::Status>
readResponse(blob::GetResponse &response) override;
void doneCallback() override;
grpc::Status getStatus() const;
};
BlobGetClientReactor::BlobGetClientReactor( BlobGetClientReactor::BlobGetClientReactor(
const std::string &holder, const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks) std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks)
: holder(holder), dataChunks(dataChunks) { : holder(holder), dataChunks(dataChunks) {
} }
std::unique_ptr<grpc::Status> std::unique_ptr<grpc::Status>
BlobGetClientReactor::readResponse(blob::GetResponse &response) { BlobGetClientReactor::readResponse(blob::GetResponse &response) {
Show All 17 Lines
View Options

services/blob/src/Reactors/server/base-reactors/ServerReadReactorBase.h

  • This file was copied from services/backup/src/Reactors/client/blob/BlobGetClientReactor.h.
#pragma once
#include "ClientReadReactorBase.h" #include "BlobGetClientReactor.h"
#include "../_generated/blob.grpc.pb.h"
#include "../_generated/blob.pb.h"
#include <folly/MPMCQueue.h>
#include <grpcpp/grpcpp.h>
#include <memory>
#include <string>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
class BlobGetClientReactor
: public ClientReadReactorBase<blob::GetRequest, blob::GetResponse> {
std::string holder;
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks;
public:
BlobGetClientReactor(
const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks);
std::unique_ptr<grpc::Status>
readResponse(blob::GetResponse &response) override;
void doneCallback() override;
grpc::Status getStatus() const;
};
BlobGetClientReactor::BlobGetClientReactor( BlobGetClientReactor::BlobGetClientReactor(
const std::string &holder, const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks) std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks)
: holder(holder), dataChunks(dataChunks) { : holder(holder), dataChunks(dataChunks) {
} }
std::unique_ptr<grpc::Status> std::unique_ptr<grpc::Status>
BlobGetClientReactor::readResponse(blob::GetResponse &response) { BlobGetClientReactor::readResponse(blob::GetResponse &response) {
Show All 17 Lines
View Options

services/tunnelbroker/src/Constants.h

Loading...
View Options

services/tunnelbroker/test/TunnelBrokerTest.cpp

Loading...