[services] Fix clang paths
AbandonedPublic
Actions

Authored by • karol on Apr 21 2022, 7:16 AM.

Details

Reviewers

tomek
ashoat

Summary

https://linear.app/comm/issue/ENG-915/services-fix-clang-paths

Fixing clang paths that are broken because of the directory refactoring

Test Plan

yarn clang-format-all

Diff Detail

Repository

rCOMM Comm

Branch

new-backup-blob

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Apr 21 2022, 7:16 AM

Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 21 2022, 7:16 AM

• karol edited the summary of this revision. (Show Details)Apr 21 2022, 7:18 AM

• karol edited the test plan for this revision. (Show Details)

• karol added a reviewer: tomek.

• karol added a parent revision: D3801: [services] Blob - synchronize status access in reactors.

Harbormaster completed remote builds in B8384: Diff 11696.Apr 21 2022, 7:22 AM

• karol requested review of this revision.Apr 21 2022, 7:22 AM

• karol mentioned this in D3738: [services] Backup/Blob - Pull backup logic fixes.Apr 21 2022, 7:22 AM

ashoat accepted this revision.Apr 21 2022, 5:21 PM

This revision is now accepted and ready to land.Apr 21 2022, 5:21 PM

• karol mentioned this in D3485: [services] Backup - Remove backup base Docker image.Apr 22 2022, 10:43 AM

rebase

• karol added a child revision: D3814: [services] Blob - Add holder to the blob DB if data exists.Apr 22 2022, 12:27 PM

Harbormaster completed remote builds in B8455: Diff 11794.Apr 22 2022, 12:30 PM

making this diff standalone

• karol edited the summary of this revision. (Show Details)Apr 28 2022, 1:17 PM

I want to land this as a standalone change that doesn't depend on anything else.

New diff D3873

Harbormaster completed remote builds in B8643: Diff 12034.Apr 28 2022, 1:21 PM

Revision Contents
Changeset List

Path

Size

native/

android/

app/

src/

main/

java/

app/

comm/

android/

fbjni/

NetworkModule.java

4 lines

scripts/

get_clang_paths.js

12 lines

services/

blob/

src/

Reactors/

server/

base-reactors/

ServerBidiReactorBase.h

2 lines

ServerReadReactorBase.h

2 lines

tunnelbroker/

src/

Constants.h

3 lines

test/

TunnelBrokerTest.cpp

3 lines

Diff 12034

View Options

native/android/app/src/main/java/app/comm/android/fbjni/NetworkModule.java

View Options

scripts/get_clang_paths.js

View Options

services/blob/src/Reactors/server/base-reactors/ServerBidiReactorBase.h

View Options

services/blob/src/Reactors/server/base-reactors/ServerReadReactorBase.h

View Options

services/tunnelbroker/src/Constants.h

View Options

services/tunnelbroker/test/TunnelBrokerTest.cpp

[services] Fix clang pathsAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 12034

native/android/app/src/main/java/app/comm/android/fbjni/NetworkModule.java

scripts/get_clang_paths.js

services/blob/src/Reactors/server/base-reactors/ServerBidiReactorBase.h

services/blob/src/Reactors/server/base-reactors/ServerReadReactorBase.h

services/tunnelbroker/src/Constants.h

services/tunnelbroker/test/TunnelBrokerTest.cpp

[services] Fix clang paths
AbandonedPublic
Actions

Revision Contents
Changeset List