Differential D3635

[services] Backup - Log item - handle lack of attachment holders
ClosedPublic
Actions

Authored by • karol on Apr 6 2022, 7:39 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Mar 17, 4:06 PM

	Unknown Object (File)
	Thu, Mar 13, 9:13 AM

	Unknown Object (File)
	Sat, Mar 8, 11:44 PM

	Unknown Object (File)
	Sat, Mar 8, 3:32 PM

	Unknown Object (File)
	Sat, Mar 8, 3:32 PM

	Unknown Object (File)
	Sat, Mar 8, 3:32 PM

	Unknown Object (File)
	Sat, Mar 8, 3:30 PM

	Unknown Object (File)
	Fri, Feb 21, 8:39 PM

Subscribers

Details

Reviewers

tomek
• max

Commits

rCOMM797df3207b7f: [services] Backup - Log item - handle lack of attachment holders

Summary

Depends on D3634

Handle a case when the log item does not have attachment holders.

Test Plan

The same as in D3535

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Apr 6 2022, 7:39 AM

Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 6 2022, 7:39 AM

• karol edited the summary of this revision. (Show Details)Apr 6 2022, 7:59 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max.

• karol added a parent revision: D3634: [services] Backup - pull backup reactor - compaction - write response.

• karol added a child revision: D3636: [services] Backup - pull backup reactor - logs - write response.

Harbormaster completed remote builds in B7927: Diff 11109.Apr 6 2022, 8:55 AM

• karol requested review of this revision.Apr 6 2022, 8:55 AM

tomek accepted this revision.Apr 13 2022, 3:17 AM

This revision is now accepted and ready to land.Apr 13 2022, 3:17 AM

Closed by commit rCOMM797df3207b7f: [services] Backup - Log item - handle lack of attachment holders (authored by • karol). · Explain WhyApr 13 2022, 5:22 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM797df3207b7f: [services] Backup - Log item - handle lack of attachment holders.

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

DatabaseEntities/

7 lines

Diff 11412

services/backup/docker-server/contents/server/src/DatabaseEntities/LogItem.cpp

	Show All 31 Lines

	const exactSearchUserLoadingStatusSelector = createLoadingStatusSelector(			const exactSearchUserLoadingStatusSelector = createLoadingStatusSelector(
	exactSearchUserActionTypes,			exactSearchUserActionTypes,
	);			);

	export type UsernameSelectionParams = {			export type UsernameSelectionParams = {
	+userSelections: {			+userSelections: {
	+coolOrNerdMode: CoolOrNerdMode,			+coolOrNerdMode: CoolOrNerdMode,
	+keyserverUsername: string,			+keyserverURL: string,
	},			},
	};			};

	type UsernameError = 'username_invalid' \| 'username_taken';			type UsernameError = 'username_invalid' \| 'username_taken';

	type Props = {			type Props = {
	+navigation: RegistrationNavigationProp<'UsernameSelection'>,			+navigation: RegistrationNavigationProp<'UsernameSelection'>,
	+route: NavigationRoute<'UsernameSelection'>,			+route: NavigationRoute<'UsernameSelection'>,
	▲ Show 20 Lines • Show All 167 Lines • Show Last 20 Lines