Differential D3635

[services] Backup - Log item - handle lack of attachment holders
ClosedPublic
Actions

Authored by • karol on Apr 6 2022, 7:39 AM.

Tags

None

Referenced Files

	F5893423: D3635.id.diff
	Thu, Apr 17, 9:14 AM

	Unknown Object (File)
	Thu, Apr 17, 5:56 AM

	Unknown Object (File)
	Thu, Apr 17, 5:05 AM

	Unknown Object (File)
	Wed, Apr 16, 8:15 AM

	Unknown Object (File)
	Tue, Apr 8, 6:16 PM

	Unknown Object (File)
	Tue, Apr 8, 4:32 PM

	Unknown Object (File)
	Tue, Apr 8, 7:17 AM

	Unknown Object (File)
	Tue, Apr 8, 3:48 AM

Subscribers

Details

Reviewers

tomek
• max

Commits

rCOMM797df3207b7f: [services] Backup - Log item - handle lack of attachment holders

Summary

Depends on D3634

Handle a case when the log item does not have attachment holders.

Test Plan

The same as in D3535

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Apr 6 2022, 7:39 AM

Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 6 2022, 7:39 AM

• karol edited the summary of this revision. (Show Details)Apr 6 2022, 7:59 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max.

• karol added a parent revision: D3634: [services] Backup - pull backup reactor - compaction - write response.

• karol added a child revision: D3636: [services] Backup - pull backup reactor - logs - write response.

Harbormaster completed remote builds in B7927: Diff 11109.Apr 6 2022, 8:55 AM

• karol requested review of this revision.Apr 6 2022, 8:55 AM

tomek accepted this revision.Apr 13 2022, 3:17 AM

This revision is now accepted and ready to land.Apr 13 2022, 3:17 AM

Closed by commit rCOMM797df3207b7f: [services] Backup - Log item - handle lack of attachment holders (authored by • karol). · Explain WhyApr 13 2022, 5:22 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM797df3207b7f: [services] Backup - Log item - handle lack of attachment holders.

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

DatabaseEntities/

7 lines

Diff 11412

services/backup/docker-server/contents/server/src/DatabaseEntities/LogItem.cpp

This file was added.

				FROM commapp/services-base:1.1

				RUN apt-get update && \
				apt-get install -y uuid-dev && \
				rm -rf /var/lib/apt/lists/*

				ARG COMM_TEST_SERVICES
				ARG COMM_SERVICES_DEV_MODE

				ENV COMM_TEST_SERVICES=${COMM_TEST_SERVICES}
				ENV COMM_SERVICES_DEV_MODE=${COMM_SERVICES_DEV_MODE}

				WORKDIR /transferred

				COPY native/cpp/CommonCpp/grpc/protos/backup.proto native/cpp/CommonCpp/grpc/protos/blob.proto protos/
				COPY services/backup/docker/ scripts/
				COPY services/backup/ .

				RUN scripts/build_server.sh

				CMD if [ "$COMM_TEST_SERVICES" -eq 1 ]; then scripts/run_tests.sh; else scripts/run_server.sh; fi