Differential D3789 Authored by • karol on Apr 20 2022, 11:01 AM.
Details Summary Depends on D3788 https://linear.app/comm/issue/ENG-916/consider-pulling-more-mutual-code-from-the-async-reactors Applying inheriting the BaseRactor in the server reactors Test Plan cd services yarn run-blob-service
Diff Detail
Event TimelineHerald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 20 2022, 11:01 AM2022-04-20 11:01:34 (UTC+0) • karol edited the summary of this revision. (Show Details)Apr 20 2022, 11:04 AM2022-04-20 11:04:18 (UTC+0) Harbormaster completed remote builds in B8349: Diff 11659.Apr 20 2022, 11:08 AM2022-04-20 11:08:20 (UTC+0) • karol edited the summary of this revision. (Show Details)Apr 20 2022, 11:21 AM2022-04-20 11:21:33 (UTC+0) • karol added a parent revision: D3788: [services] Blob - Pull more mutual code from base reactors - Add base reactor. This revision now requires changes to proceed.Apr 21 2022, 2:56 AM2022-04-21 02:56:44 (UTC+0) Comment Actions This is similar to D3787 but it seems there are some differences so I'm not tagging it as a copy Comment Actions
planned changes because of this Harbormaster completed remote builds in B8451: Diff 11790.Apr 22 2022, 12:22 PM2022-04-22 12:22:19 (UTC+0) Harbormaster completed remote builds in B8651: Diff 12042.Apr 28 2022, 2:18 PM2022-04-28 14:18:19 (UTC+0) This revision is now accepted and ready to land.Apr 28 2022, 6:55 PM2022-04-28 18:55:16 (UTC+0) Closed by commit rCOMMa6a831ba7920: [services] Blob - Pull more mutual code from base reactors - Apply in server…. · Explain WhyMay 5 2022, 8:47 AM2022-05-05 08:47:50 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 12265 |