• karol retitled this revision from [services] Blob - Add server base reactor classes - read reactor to [draft] [services] Blob - Add server base reactor classes - read reactor.Mar 24 2022, 2:47 AM

• karol edited the summary of this revision. (Show Details)Mar 24 2022, 2:57 AM

Accepting as this is just a copy

This revision is now accepted and ready to land.Mar 24 2022, 8:27 AM

Is the intention to later modify ServerReadReactorBase.h, so it's no longer a copy? I figured that was the plan, but I couldn't find any later diff in the stack that modifies it. If it's meant to be the exact same file in the long-term, then it would be great to avoid copy-pasting and find some way to share the code.

rebase to master

Harbormaster completed remote builds in B7611: Diff 10687.Mar 25 2022, 8:24 AM

It is accepted as a draft so I removed the draft label and I'm requesting changes once again to keep the appropriate order of events.

In D3519#95714, @ashoat wrote:

Is the intention to later modify ServerReadReactorBase.h, so it's no longer a copy? I figured that was the plan, but I couldn't find any later diff in the stack that modifies it. If it's meant to be the exact same file in the long-term, then it would be great to avoid copy-pasting and find some way to share the code.

We can always prioritize https://linear.app/comm/issue/ENG-324/avoid-repetitions-in-services-code

• karol retitled this revision from [draft] [services] Blob - Add server base reactor classes - read reactor to [services] Blob - Add server base reactor classes - read reactor.Mar 25 2022, 8:31 AM

tomek accepted this revision.Mar 30 2022, 4:06 AM

This revision is now accepted and ready to land.Mar 30 2022, 4:06 AM

Closed by commit rCOMMa0c8cd9cb137: [services] Blob - Add server base reactor classes - read reactor (authored by • karol). · Explain WhyMar 31 2022, 11:41 PM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMMa0c8cd9cb137: [services] Blob - Add server base reactor classes - read reactor.