Page MenuHomePhabricator

[services] Backup - Add server reactor implementations - recover backup key reactor
ClosedPublic

Authored by karol on Mar 24 2022, 1:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 27, 4:02 AM
Unknown Object (File)
Wed, Oct 16, 3:46 PM
Unknown Object (File)
Sun, Oct 13, 6:46 PM
Unknown Object (File)
Sun, Oct 13, 6:46 PM
Unknown Object (File)
Sun, Oct 13, 6:46 PM
Unknown Object (File)
Sun, Oct 13, 6:46 PM
Unknown Object (File)
Sun, Oct 13, 6:46 PM
Unknown Object (File)
Sun, Oct 13, 6:46 PM

Details

Summary

Depends on D3516

Add implementation for the recover backup key reactor

Test Plan
cd services
yarn run-backup-service

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

karol retitled this revision from [services] Backup - Add server reactor implementations - recover backup key reactor to [draft] [services] Backup - Add server reactor implementations - recover backup key reactor.Mar 24 2022, 2:47 AM
tomek requested changes to this revision.Mar 24 2022, 8:17 AM
tomek added inline comments.
services/backup/docker-server/contents/server/src/Reactors/server/RecoverBackupKeyReactor.h
25–30 ↗(On Diff #10645)

Can we move it to cpp file?

This revision now requires changes to proceed.Mar 24 2022, 8:17 AM
karol added inline comments.
services/backup/docker-server/contents/server/src/Reactors/server/RecoverBackupKeyReactor.h
25–30 ↗(On Diff #10645)
This revision is now accepted and ready to land.Mar 25 2022, 8:44 AM
karol retitled this revision from [draft] [services] Backup - Add server reactor implementations - recover backup key reactor to [services] Backup - Add server reactor implementations - recover backup key reactor.

It is accepted as a draft so I removed the draft label and I'm requesting changes once again to keep the appropriate order of events.

tomek requested changes to this revision.Mar 28 2022, 9:55 AM

It looks like something went wrong during rebase as this diff (the last revision of it) now contains changes from BackupServiceImpl

This revision now requires changes to proceed.Mar 28 2022, 9:55 AM
This revision is now accepted and ready to land.Mar 29 2022, 5:23 AM