Page MenuHomePhabricator

[services] Backup - Create new backup - Add database operations
ClosedPublic

Authored by karol on Mar 29 2022, 4:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 29, 9:26 PM
Unknown Object (File)
Sun, Oct 13, 4:36 PM
Unknown Object (File)
Sun, Oct 13, 4:36 PM
Unknown Object (File)
Sun, Oct 13, 4:36 PM
Unknown Object (File)
Sun, Oct 13, 4:36 PM
Unknown Object (File)
Sun, Oct 13, 4:36 PM
Unknown Object (File)
Sun, Oct 13, 4:35 PM
Unknown Object (File)
Sun, Oct 13, 4:32 PM

Details

Summary

Depends on D3534

Add database operations for creating a new backup.

These operations should be performed only when we successfully upload data to the S3.

Test Plan

You need 3 terminals
1:

cd services
yarn run-backup-service

2:

cd services
yarn run-blob-service

3:
You can use https://github.com/karol-bisztyga/grpc-playground/tree/backup-async

./build.sh
./cmake/build/bin/client

then in the GUI use the n option (just type n and hit enter, this stands for creating a new backup).

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

karol edited the test plan for this revision. (Show Details)
karol added reviewers: tomek, varun, jim, max.
tomek added inline comments.
services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h
87 ↗(On Diff #10808)

Do we still need this comment?

89 ↗(On Diff #10808)

We had a task somewhere to confirm this. Have we agreed that this is the correct solution?

This revision is now accepted and ready to land.Apr 1 2022, 4:27 AM
services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h
89 ↗(On Diff #10808)

https://linear.app/comm/issue/ENG-918/implement-generating-backup-id

I proposed <backup_id>:<compaction|log_id>:<blob_id>:<UUID> there

services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h
87 ↗(On Diff #10808)

Probably not as we're going to cover this in the task.

89 ↗(On Diff #10808)

It is not a correct solution but since we have a task for this, it can be done later.