Page MenuHomePhabricator

[services] Backup - Pull more mutual code from base reactors - Apply in server reactors
ClosedPublic

Authored by karol on Apr 20 2022, 3:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 1:15 PM
Unknown Object (File)
Fri, Dec 20, 1:15 PM
Unknown Object (File)
Fri, Dec 20, 1:15 PM
Unknown Object (File)
Fri, Dec 20, 1:15 PM
Unknown Object (File)
Fri, Dec 20, 1:15 PM
Unknown Object (File)
Fri, Dec 20, 1:15 PM
Unknown Object (File)
Fri, Dec 20, 1:15 PM
Unknown Object (File)
Fri, Dec 20, 1:01 PM

Details

Summary

Depends on D3786

https://linear.app/comm/issue/ENG-916/consider-pulling-more-mutual-code-from-the-async-reactors

Applying inheriting the BaseRactor in the server reactors

Test Plan
cd services
yarn run-backup-service

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

karol edited the summary of this revision. (Show Details)

update

ashoat requested changes to this revision.Apr 20 2022, 7:59 PM

Let's find a way to avoid using multiple inheritance, see comment in D3786

This revision now requires changes to proceed.Apr 20 2022, 7:59 PM
ashoat requested changes to this revision.Apr 21 2022, 10:14 AM

When you update a diff for a rebase without addressing comments, please hit "Plan Changes" to remove that diff from your reviewers' queue

This revision now requires changes to proceed.Apr 21 2022, 10:14 AM

Let's find a way to avoid using multiple inheritance, see comment in D3786

planned changes because of this

This revision is now accepted and ready to land.Apr 28 2022, 11:55 AM