Page MenuHomePhabricator
Differential D3801

[services] Blob - synchronize status access in reactors
AbandonedPublic
Actions

Authored by • karol on Apr 20 2022, 11:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 30, 8:15 AM
Unknown Object (File)
Sun, Jun 30, 8:15 AM
Unknown Object (File)
Sun, Jun 30, 8:15 AM
Unknown Object (File)
Sun, Jun 30, 8:14 AM
Unknown Object (File)
Sun, Jun 30, 8:09 AM
Unknown Object (File)
Tue, Jun 25, 9:30 AM
Unknown Object (File)
Tue, Jun 25, 7:48 AM
Unknown Object (File)
Tue, Jun 25, 1:52 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
ashoat
Summary

Depends on D3800

The issue was raised in https://phabricator.ashoat.com/D3720#103334 and I decided it would be the best to handle synchronization in the mutual code, therefore I first wanted to implement pulling services' mutual code into a single master class.

This is for the blob service.

Test Plan
cd services
yarn run-blob-service

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Apr 20 2022, 11:58 PM
Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 20 2022, 11:58 PM
• karol edited the summary of this revision. (Show Details)Apr 21 2022, 12:01 AM
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol edited the summary of this revision. (Show Details)
• karol added a parent revision: D3800: [services] Backup - synchronize status access in reactors.
Harbormaster completed remote builds in B8382: Diff 11694.Apr 21 2022, 12:05 AM
• karol requested review of this revision.Apr 21 2022, 12:05 AM
• karol added a child revision: D3802: [services] Fix clang paths.Apr 21 2022, 12:18 AM
ashoat requested changes to this revision.Apr 21 2022, 10:17 AM

Let's find a way to avoid using multiple inheritance, see comment in D3786

This revision now requires changes to proceed.Apr 21 2022, 10:17 AM
• karol updated this revision to Diff 11792.Apr 22 2022, 5:20 AM

rebase

• karol planned changes to this revision.Apr 22 2022, 5:20 AM
In D3801#105469, @ashoat wrote:

Let's find a way to avoid using multiple inheritance, see comment in D3786

planning changes because of this

• karol updated this revision to Diff 11793.Apr 22 2022, 5:21 AM

fix rebase

• karol planned changes to this revision.Apr 22 2022, 5:22 AM
In D3801#105469, @ashoat wrote:

Let's find a way to avoid using multiple inheritance, see comment in D3786

planning changes because of this

Harbormaster completed remote builds in B8454: Diff 11793.Apr 22 2022, 5:27 AM
Harbormaster completed remote builds in B8453: Diff 11792.
• karol added a child revision: D3814: [services] Blob - Add holder to the blob DB if data exists.Apr 28 2022, 6:17 AM
• karol abandoned this revision.Apr 28 2022, 7:01 AM

This will no longer be needed in the new version of this stack (I'm going to transfer any unfinished threads)

Revision Contents
Changeset List

PathSize
services/
blob/
src/
Reactors/
17 lines
server/
3 lines
base-reactors/
33 lines
12 lines
12 lines

Diff 11793

View Options

services/blob/src/Reactors/BaseReactor.h

Loading...
View Options

services/blob/src/Reactors/server/PutReactor.h

Loading...
View Options

services/blob/src/Reactors/server/base-reactors/ServerBidiReactorBase.h

Loading...
View Options

services/blob/src/Reactors/server/base-reactors/ServerReadReactorBase.h

Loading...
View Options

services/blob/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

Loading...