Differential D3722

[services] Backup - return error when inner client reactor fails
ClosedPublic
Actions

Authored by • karol on Apr 13 2022, 2:05 PM.

Details

Reviewers

tomek

Commits

rCOMM7f579732af3f: [services] Backup - return error when inner client reactor fails

Summary

Depends on D3804

We need to propagate =errors from the client reactors that are spawned in the server reactors.

Test Plan

The same as in D3535 but this time perform actions from the gRPC client without starting a blob service and see that the client receives proper errors indicating that there's a connection problem.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Apr 13 2022, 2:05 PM

Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 13 2022, 2:05 PM

• karol edited the summary of this revision. (Show Details)Apr 13 2022, 2:15 PM

• karol edited the test plan for this revision. (Show Details)

• karol added a reviewer: tomek.

• karol added a parent revision: D3721: [services] Backup/Blob - wrap terminateCallback into try...catch.

• karol added inline comments.Apr 13 2022, 2:17 PM

services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h
117 ↗	(On Diff #11420)	We only want to wait until the client is still working, if it is done, there is no point.

Harbormaster completed remote builds in B8158: Diff 11420.Apr 13 2022, 2:18 PM

• karol requested review of this revision.Apr 13 2022, 2:18 PM

• karol added a child revision: D3727: [services] Backup/Blob - Add comments to delete this.Apr 14 2022, 10:24 AM

ashoat added inline comments.Apr 14 2022, 2:38 PM

services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h
112–118 ↗	(On Diff #11420)
services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h
192–198 ↗	(On Diff #11420)	Same feedback

As @ashoat suggested: please reduce the indentation

This revision now requires changes to proceed.Apr 21 2022, 8:15 AM

• karol edited the summary of this revision. (Show Details)Apr 21 2022, 9:24 AM

• karol added a parent revision: D3804: [services] Backup/Blob - Use this when reffering status.

reduce indents

Harbormaster completed remote builds in B8394: Diff 11710.Apr 21 2022, 10:12 AM

tomek accepted this revision.Apr 21 2022, 3:22 PM

This revision is now accepted and ready to land.Apr 21 2022, 3:22 PM

Closed by commit rCOMM7f579732af3f: [services] Backup - return error when inner client reactor fails. · Explain WhyApr 22 2022, 8:08 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM7f579732af3f: [services] Backup - return error when inner client reactor fails.

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

Reactors/

server/

CreateNewBackupReactor.h

8 lines

PullBackupReactor.h

7 lines

SendLogReactor.h

6 lines

Diff 11767

View Options

services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h

View Options

services/backup/docker-server/contents/server/src/Reactors/server/PullBackupReactor.h

View Options

services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h

[services] Backup - return error when inner client reactor failsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 11767

services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h

services/backup/docker-server/contents/server/src/Reactors/server/PullBackupReactor.h

services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h

[services] Backup - return error when inner client reactor fails
ClosedPublic
Actions

Revision Contents
Changeset List