Page MenuHomePhabricator

[services] Backup - return error when inner client reactor fails
ClosedPublic

Authored by karol on Apr 13 2022, 7:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 8:38 PM
Unknown Object (File)
Tue, Nov 19, 7:14 PM
Unknown Object (File)
Tue, Nov 19, 7:14 PM
Unknown Object (File)
Mon, Nov 18, 10:15 AM
Unknown Object (File)
Mon, Nov 18, 10:14 AM
Unknown Object (File)
Tue, Nov 5, 5:19 PM
Unknown Object (File)
Sat, Nov 2, 9:41 AM
Unknown Object (File)
Oct 27 2024, 10:13 PM

Details

Summary

Depends on D3804

We need to propagate =errors from the client reactors that are spawned in the server reactors.

Test Plan

The same as in D3535 but this time perform actions from the gRPC client without starting a blob service and see that the client receives proper errors indicating that there's a connection problem.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

karol edited the test plan for this revision. (Show Details)
karol added a reviewer: tomek.
services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h
117 ↗(On Diff #11420)

We only want to wait until the client is still working, if it is done, there is no point.

services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h
112–118 ↗(On Diff #11420)
services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h
192–198 ↗(On Diff #11420)

Same feedback

tomek requested changes to this revision.Apr 21 2022, 1:15 AM

As @ashoat suggested: please reduce the indentation

This revision now requires changes to proceed.Apr 21 2022, 1:15 AM
karol edited the summary of this revision. (Show Details)

reduce indents

This revision is now accepted and ready to land.Apr 21 2022, 8:22 AM