Page MenuHomePhabricator
Differential D3722

[services] Backup - return error when inner client reactor fails
ClosedPublic
Actions

Authored by • karol on Apr 13 2022, 7:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 8:38 PM
Unknown Object (File)
Tue, Nov 19, 7:14 PM
Unknown Object (File)
Tue, Nov 19, 7:14 PM
Unknown Object (File)
Mon, Nov 18, 10:15 AM
Unknown Object (File)
Mon, Nov 18, 10:14 AM
Unknown Object (File)
Tue, Nov 5, 5:19 PM
Unknown Object (File)
Sat, Nov 2, 9:41 AM
Unknown Object (File)
Oct 27 2024, 10:13 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
Commits
rCOMM7f579732af3f: [services] Backup - return error when inner client reactor fails
Summary

Depends on D3804

We need to propagate =errors from the client reactors that are spawned in the server reactors.

Test Plan

The same as in D3535 but this time perform actions from the gRPC client without starting a blob service and see that the client receives proper errors indicating that there's a connection problem.

Diff Detail

Repository
rCOMM Comm
Branch
backup-blob
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Apr 13 2022, 7:05 AM
Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 13 2022, 7:05 AM
• karol edited the summary of this revision. (Show Details)Apr 13 2022, 7:15 AM
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D3721: [services] Backup/Blob - wrap terminateCallback into try...catch.
• karol added inline comments.Apr 13 2022, 7:17 AM
services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h
117

We only want to wait until the client is still working, if it is done, there is no point.

Harbormaster completed remote builds in B8158: Diff 11420.Apr 13 2022, 7:18 AM
• karol requested review of this revision.Apr 13 2022, 7:18 AM
• karol added a child revision: D3727: [services] Backup/Blob - Add comments to delete this.Apr 14 2022, 3:24 AM
ashoat added inline comments.Apr 14 2022, 7:38 AM
services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h
112–118
services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h
192–198

Same feedback

tomek requested changes to this revision.Apr 21 2022, 1:15 AM

As @ashoat suggested: please reduce the indentation

This revision now requires changes to proceed.Apr 21 2022, 1:15 AM
• karol edited the summary of this revision. (Show Details)Apr 21 2022, 2:24 AM
• karol added a parent revision: D3804: [services] Backup/Blob - Use this when reffering status.
• karol updated this revision to Diff 11710.Apr 21 2022, 3:07 AM
• karol edited the summary of this revision. (Show Details)

reduce indents

Harbormaster completed remote builds in B8394: Diff 11710.Apr 21 2022, 3:12 AM
tomek accepted this revision.Apr 21 2022, 8:22 AM
This revision is now accepted and ready to land.Apr 21 2022, 8:22 AM
Closed by commit rCOMM7f579732af3f: [services] Backup - return error when inner client reactor fails (authored by • karol). · Explain WhyApr 22 2022, 1:08 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM7f579732af3f: [services] Backup - return error when inner client reactor fails.

Revision Contents
Changeset List

PathSize
services/
backup/
docker-server/
contents/
server/
src/
Reactors/
server/
10 lines
7 lines
8 lines

Diff 11420

View Options

services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h

Loading...
View Options

services/backup/docker-server/contents/server/src/Reactors/server/PullBackupReactor.h

Loading...
View Options

services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h

Loading...