Page MenuHomePhabricator
Differential D3771

[services] Blob - Fix done callback logic for put reactor
ClosedPublic
Actions

Authored by • karol on Apr 19 2022, 1:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 2, 6:50 AM
Unknown Object (File)
Sun, Jun 30, 10:02 AM
Unknown Object (File)
Sun, Jun 30, 10:02 AM
Unknown Object (File)
Sun, Jun 30, 10:02 AM
Unknown Object (File)
Sun, Jun 30, 10:02 AM
Unknown Object (File)
Sun, Jun 30, 10:02 AM
Unknown Object (File)
Sun, Jun 30, 10:00 AM
Unknown Object (File)
Sat, Jun 29, 5:00 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
Commits
rCOMMdeda7ce87679: [services] Blob - Fix done callback logic for put reactor
Summary

Depends on D3738

I think we should simplify the logic here. So, whenever the uploader is not initialized, we want to break the execution of doneCallback. Additionally, we keep track of whether the data already exists or not.

Test Plan

Use blob service like in D3535

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Apr 19 2022, 1:55 AM
Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 19 2022, 1:55 AM
Harbormaster completed remote builds in B8293: Diff 11589.Apr 19 2022, 2:02 AM
• karol requested review of this revision.Apr 19 2022, 2:02 AM
• karol planned changes to this revision.Apr 19 2022, 2:08 AM
• karol edited the summary of this revision. (Show Details)
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D3738: [services] Backup/Blob - Pull backup logic fixes.
• karol updated this revision to Diff 11597.Apr 19 2022, 2:09 AM

update

• karol added a child revision: D3772: [services] Blob - Add append holder to proto.Apr 19 2022, 2:12 AM
Harbormaster completed remote builds in B8301: Diff 11597.Apr 19 2022, 2:55 AM
tomek accepted this revision.Apr 21 2022, 1:38 AM
tomek added inline comments.
services/blob/src/Reactors/server/PutReactor.h
78–85 ↗(On Diff #11597)

What do you think about reducing indentation here?

This revision is now accepted and ready to land.Apr 21 2022, 1:38 AM
• karol added inline comments.Apr 22 2022, 1:03 AM
services/blob/src/Reactors/server/PutReactor.h
78–85 ↗(On Diff #11597)

Ok, but I find this more readable

• karol updated this revision to Diff 11766.Apr 22 2022, 1:04 AM

reduce indent

This revision was landed with ongoing or failed builds.Apr 22 2022, 1:08 AM
Closed by commit rCOMMdeda7ce87679: [services] Blob - Fix done callback logic for put reactor (authored by • karol). · Explain Why
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMdeda7ce87679: [services] Blob - Fix done callback logic for put reactor.
Harbormaster completed remote builds in B8433: Diff 11766.Apr 22 2022, 1:09 AM

Revision Contents
Changeset List

PathSize
services/
blob/
src/
Reactors/
server/
12 lines

Diff 11772

View Options

services/blob/src/Reactors/server/PutReactor.h

Loading...