Page MenuHomePhabricator
Differential D3803

[services] Backup/Blob - Add validate method to server write reactor base
ClosedPublic
Actions

Authored by • karol on Apr 21 2022, 2:23 AM.
Tags
None
Referenced Files
F5765776: D3803.id11718.diff
Mon, Apr 14, 4:23 PM
F5765775: D3803.id.diff
Mon, Apr 14, 4:23 PM
Unknown Object (File)
Fri, Apr 11, 11:39 AM
Unknown Object (File)
Fri, Apr 11, 11:39 AM
Unknown Object (File)
Tue, Apr 8, 8:12 AM
Unknown Object (File)
Tue, Apr 8, 6:44 AM
Unknown Object (File)
Tue, Apr 8, 5:10 AM
Unknown Object (File)
Sun, Apr 6, 8:34 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
Commits
rCOMM5aefcb036f32: [services] Backup/Blob - Add validate method to server write reactor base
Summary

Depends on D3721

Adding the validate method to the server write reactor base

Test Plan
cd services
yarn run-backup-service
yarn run-blob-service

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Apr 21 2022, 2:23 AM
Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 21 2022, 2:23 AM
• karol added a child revision: D3804: [services] Backup/Blob - Use this when reffering status.Apr 21 2022, 2:26 AM
• karol edited the summary of this revision. (Show Details)
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D3721: [services] Backup/Blob - wrap terminateCallback into try...catch.
• karol mentioned this in D3721: [services] Backup/Blob - wrap terminateCallback into try...catch.Apr 21 2022, 2:28 AM
Harbormaster completed remote builds in B8392: Diff 11708.Apr 21 2022, 2:30 AM
• karol requested review of this revision.Apr 21 2022, 2:30 AM
tomek accepted this revision.Apr 21 2022, 2:36 AM
This revision is now accepted and ready to land.Apr 21 2022, 2:36 AM
Closed by commit rCOMM5aefcb036f32: [services] Backup/Blob - Add validate method to server write reactor base (authored by • karol). · Explain WhyApr 21 2022, 3:19 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM5aefcb036f32: [services] Backup/Blob - Add validate method to server write reactor base.

Revision Contents
Changeset List

PathSize
services/
backup/
docker-server/
contents/
server/
src/
Reactors/
server/
base-reactors/
2 lines
blob/
src/
Reactors/
server/
base-reactors/
2 lines

Diff 11718

View Options

services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

Show First 20 Lines • Show All 85 Lines • ▼ Show 20 Lines output: {
filename: 'app.build.cjs', filename: 'app.build.cjs',
library: 'app', library: 'app',
libraryTarget: 'commonjs2', libraryTarget: 'commonjs2',
path: path.join(__dirname, 'dist'), path: path.join(__dirname, 'dist'),
}, },
}; };
const baseWebWorkersConfig = { const baseWebWorkersConfig = {
plugins: [
new CopyPlugin({
patterns: [
{
from: 'node_modules/sql.js/dist/sql-wasm.wasm',
to: path.join(__dirname, 'dist'),
},
],
}),
],
entry: { entry: {
pushNotif: './push-notif/service-worker.js', pushNotif: './push-notif/service-worker.js',
database: './database/worker/db-worker.js', database: './database/worker/db-worker.js',
}, },
output: { output: {
filename: '[name].build.js', filename: '[name].build.js',
path: path.join(__dirname, 'dist', 'webworkers'), path: path.join(__dirname, 'dist', 'webworkers'),
}, },
resolve: { resolve: {
fallback: { fallback: {
crypto: false, crypto: false,
fs: false, fs: false,
path: false, path: false,
}, },
}, },
}; };
const devWebWorkersPlugins = [
new CopyPlugin({
patterns: [
{
from: 'node_modules/sql.js/dist/sql-wasm.wasm',
to: path.join(__dirname, 'dist', 'webworkers'),
},
],
}),
];
const prodWebWorkersPlugins = [
new CopyPlugin({
patterns: [
{
from: 'node_modules/sql.js/dist/sql-wasm.wasm',
to: path.join(
__dirname,
'dist',
'webworkers',
'sql-wasm.[contenthash:12].wasm',
),
},
],
}),
new WebpackManifestPlugin({
publicPath: '',
}),
];
module.exports = function (env) { module.exports = function (env) {
const browserConfig = env.prod const browserConfig = env.prod
? createProdBrowserConfig(baseProdBrowserConfig, babelConfig) ? createProdBrowserConfig(baseProdBrowserConfig, babelConfig)
: createDevBrowserConfig(baseDevBrowserConfig, babelConfig); : createDevBrowserConfig(baseDevBrowserConfig, babelConfig);
const nodeConfig = createNodeServerRenderingConfig( const nodeConfig = createNodeServerRenderingConfig(
baseNodeServerRenderingConfig, baseNodeServerRenderingConfig,
babelConfig, babelConfig,
); );
const nodeServerRenderingConfig = { const nodeServerRenderingConfig = {
...nodeConfig, ...nodeConfig,
mode: env.prod ? 'production' : 'development', mode: env.prod ? 'production' : 'development',
}; };
const workersConfig = {
...baseWebWorkersConfig,
plugins: env.prod ? prodWebWorkersPlugins : devWebWorkersPlugins,
};
const webWorkersConfig = createWebWorkersConfig( const webWorkersConfig = createWebWorkersConfig(
env, env,
baseWebWorkersConfig, workersConfig,
babelConfig, babelConfig,
); );
return [browserConfig, nodeServerRenderingConfig, webWorkersConfig]; return [browserConfig, nodeServerRenderingConfig, webWorkersConfig];
}; };
View Options

services/blob/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

Show First 20 Lines • Show All 85 Lines • ▼ Show 20 Lines output: {
filename: 'app.build.cjs', filename: 'app.build.cjs',
library: 'app', library: 'app',
libraryTarget: 'commonjs2', libraryTarget: 'commonjs2',
path: path.join(__dirname, 'dist'), path: path.join(__dirname, 'dist'),
}, },
}; };
const baseWebWorkersConfig = { const baseWebWorkersConfig = {
plugins: [
new CopyPlugin({
patterns: [
{
from: 'node_modules/sql.js/dist/sql-wasm.wasm',
to: path.join(__dirname, 'dist'),
},
],
}),
],
entry: { entry: {
pushNotif: './push-notif/service-worker.js', pushNotif: './push-notif/service-worker.js',
database: './database/worker/db-worker.js', database: './database/worker/db-worker.js',
}, },
output: { output: {
filename: '[name].build.js', filename: '[name].build.js',
path: path.join(__dirname, 'dist', 'webworkers'), path: path.join(__dirname, 'dist', 'webworkers'),
}, },
resolve: { resolve: {
fallback: { fallback: {
crypto: false, crypto: false,
fs: false, fs: false,
path: false, path: false,
}, },
}, },
}; };
const devWebWorkersPlugins = [
new CopyPlugin({
patterns: [
{
from: 'node_modules/sql.js/dist/sql-wasm.wasm',
to: path.join(__dirname, 'dist', 'webworkers'),
},
],
}),
];
const prodWebWorkersPlugins = [
new CopyPlugin({
patterns: [
{
from: 'node_modules/sql.js/dist/sql-wasm.wasm',
to: path.join(
__dirname,
'dist',
'webworkers',
'sql-wasm.[contenthash:12].wasm',
),
},
],
}),
new WebpackManifestPlugin({
publicPath: '',
}),
];
module.exports = function (env) { module.exports = function (env) {
const browserConfig = env.prod const browserConfig = env.prod
? createProdBrowserConfig(baseProdBrowserConfig, babelConfig) ? createProdBrowserConfig(baseProdBrowserConfig, babelConfig)
: createDevBrowserConfig(baseDevBrowserConfig, babelConfig); : createDevBrowserConfig(baseDevBrowserConfig, babelConfig);
const nodeConfig = createNodeServerRenderingConfig( const nodeConfig = createNodeServerRenderingConfig(
baseNodeServerRenderingConfig, baseNodeServerRenderingConfig,
babelConfig, babelConfig,
); );
const nodeServerRenderingConfig = { const nodeServerRenderingConfig = {
...nodeConfig, ...nodeConfig,
mode: env.prod ? 'production' : 'development', mode: env.prod ? 'production' : 'development',
}; };
const workersConfig = {
...baseWebWorkersConfig,
plugins: env.prod ? prodWebWorkersPlugins : devWebWorkersPlugins,
};
const webWorkersConfig = createWebWorkersConfig( const webWorkersConfig = createWebWorkersConfig(
env, env,
baseWebWorkersConfig, workersConfig,
babelConfig, babelConfig,
); );
return [browserConfig, nodeServerRenderingConfig, webWorkersConfig]; return [browserConfig, nodeServerRenderingConfig, webWorkersConfig];
}; };