Page MenuHomePhabricator
Differential D3803

[services] Backup/Blob - Add validate method to server write reactor base
ClosedPublic
Actions

Authored by • karol on Apr 21 2022, 2:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 18, 5:29 PM
Unknown Object (File)
Fri, Apr 18, 5:29 PM
Unknown Object (File)
Thu, Apr 17, 12:40 PM
Unknown Object (File)
Thu, Apr 17, 9:07 AM
Unknown Object (File)
Thu, Apr 17, 1:36 AM
Unknown Object (File)
Tue, Apr 15, 8:06 PM
Unknown Object (File)
Mon, Apr 14, 4:23 PM
Unknown Object (File)
Mon, Apr 14, 4:23 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
Commits
rCOMM5aefcb036f32: [services] Backup/Blob - Add validate method to server write reactor base
Summary

Depends on D3721

Adding the validate method to the server write reactor base

Test Plan
cd services
yarn run-backup-service
yarn run-blob-service

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Apr 21 2022, 2:23 AM
Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 21 2022, 2:23 AM
• karol added a child revision: D3804: [services] Backup/Blob - Use this when reffering status.Apr 21 2022, 2:26 AM
• karol edited the summary of this revision. (Show Details)
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D3721: [services] Backup/Blob - wrap terminateCallback into try...catch.
• karol mentioned this in D3721: [services] Backup/Blob - wrap terminateCallback into try...catch.Apr 21 2022, 2:28 AM
Harbormaster completed remote builds in B8392: Diff 11708.Apr 21 2022, 2:30 AM
• karol requested review of this revision.Apr 21 2022, 2:30 AM
tomek accepted this revision.Apr 21 2022, 2:36 AM
This revision is now accepted and ready to land.Apr 21 2022, 2:36 AM
Closed by commit rCOMM5aefcb036f32: [services] Backup/Blob - Add validate method to server write reactor base (authored by • karol). · Explain WhyApr 21 2022, 3:19 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM5aefcb036f32: [services] Backup/Blob - Add validate method to server write reactor base.

Revision Contents
Changeset List

PathSize
services/
backup/
docker-server/
contents/
server/
src/
Reactors/
server/
base-reactors/
2 lines
blob/
src/
Reactors/
server/
base-reactors/
2 lines

Diff 11708

View Options

services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

#pragma once #pragma once
#include <grpcpp/grpcpp.h> #include <grpcpp/grpcpp.h>
#include <mutex>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
enum class ReactorState { enum class ReactorState {
NONE = 0, NONE = 0,
RUNNING = 1, RUNNING = 1,
TERMINATED = 2, TERMINATED = 2,
DONE = 3, DONE = 3,
}; };
class BaseReactor { class BaseReactor {
private:
grpc::Status status = grpc::Status::OK;
std::mutex statusAccessMutex;
protected: protected:
ReactorState state = ReactorState::NONE; ReactorState state = ReactorState::NONE;
public: public:
grpc::Status getStatus() {
const std::unique_lock<std::mutex> lock(this->statusAccessMutex);
return this->status;
}
void setStatus(const grpc::Status &status) {
const std::unique_lock<std::mutex> lock(this->statusAccessMutex);
this->status = status;
}
ReactorState getState() const { ReactorState getState() const {
return this->state; return this->state;
} }
virtual void terminate(const grpc::Status &status){}; virtual void terminate(const grpc::Status &status){};
virtual void validate(){}; virtual void validate(){};
virtual void doneCallback(){}; virtual void doneCallback(){};
virtual void terminateCallback(){}; virtual void terminateCallback(){};
}; };
} // namespace reactor } // namespace reactor
} // namespace network } // namespace network
} // namespace comm } // namespace comm
View Options

services/blob/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

#pragma once #pragma once
#include <grpcpp/grpcpp.h> #include <grpcpp/grpcpp.h>
#include <mutex>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
enum class ReactorState { enum class ReactorState {
NONE = 0, NONE = 0,
RUNNING = 1, RUNNING = 1,
TERMINATED = 2, TERMINATED = 2,
DONE = 3, DONE = 3,
}; };
class BaseReactor { class BaseReactor {
private:
grpc::Status status = grpc::Status::OK;
std::mutex statusAccessMutex;
protected: protected:
ReactorState state = ReactorState::NONE; ReactorState state = ReactorState::NONE;
public: public:
grpc::Status getStatus() {
const std::unique_lock<std::mutex> lock(this->statusAccessMutex);
return this->status;
}
void setStatus(const grpc::Status &status) {
const std::unique_lock<std::mutex> lock(this->statusAccessMutex);
this->status = status;
}
ReactorState getState() const { ReactorState getState() const {
return this->state; return this->state;
} }
virtual void terminate(const grpc::Status &status){}; virtual void terminate(const grpc::Status &status){};
virtual void validate(){}; virtual void validate(){};
virtual void doneCallback(){}; virtual void doneCallback(){};
virtual void terminateCallback(){}; virtual void terminateCallback(){};
}; };
} // namespace reactor } // namespace reactor
} // namespace network } // namespace network
} // namespace comm } // namespace comm