Page MenuHomePhabricator

[services] Blob - Fix reading data from S3
ClosedPublic

Authored by karol on Apr 1 2022, 3:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 4:06 PM
Unknown Object (File)
Mon, Mar 17, 6:16 AM
Unknown Object (File)
Sat, Mar 15, 11:27 AM
Unknown Object (File)
Fri, Mar 14, 10:05 AM
Unknown Object (File)
Thu, Mar 13, 1:48 PM
Unknown Object (File)
Tue, Mar 11, 3:49 PM
Unknown Object (File)
Mon, Mar 10, 3:37 AM
Unknown Object (File)
Mon, Mar 10, 3:37 AM

Details

Summary

Depends on D3651

Raised in https://phabricator.ashoat.com/D3470#97072

We want to fix reading the S3 object so it doesn't cut the stream on \n

Test Plan
cd services
yarn test-blob-service

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek added inline comments.
services/blob/src/AwsS3Bucket.cpp
122–123 ↗(On Diff #10933)

Why do we need to resize?

This revision is now accepted and ready to land.Apr 1 2022, 3:38 AM
services/blob/src/AwsS3Bucket.cpp
122–123 ↗(On Diff #10933)

We don't. It is a leftover. It was used to allocate the mem up front.

This revision was landed with ongoing or failed builds.Apr 13 2022, 4:58 AM
This revision was automatically updated to reflect the committed changes.