[services] Backup - Handle empty attachment holders
ClosedPublic
Actions

Authored by • karol on Mar 30 2022, 5:03 AM.

Details

Reviewers

tomek
• max
• jim
varun

Commits

rCOMM74f1479cd257: [services] Backup - Handle empty attachment holders

Summary

Depends on D3558

We have to cover the case when there are no attachments in the backup(in theory this is possible)

Test Plan

cd services
yarn run-backup-service

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Mar 30 2022, 5:03 AM

Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptMar 30 2022, 5:03 AM

• karol edited the summary of this revision. (Show Details)Mar 30 2022, 5:08 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max, • jim, varun.

• karol added a parent revision: D3558: [services] Backup - Send log - Add basic logic.

• karol added a child revision: D3560: [services] Backup/Blob - Add terminateCallback.Mar 30 2022, 5:13 AM

Harbormaster completed remote builds in B7708: Diff 10810.Mar 30 2022, 5:16 AM

• karol requested review of this revision.Mar 30 2022, 5:16 AM

tomek accepted this revision.Apr 1 2022, 4:38 AM

This revision is now accepted and ready to land.Apr 1 2022, 4:38 AM

Closed by commit rCOMM74f1479cd257: [services] Backup - Handle empty attachment holders (authored by • karol). · Explain WhyApr 7 2022, 2:45 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM74f1479cd257: [services] Backup - Handle empty attachment holders.

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

DatabaseManager.cpp

8 lines

Diff 11155

View Options

services/backup/docker-server/contents/server/src/DatabaseManager.cpp

[services] Backup - Handle empty attachment holdersClosedPublicActions