Page MenuHomePhabricator
Differential D3804

[services] Backup/Blob - Use this when reffering status
ClosedPublic
Actions

Authored by • karol on Apr 21 2022, 2:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 4, 1:57 AM
Unknown Object (File)
Wed, Jul 3, 12:23 PM
Unknown Object (File)
Sun, Jun 30, 10:56 AM
Unknown Object (File)
Sun, Jun 30, 10:56 AM
Unknown Object (File)
Sun, Jun 30, 10:56 AM
Unknown Object (File)
Sun, Jun 30, 10:52 AM
Unknown Object (File)
Sat, Jun 22, 10:08 AM
Unknown Object (File)
Thu, Jun 20, 11:03 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
Commits
rCOMMcc6f856b5658: [services] Backup/Blob - Use this when reffering status
Summary

Depends on D3803

Add this-> when referring to status in base reactor classes

Test Plan
cd services
yarn run-backup-service
yarn run-blob-service

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Apr 21 2022, 2:23 AM
Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 21 2022, 2:23 AM
• karol added a child revision: D3722: [services] Backup - return error when inner client reactor fails.Apr 21 2022, 2:24 AM
• karol edited the summary of this revision. (Show Details)
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D3803: [services] Backup/Blob - Add validate method to server write reactor base.
• karol mentioned this in D3721: [services] Backup/Blob - wrap terminateCallback into try...catch.Apr 21 2022, 2:28 AM
Harbormaster completed remote builds in B8393: Diff 11709.Apr 21 2022, 2:32 AM
• karol requested review of this revision.Apr 21 2022, 2:32 AM
tomek accepted this revision.Apr 21 2022, 2:36 AM
This revision is now accepted and ready to land.Apr 21 2022, 2:36 AM
Closed by commit rCOMMcc6f856b5658: [services] Backup/Blob - Use this when reffering status (authored by • karol). · Explain WhyApr 21 2022, 3:20 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMcc6f856b5658: [services] Backup/Blob - Use this when reffering status.

Revision Contents
Changeset List

PathSize
services/
backup/
docker-server/
contents/
server/
src/
Reactors/
server/
base-reactors/
2 lines
2 lines
blob/
src/
Reactors/
server/
base-reactors/
2 lines
2 lines

Diff 11719

View Options

services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerReadReactorBase.h

Loading...
View Options

services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

Loading...
View Options

services/blob/src/Reactors/server/base-reactors/ServerReadReactorBase.h

Loading...
View Options

services/blob/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

Loading...