Page MenuHomePhabricator
Differential D3804

[services] Backup/Blob - Use this when reffering status
ClosedPublic
Actions

Authored by • karol on Apr 21 2022, 2:23 AM.
Tags
None
Referenced Files
F5765778: D3804.id11719.diff
Mon, Apr 14, 4:23 PM
F5765777: D3804.id.diff
Mon, Apr 14, 4:23 PM
F5757140: D3804.diff
Mon, Apr 14, 12:12 PM
Unknown Object (File)
Fri, Apr 11, 11:39 AM
Unknown Object (File)
Fri, Apr 11, 11:39 AM
Unknown Object (File)
Thu, Apr 10, 9:46 AM
Unknown Object (File)
Tue, Apr 8, 8:21 AM
Unknown Object (File)
Tue, Apr 8, 8:05 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
Commits
rCOMMcc6f856b5658: [services] Backup/Blob - Use this when reffering status
Summary

Depends on D3803

Add this-> when referring to status in base reactor classes

Test Plan
cd services
yarn run-backup-service
yarn run-blob-service

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Apr 21 2022, 2:23 AM
Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 21 2022, 2:23 AM
• karol added a child revision: D3722: [services] Backup - return error when inner client reactor fails.Apr 21 2022, 2:24 AM
• karol edited the summary of this revision. (Show Details)
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D3803: [services] Backup/Blob - Add validate method to server write reactor base.
• karol mentioned this in D3721: [services] Backup/Blob - wrap terminateCallback into try...catch.Apr 21 2022, 2:28 AM
Harbormaster completed remote builds in B8393: Diff 11709.Apr 21 2022, 2:32 AM
• karol requested review of this revision.Apr 21 2022, 2:32 AM
tomek accepted this revision.Apr 21 2022, 2:36 AM
This revision is now accepted and ready to land.Apr 21 2022, 2:36 AM
Closed by commit rCOMMcc6f856b5658: [services] Backup/Blob - Use this when reffering status (authored by • karol). · Explain WhyApr 21 2022, 3:20 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMcc6f856b5658: [services] Backup/Blob - Use this when reffering status.

Revision Contents
Changeset List

PathSize
services/
backup/
docker-server/
contents/
server/
src/
Reactors/
server/
base-reactors/
2 lines
2 lines
blob/
src/
Reactors/
server/
base-reactors/
2 lines
2 lines

Diff 11719

View Options

services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerReadReactorBase.h

  • This file was copied from services/backup/src/Reactors/client/blob/BlobGetClientReactor.h.
#pragma once
#include "ClientReadReactorBase.h" #include "BlobGetClientReactor.h"
#include "../_generated/blob.grpc.pb.h"
#include "../_generated/blob.pb.h"
#include <folly/MPMCQueue.h>
#include <grpcpp/grpcpp.h>
#include <memory>
#include <string>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
class BlobGetClientReactor
: public ClientReadReactorBase<blob::GetRequest, blob::GetResponse> {
std::string holder;
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks;
public:
BlobGetClientReactor(
const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks);
std::unique_ptr<grpc::Status>
readResponse(blob::GetResponse &response) override;
void doneCallback() override;
grpc::Status getStatus() const;
};
BlobGetClientReactor::BlobGetClientReactor( BlobGetClientReactor::BlobGetClientReactor(
const std::string &holder, const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks) std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks)
: holder(holder), dataChunks(dataChunks) { : holder(holder), dataChunks(dataChunks) {
} }
std::unique_ptr<grpc::Status> std::unique_ptr<grpc::Status>
BlobGetClientReactor::readResponse(blob::GetResponse &response) { BlobGetClientReactor::readResponse(blob::GetResponse &response) {
Show All 17 Lines
View Options

services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

  • This file was copied from services/backup/src/Reactors/client/blob/BlobGetClientReactor.h.
#pragma once
#include "ClientReadReactorBase.h" #include "BlobGetClientReactor.h"
#include "../_generated/blob.grpc.pb.h"
#include "../_generated/blob.pb.h"
#include <folly/MPMCQueue.h>
#include <grpcpp/grpcpp.h>
#include <memory>
#include <string>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
class BlobGetClientReactor
: public ClientReadReactorBase<blob::GetRequest, blob::GetResponse> {
std::string holder;
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks;
public:
BlobGetClientReactor(
const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks);
std::unique_ptr<grpc::Status>
readResponse(blob::GetResponse &response) override;
void doneCallback() override;
grpc::Status getStatus() const;
};
BlobGetClientReactor::BlobGetClientReactor( BlobGetClientReactor::BlobGetClientReactor(
const std::string &holder, const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks) std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks)
: holder(holder), dataChunks(dataChunks) { : holder(holder), dataChunks(dataChunks) {
} }
std::unique_ptr<grpc::Status> std::unique_ptr<grpc::Status>
BlobGetClientReactor::readResponse(blob::GetResponse &response) { BlobGetClientReactor::readResponse(blob::GetResponse &response) {
Show All 17 Lines
View Options

services/blob/src/Reactors/server/base-reactors/ServerReadReactorBase.h

  • This file was copied from services/backup/src/Reactors/client/blob/BlobGetClientReactor.h.
#pragma once
#include "ClientReadReactorBase.h" #include "BlobGetClientReactor.h"
#include "../_generated/blob.grpc.pb.h"
#include "../_generated/blob.pb.h"
#include <folly/MPMCQueue.h>
#include <grpcpp/grpcpp.h>
#include <memory>
#include <string>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
class BlobGetClientReactor
: public ClientReadReactorBase<blob::GetRequest, blob::GetResponse> {
std::string holder;
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks;
public:
BlobGetClientReactor(
const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks);
std::unique_ptr<grpc::Status>
readResponse(blob::GetResponse &response) override;
void doneCallback() override;
grpc::Status getStatus() const;
};
BlobGetClientReactor::BlobGetClientReactor( BlobGetClientReactor::BlobGetClientReactor(
const std::string &holder, const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks) std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks)
: holder(holder), dataChunks(dataChunks) { : holder(holder), dataChunks(dataChunks) {
} }
std::unique_ptr<grpc::Status> std::unique_ptr<grpc::Status>
BlobGetClientReactor::readResponse(blob::GetResponse &response) { BlobGetClientReactor::readResponse(blob::GetResponse &response) {
Show All 17 Lines
View Options

services/blob/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

  • This file was copied from services/backup/src/Reactors/client/blob/BlobGetClientReactor.h.
#pragma once
#include "ClientReadReactorBase.h" #include "BlobGetClientReactor.h"
#include "../_generated/blob.grpc.pb.h"
#include "../_generated/blob.pb.h"
#include <folly/MPMCQueue.h>
#include <grpcpp/grpcpp.h>
#include <memory>
#include <string>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
class BlobGetClientReactor
: public ClientReadReactorBase<blob::GetRequest, blob::GetResponse> {
std::string holder;
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks;
public:
BlobGetClientReactor(
const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks);
std::unique_ptr<grpc::Status>
readResponse(blob::GetResponse &response) override;
void doneCallback() override;
grpc::Status getStatus() const;
};
BlobGetClientReactor::BlobGetClientReactor( BlobGetClientReactor::BlobGetClientReactor(
const std::string &holder, const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks) std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks)
: holder(holder), dataChunks(dataChunks) { : holder(holder), dataChunks(dataChunks) {
} }
std::unique_ptr<grpc::Status> std::unique_ptr<grpc::Status>
BlobGetClientReactor::readResponse(blob::GetResponse &response) { BlobGetClientReactor::readResponse(blob::GetResponse &response) {
Show All 17 Lines