Paths

Table of Contentst

-
services/backup/docker-server/contents/server/src/Reactors/server/
-
backup/
-
docker-server/
-
contents/
-
server/
-
src/
-
Reactors/
-
server/
-
SendLogReactor.h

[services] Backup - Send log - add generate holder
ClosedPublic
Actions

Authored by • karol on Apr 7 2022, 7:21 AM.

Details

Reviewers

tomek
• max

Commits

rCOMM94b856ae807d: [services] Backup - Send log - add generate holder

Summary

Depends on D3648

Adding the generateHolder method - for now, it's mocked, but I think it's important to be aware that it should be implemented and this diff clearly indicates that.

Test Plan

cd services
yarn run-backup-service

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Apr 7 2022, 7:21 AM

Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 7 2022, 7:21 AM

• karol edited the summary of this revision. (Show Details)Apr 7 2022, 7:30 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max.

• karol added a parent revision: D3648: [services] Backup - Send log - add reactor state mutex.

• karol added a child revision: D3650: [services] Backup - Send log - add terminate callback.

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 7 2022, 8:34 AM

Harbormaster failed remote builds in B7969: Diff 11173!

Harbormaster completed remote builds in B7969: Diff 11173.Apr 7 2022, 8:59 AM

• karol requested review of this revision.Apr 7 2022, 8:59 AM

tomek accepted this revision.Apr 8 2022, 1:33 AM

This revision is now accepted and ready to land.Apr 8 2022, 1:33 AM

Closed by commit rCOMM94b856ae807d: [services] Backup - Send log - add generate holder (authored by • karol). · Explain WhyApr 13 2022, 4:21 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM94b856ae807d: [services] Backup - Send log - add generate holder.

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

Reactors/

server/

SendLogReactor.h

6 lines

Diff 11396

View Options

services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h

#include <grpcpp/grpcpp.h>		#include <grpcpp/grpcpp.h>

namespace comm {		namespace comm {
namespace network {		namespace network {
namespace reactor {		namespace reactor {

template <class Request, class Response>		template <class Request, class Response>
class ClientWriteReactorBase : public grpc::ClientWriteReactor<Request> {		class ClientWriteReactorBase : public grpc::ClientWriteReactor<Request> {
grpc::Status status;		grpc::Status status = grpc::Status::OK;
bool done = false;		bool done = false;
bool initialized = 0;		bool initialized = 0;
Request request;		Request request;

public:		public:
Response response;		Response response;
grpc::ClientContext context;		grpc::ClientContext context;

void nextWrite();		void nextWrite();
void OnWriteDone(bool ok) override;		void OnWriteDone(bool ok) override;
void terminate(const grpc::Status &status);		void terminate(const grpc::Status &status);
bool isDone();		bool isDone();
void OnDone(const grpc::Status &status) override;		void OnDone(const grpc::Status &status) override;

virtual std::unique_ptr<grpc::Status> prepareRequest(Request &request) = 0;		virtual std::unique_ptr<grpc::Status> prepareRequest(Request &request) = 0;
		virtual void validate(){};
virtual void doneCallback(){};		virtual void doneCallback(){};
virtual void terminateCallback(){};		virtual void terminateCallback(){};
};		};

template <class Request, class Response>		template <class Request, class Response>
void ClientWriteReactorBase<Request, Response>::nextWrite() {		void ClientWriteReactorBase<Request, Response>::nextWrite() {
this->request = Request();		this->request = Request();
std::unique_ptr<grpc::Status> status = this->prepareRequest(this->request);		std::unique_ptr<grpc::Status> status = this->prepareRequest(this->request);
Show All 15 Lines	if (!ok) {
return;		return;
}		}
this->nextWrite();		this->nextWrite();
}		}

template <class Request, class Response>		template <class Request, class Response>
void ClientWriteReactorBase<Request, Response>::terminate(		void ClientWriteReactorBase<Request, Response>::terminate(
const grpc::Status &status) {		const grpc::Status &status) {
this->terminateCallback();		if (this->status.ok()) {
if (this->done) {		this->status = status;
return;
}		}
if (!this->status.ok()) {		if (!this->status.ok()) {
std::cout << "error: " << this->status.error_message() << std::endl;		std::cout << "error: " << this->status.error_message() << std::endl;
}		}
this->status = status;		if (this->done) {
		return;
		}
		this->terminateCallback();
		try {
		this->validate();
		} catch (std::runtime_error &e) {
		this->status = grpc::Status(grpc::StatusCode::INTERNAL, e.what());
		}
this->done = true;		this->done = true;
this->StartWritesDone();		this->StartWritesDone();
}		}

template <class Request, class Response>		template <class Request, class Response>
bool ClientWriteReactorBase<Request, Response>::isDone() {		bool ClientWriteReactorBase<Request, Response>::isDone() {
return this->done;		return this->done;
}		}
Show All 11 Lines

[services] Backup - Send log - add generate holderClosedPublicActions