Page MenuHomePhabricator
Differential D3649

[services] Backup - Send log - add generate holder
ClosedPublic
Actions

Authored by • karol on Apr 7 2022, 7:21 AM.
Tags
None
Referenced Files
F5314376: D3649.diff
Tue, Apr 8, 4:46 PM
F5309508: D3649.id11173.diff
Tue, Apr 8, 6:58 AM
Unknown Object (File)
Sun, Apr 6, 10:06 AM
Unknown Object (File)
Sun, Apr 6, 10:06 AM
Unknown Object (File)
Sun, Apr 6, 10:06 AM
Unknown Object (File)
Tue, Apr 1, 2:21 AM
Unknown Object (File)
Mon, Mar 31, 10:42 PM
Unknown Object (File)
Mon, Mar 31, 4:23 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
• max
Commits
rCOMM94b856ae807d: [services] Backup - Send log - add generate holder
Summary

Depends on D3648

Adding the generateHolder method - for now, it's mocked, but I think it's important to be aware that it should be implemented and this diff clearly indicates that.

Test Plan
cd services
yarn run-backup-service

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Apr 7 2022, 7:21 AM
Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 7 2022, 7:21 AM
• karol edited the summary of this revision. (Show Details)Apr 7 2022, 7:30 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, • max.
• karol added a parent revision: D3648: [services] Backup - Send log - add reactor state mutex.
• karol added a child revision: D3650: [services] Backup - Send log - add terminate callback.
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 7 2022, 8:34 AM
Harbormaster failed remote builds in B7969: Diff 11173!
Harbormaster completed remote builds in B7969: Diff 11173.Apr 7 2022, 8:59 AM
• karol requested review of this revision.Apr 7 2022, 8:59 AM
tomek accepted this revision.Apr 8 2022, 1:33 AM
This revision is now accepted and ready to land.Apr 8 2022, 1:33 AM
Closed by commit rCOMM94b856ae807d: [services] Backup - Send log - add generate holder (authored by • karol). · Explain WhyApr 13 2022, 4:21 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM94b856ae807d: [services] Backup - Send log - add generate holder.

Revision Contents
Changeset List

PathSize
services/
backup/
docker-server/
contents/
server/
src/
Reactors/
server/
6 lines

Diff 11396

View Options

services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h

Loading...