Page MenuHomePhabricator
Differential D3729

[services] Backup - Check if log item isn't too big to be stored in the database
ClosedPublic
Actions

Authored by • karol on Apr 14 2022, 3:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 2, 8:09 PM
Unknown Object (File)
Sun, Jun 30, 2:31 PM
Unknown Object (File)
Sun, Jun 30, 10:56 AM
Unknown Object (File)
Sun, Jun 30, 10:56 AM
Unknown Object (File)
Sun, Jun 30, 10:56 AM
Unknown Object (File)
Sun, Jun 30, 10:52 AM
Unknown Object (File)
Wed, Jun 26, 2:00 AM
Unknown Object (File)
Mon, Jun 24, 3:45 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
Commits
rCOMM9f8fa95e2afa: [services] Backup - Check if log item isn't too big to be stored in the database
Summary

Depends on D3728

https://linear.app/comm/issue/ENG-725/check-for-the-data-size-and-persistinblob-in-logitems-validate

Test Plan

It's hard to come up with a certain test plan here as this is just a sanity check. You can always check whether the service builds as usual:

cd services
yarn run-backup-service

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Apr 14 2022, 3:22 AM
Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 14 2022, 3:22 AM
• karol edited the summary of this revision. (Show Details)Apr 14 2022, 3:26 AM
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D3728: [services] Backup/Blob - Hide nextWrite, expose start.
Harbormaster completed remote builds in B8200: Diff 11471.Apr 14 2022, 3:34 AM
• karol requested review of this revision.Apr 14 2022, 3:34 AM
• karol added a child revision: D3738: [services] Backup/Blob - Pull backup logic fixes.Apr 15 2022, 1:13 AM
tomek accepted this revision.Apr 21 2022, 1:21 AM

I like diffs like this - it focuses on only one thing and the test plan has an explanation

This revision is now accepted and ready to land.Apr 21 2022, 1:21 AM
• karol added a comment.Apr 22 2022, 12:09 AM
In D3729#105034, @palys-swm wrote:

I like diffs like this - it focuses on only one thing and the test plan has an explanation

Thanks! I'm glad you liked it!

Closed by commit rCOMM9f8fa95e2afa: [services] Backup - Check if log item isn't too big to be stored in the database (authored by • karol). · Explain WhyApr 22 2022, 1:08 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM9f8fa95e2afa: [services] Backup - Check if log item isn't too big to be stored in the database.

Revision Contents
Changeset List

PathSize
services/
backup/
docker-server/
contents/
server/
src/
DatabaseEntities/
7 lines

Diff 11770

View Options

services/backup/docker-server/contents/server/src/DatabaseEntities/LogItem.cpp

Loading...