Page MenuHomePhabricator
Differential D3561

[services] Backup - Use terminateCallback for create new backup reactor
ClosedPublic
Actions

Authored by • karol on Mar 30 2022, 5:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 30, 11:31 AM
Unknown Object (File)
Sun, Jun 30, 11:31 AM
Unknown Object (File)
Sun, Jun 30, 11:31 AM
Unknown Object (File)
Sun, Jun 30, 11:31 AM
Unknown Object (File)
Sun, Jun 30, 11:28 AM
Unknown Object (File)
Wed, Jun 26, 10:43 PM
Unknown Object (File)
Tue, Jun 25, 1:26 PM
Unknown Object (File)
Tue, Jun 25, 8:26 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
• max
• jim
varun
Commits
rCOMM0d2aef2ffe0a: [services] Backup - Use terminateCallback for create new backup reactor
Summary

Depends on D3560

Use termination callback (added in the previous diff) in CreateNewBackupReactor.

Test Plan
cd services
yarn run-backup-service

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Mar 30 2022, 5:04 AM
Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptMar 30 2022, 5:04 AM
• karol added a child revision: D3562: [services] Backup - Add hash to send log request.Mar 30 2022, 5:13 AM
• karol edited the summary of this revision. (Show Details)
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, • max, • jim, varun.
• karol added a parent revision: D3560: [services] Backup/Blob - Add terminateCallback.
Harbormaster completed remote builds in B7710: Diff 10812.Mar 30 2022, 5:30 AM
• karol requested review of this revision.Mar 30 2022, 5:30 AM
tomek accepted this revision.Apr 1 2022, 4:59 AM
This revision is now accepted and ready to land.Apr 1 2022, 4:59 AM
• karol updated this revision to Diff 11138.Apr 7 2022, 1:13 AM

rebase

Harbormaster completed remote builds in B7949: Diff 11138.Apr 7 2022, 1:33 AM
Closed by commit rCOMM0d2aef2ffe0a: [services] Backup - Use terminateCallback for create new backup reactor (authored by • karol). · Explain WhyApr 7 2022, 2:46 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM0d2aef2ffe0a: [services] Backup - Use terminateCallback for create new backup reactor.

Revision Contents
Changeset List

PathSize
services/
backup/
docker-server/
contents/
server/
src/
Reactors/
server/
4 lines

Diff 11157

View Options

services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h

Loading...