Paths

Table of Contentst

Differential D3646

[services] Backup - Send log - initialize put reactor method
ClosedPublic
Actions

Authored by • karol on Apr 7 2022, 2:20 PM.

Tags

None

Referenced Files

	F32533842: D3646.1767155130.diff
	Tue, Dec 30, 4:25 AM

Subscribers

Details

Reviewers

tomek
• max

Commits

rCOMM423e9137192f: [services] Backup - Send log - initialize put reactor method

Summary

Depends on D3586

Adding a method called initializePutReactor for initializing the put client reactor

Test Plan

cd services
yarn run-backup-service

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Apr 7 2022, 2:20 PM

Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 7 2022, 2:20 PM

• karol edited the summary of this revision. (Show Details)Apr 7 2022, 2:26 PM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max.

• karol added a parent revision: D3586: [services] Backup - Send log - add store in database.

• karol added a child revision: D3647: [services] Backup - Send log - add backup id and log hash states.

Harbormaster completed remote builds in B7966: Diff 11170.Apr 7 2022, 3:31 PM

• karol requested review of this revision.Apr 7 2022, 3:31 PM

tomek requested changes to this revision.Apr 8 2022, 8:16 AM

tomek added inline comments.

services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h
41 ↗	(On Diff #11170)	Can we find a name which describes the purpose of it (like in D3488)?
76 ↗	(On Diff #11170)	Can we be more specific and tell what is actually missing?

This revision now requires changes to proceed.Apr 8 2022, 8:16 AM

• karol added inline comments.Apr 11 2022, 8:12 AM

services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h
41 ↗	(On Diff #11170)	We can go as well with `blobDoneCV`.
76 ↗	(On Diff #11170)	sure

update

Harbormaster completed remote builds in B8105: Diff 11332.Apr 12 2022, 8:06 AM

tomek accepted this revision.Apr 12 2022, 4:15 PM

This revision is now accepted and ready to land.Apr 12 2022, 4:15 PM

Closed by commit rCOMM423e9137192f: [services] Backup - Send log - initialize put reactor method. · Explain WhyApr 13 2022, 11:14 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM423e9137192f: [services] Backup - Send log - initialize put reactor method.

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

Reactors/

server/

SendLogReactor.h

22 lines

Diff 11393

services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h

Loading...