Depends on D3772
Adding AppendHolder to the blob service implementation.
https://linear.app/comm/issue/ENG-672/create-addreferencetohashbyholder-in-the-blob-service
Differential D3773 Authored by • karol on Apr 19 2022, 1:56 AM.
Details Summary Depends on D3772 Adding AppendHolder to the blob service implementation. https://linear.app/comm/issue/ENG-672/create-addreferencetohashbyholder-in-the-blob-service Test Plan cd services yarn run-blob-service
Diff Detail
Event TimelineHerald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 19 2022, 1:56 AM2022-04-19 01:56:35 (UTC-7) • karol edited the summary of this revision. (Show Details)Apr 19 2022, 2:14 AM2022-04-19 02:14:31 (UTC-7) Harbormaster completed remote builds in B8295: Diff 11591.Apr 19 2022, 2:15 AM2022-04-19 02:15:54 (UTC-7) Comment Actions This diff depends on an ongoing proto discussion - this is really inefficient. We should put up a diff with .proto / arch review way before starting the implementation. The current pattern makes it expensive to do any significant changes. Overall it looks ok! This revision is now accepted and ready to land.Apr 21 2022, 2:03 AM2022-04-21 02:03:06 (UTC-7) This revision now requires changes to proceed.Apr 21 2022, 1:35 PM2022-04-21 13:35:14 (UTC-7) Comment Actions
I wouldn't land a diff that has at least one unaccepted predecessor but I understand your concern. Comment Actions This is a part of mistakenly added code, more details in https://phabricator.ashoat.com/D3772#105661. Abandoning. Sorry for the inconvenience, thank you for the review.
Revision Contents
Diff 11591 |