Details

Reviewers

tomek
varun
• jim
• max

Commits

rCOMM7d6a6c2dae19: [services] Backup - Create new backup - Add database operations

Summary

Depends on D3534

Add database operations for creating a new backup.

These operations should be performed only when we successfully upload data to the S3.

Test Plan

You need 3 terminals
1:

cd services
yarn run-backup-service

cd services
yarn run-blob-service

3:
You can use https://github.com/karol-bisztyga/grpc-playground/tree/backup-async

./build.sh
./cmake/build/bin/client

then in the GUI use the n option (just type n and hit enter, this stands for creating a new backup).

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Mar 29 2022, 4:40 AM

Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptMar 29 2022, 4:40 AM

• karol edited the summary of this revision. (Show Details)Mar 29 2022, 4:53 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, varun, • jim, • max.

• karol added a parent revision: D3534: [services] Backup - Print out errors in reactors.

• karol published this revision for review.Mar 29 2022, 4:55 AM

Harbormaster completed remote builds in B7672: Diff 10768.Mar 29 2022, 5:09 AM

• karol planned changes to this revision.Mar 30 2022, 12:00 AM

update

• karol planned changes to this revision.Mar 30 2022, 12:01 AM

add todo

Harbormaster completed remote builds in B7705: Diff 10807.Mar 30 2022, 12:17 AM

Harbormaster completed remote builds in B7706: Diff 10808.

• karol added a child revision: D3558: [services] Backup - Send log - Add basic logic.Mar 30 2022, 5:07 AM

• karol mentioned this in D3582: [services] Backup/Blob - fix handling reading done in server reactors.Mar 31 2022, 6:36 AM

tomek accepted this revision.Apr 1 2022, 4:27 AM

tomek added inline comments.

services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h
87	Do we still need this comment?
89	We had a task somewhere to confirm this. Have we agreed that this is the correct solution?

This revision is now accepted and ready to land.Apr 1 2022, 4:27 AM

ashoat added inline comments.Apr 1 2022, 11:32 AM

services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h
89	https://linear.app/comm/issue/ENG-918/implement-generating-backup-id I proposed `<backup_id>:<compaction\|log_id>:<blob_id>:<UUID>` there

• karol mentioned this in D3610: [services] Backup - Set backup id in create new backup reactor's response.Apr 4 2022, 7:28 AM

• karol added inline comments.Apr 4 2022, 11:34 PM

services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h
87	Probably not as we're going to cover this in the task.
89	It is not a correct solution but since we have a task for this, it can be done later.

• karol mentioned this in D3626: [services] Backup - client base reactors - terminate on error.Apr 6 2022, 7:48 AM

• karol mentioned this in D3627: [services] Backup - Update proto file for pull backup.

• karol mentioned this in D3628: [services] Backup - Update service implementation for pull backup.Apr 6 2022, 7:51 AM

• karol mentioned this in D3629: [services] Backup - Add blob get client reactor.

• karol mentioned this in D3630: [services] Backup - Add find backup item to database manager.Apr 6 2022, 7:53 AM

• karol mentioned this in D3632: [services] Backup - Implement get method in service blob client.Apr 6 2022, 7:55 AM

• karol mentioned this in D3633: [services] Backup - pull backup reactor - initialize get reactor.

• karol mentioned this in D3637: [services] Backup - pull backup reactor - compaction - initialize.

• karol mentioned this in D3634: [services] Backup - pull backup reactor - compaction - write response.Apr 6 2022, 7:58 AM

• karol mentioned this in D3635: [services] Backup - Log item - handle lack of attachment holders.

• karol mentioned this in D3636: [services] Backup - pull backup reactor - logs - write response.

rebase

Harbormaster completed remote builds in B7952: Diff 11141.Apr 7 2022, 2:04 AM

Closed by commit rCOMM7d6a6c2dae19: [services] Backup - Create new backup - Add database operations (authored by • karol). · Explain WhyApr 7 2022, 2:44 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM7d6a6c2dae19: [services] Backup - Create new backup - Add database operations.

• karol mentioned this in rCOMMebf2965eff40: [services] Backup/Blob - fix handling reading done in server reactors.Apr 13 2022, 4:01 AM

• karol mentioned this in rCOMM1a7f4c28508f: [services] Backup - Set backup id in create new backup reactor's response.Apr 13 2022, 4:58 AM

• karol mentioned this in rCOMM86a2e7264640: [services] Backup - client base reactors - terminate on error.

• karol mentioned this in rCOMMfb75447e707a: [services] Backup - Update proto file for pull backup.

• karol mentioned this in rCOMMffec9cf8362a: [services] Backup - Add blob get client reactor.Apr 13 2022, 5:11 AM

• karol mentioned this in rCOMM7b2140c8acb4: [services] Backup - Add find backup item to database manager.

• karol mentioned this in rCOMMfb2954458f33: [services] Backup - Implement get method in service blob client.Apr 13 2022, 5:22 AM

• karol mentioned this in rCOMM56ca2282dde4: [services] Backup - pull backup reactor - initialize get reactor.

• karol mentioned this in rCOMMc593d0fa82e5: [services] Backup - pull backup reactor - compaction - initialize.

• karol mentioned this in rCOMMbf058231b3df: [services] Backup - pull backup reactor - compaction - write response.

• karol mentioned this in rCOMM797df3207b7f: [services] Backup - Log item - handle lack of attachment holders.

• karol mentioned this in D3722: [services] Backup - return error when inner client reactor fails.Apr 13 2022, 7:15 AM

• karol mentioned this in D3728: [services] Backup/Blob - Hide nextWrite, expose start.Apr 14 2022, 3:25 AM

• karol mentioned this in D3738: [services] Backup/Blob - Pull backup logic fixes.Apr 15 2022, 1:13 AM

• karol mentioned this in D3771: [services] Blob - Fix done callback logic for put reactor.Apr 19 2022, 2:08 AM

• karol mentioned this in D3777: [services] Backup - Improve code style in create new backup reactor.Apr 19 2022, 2:21 AM

• karol mentioned this in D3778: [services] Backup - Improve code style in send log reactor.

• karol mentioned this in rCOMM6a19136b312a: [services] Backup - pull backup reactor - logs - write response.Apr 21 2022, 1:47 AM

• karol mentioned this in D3774: [services] Backup - Add append holder reactor.Apr 21 2022, 6:56 AM

• karol mentioned this in rCOMM7f579732af3f: [services] Backup - return error when inner client reactor fails.Apr 22 2022, 1:08 AM

• karol mentioned this in rCOMMfb4294397173: [services] Backup/Blob - Hide nextWrite, expose start.

• karol mentioned this in rCOMMb96835d88caa: [services] Backup/Blob - Pull backup logic fixes.

• karol mentioned this in rCOMMdeda7ce87679: [services] Blob - Fix done callback logic for put reactor.

• karol mentioned this in D3814: [services] Blob - Add holder to the blob DB if data exists.Apr 22 2022, 5:27 AM

• karol mentioned this in rCOMM0c31fe651db3: [services] Blob - Add holder to the blob DB if data exists.May 5 2022, 1:47 AM

[services] Backup - Create new backup - Add database operations
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 10808

services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h

[services] Backup - Create new backup - Add database operationsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 10808

services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h

[services] Backup - Create new backup - Add database operations
ClosedPublic
Actions

Revision Contents
Changeset List